From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 6AB268E7C for ; Wed, 25 Apr 2018 17:59:30 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id f15so15607835pfn.0 for ; Wed, 25 Apr 2018 08:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JWVqKNB7y9cRnvgnhh1ig6lLUE8in4Ra/CjYSnaWvtE=; b=NEs0x8b+AWa7AXqWI+MwKiVLiyOkm9Qls3zdNkeW7ccByAMzu9sbohPf2O7JR605DG jBwdVh90RK/3P0GSJzswX5sisI/Euyswl023QclUcZdVnVHSD34q903knq3JiCHQLH9V J9GcbB/Kb1ollPt2glQ5XRXe8QKXl6FFZg5aMONOz9+MAvdF/OXsidT6CQdDxO2HSIH7 jvAtsjYaCH7qziI6sLcpetNsX6bY77wE5IshgD/qAismjQG/XYm9DWS6bAPJD2+I7gaJ dP69SFP3t6ihJOhO6AJsnyY1iYhbSeLnWbIlxu1tvMZmvnvQ144Wpi9zd1n70HlJ8M7t yywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JWVqKNB7y9cRnvgnhh1ig6lLUE8in4Ra/CjYSnaWvtE=; b=aEurf3JICf5BPCUqxBkyBQ8ADylcRAfWnVyyr+YUBK5zFVWjR19ZT7Yt3P1bxGgDEP Ojn7NSTN9uXSb6v0bu44oaMLYjUy8IWdrIoT263g0EowtapVPqIbzJl2CoZREPXdjoYa ywDX12NMrYPwTYbLKlEkL/1zD913kC+uNX+725DwGJucTLtSRpDOiAhndx2bTxY6XrcT 7KkjmZgoummyzn11H6tt7LTQnU2UO1Wxs1DR1B4TPulG9sYx1hPxLeRI9FTe0WGznIxN gnb2JVdV9BWMCZeTljd3J27upQc/PMe2fJkZSiWhINuInPpgvIw11N7SpqePkd/qipy0 m8NQ== X-Gm-Message-State: ALQs6tBKCB/1lsBrjYXV6OdlDuK4YHq2PDYTqWCy7evw3GPfIT52GogE 6klwMmSXYCLjQvZdrWun23BNdv7T1pw= X-Google-Smtp-Source: AIpwx4+eeuwTAiPvWV5hMPO91bJTfgtqyJf5b9jaCf/ikBG7tRvTCwmdfTZg75e8lGY7GmB5AHrgpw== X-Received: by 10.99.169.1 with SMTP id u1mr24945014pge.251.1524671969530; Wed, 25 Apr 2018 08:59:29 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id r20sm37574191pff.165.2018.04.25.08.59.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Apr 2018 08:59:29 -0700 (PDT) Date: Wed, 25 Apr 2018 08:59:27 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180425085927.01682876@xeon-e3> In-Reply-To: <1524663944-30376-1-git-send-email-arnon@qwilt.com> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524663944-30376-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 00/10] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 15:59:30 -0000 On Wed, 25 Apr 2018 16:45:34 +0300 Arnon Warshavsky wrote: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This patch modifies the majority of rte_panic calls > under lib and drivers, and replaces them with a log message > and an error return code according to context, > that can be propagated up the call stack. > > - Focus was given to the dpdk initialization path > - Some of the panic calls within drivers were left in place where > the call is from within an interrupt or calls that are > on the data path,where there is no simple applicative > route to propagate the error to temination. > These should be handled by the driver maintainers.. > - local void functions with no api were changed to retrun a value > where needed > - No change took place in example and test files > - No change took place for debug assertions calling panic > - A new function was added to devtools/checkpatches.sh > in order to prevent new additions of calls to rte_panic > under lib and drivers. > > Keep calm and don't panic > > --- > > v2: > - reformat error messages so that literal string are in the same line > - fix typo in commit message > - add new return code to doxigen of rte_memzone_free() > > v3: > - submit all 13 patches changed and unchanged in the same patchset > > v4: > - remove 2 patches that are no more relevant > - fix split literal string in error message > - change return value -1 to enum > - split value and success code in a static function > > v5: > - reword commit messages > - revert thread related instances back to panicing > - handle file descriptors with state to reset after eal init failure > in case re initialization takes place > > v6: > - Use pmd log macro rather than rte_log > > v7: > - use bond specific , dpaa2 specific and eventdev specific log macros > > v8: > - Seperate the 2 drivers salad back to distinct bond and dpaa patches > - Add missing file descriptor closing when returnning an error > - Remove half baked thread patch to be handled in the next version > - Remove duplicate function call after rebase > > Arnon Warshavsky (10): > crypto/dpaa: replace rte_panic instances in crypto/dpaa driver > bond: replace rte_panic instances in bonding driver > e1000: replace rte_panic instances in e1000 driver > ixgbe: replace rte_panic instances in ixgbe driver > eal: replace rte_panic instances in eventdev > kni: replace rte_panic instances in kni > eal: replace rte_panic instances in hugepage_info > eal: replace rte_panic instances in ethdev > eal: replace rte_panic instances in init sequence > devtools: prevent new instances of rte_panic and rte_exit > > devtools/checkpatches.sh | 95 +++++++++++++++++++- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +- > drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++- > drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++--- > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +- > drivers/net/bonding/rte_eth_bond_api.c | 22 +++-- > drivers/net/bonding/rte_eth_bond_pmd.c | 9 +- > drivers/net/bonding/rte_eth_bond_private.h | 2 +- > drivers/net/e1000/e1000_ethdev.h | 2 +- > drivers/net/e1000/igb_ethdev.c | 4 +- > drivers/net/e1000/igb_pf.c | 15 ++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > drivers/net/ixgbe/ixgbe_pf.c | 15 ++-- > lib/librte_eal/bsdapp/eal/eal.c | 69 +++++++++++---- > lib/librte_eal/linuxapp/eal/eal.c | 101 +++++++++++++++------- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +++++--- > lib/librte_ether/rte_ethdev.c | 42 ++++++--- > lib/librte_ether/rte_ethdev.h | 4 +- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +- > lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +- > lib/librte_kni/rte_kni.c | 18 ++-- > lib/librte_kni/rte_kni_fifo.h | 11 ++- > 23 files changed, 383 insertions(+), 136 deletions(-) > Looks good. Thanks for following through and fixing this. Reviewed-by: Stephen Hemminger