From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id CD6767EE4 for ; Wed, 25 Apr 2018 17:27:53 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id n10so7535852wmc.1 for ; Wed, 25 Apr 2018 08:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R55B5npFmuot3C0JLs4h1hJWWIZJhniiQEuouMVMYK4=; b=iTk2slUfwzYNcFPJagsfwGede3g8B1ftIYFYHvGZTXzHPXny+WiCGO6kZncCQ/grzt szumfPAqhnBvogA7ZLxJilfVeuBxDmeUWlGgpo53dbPQkp/WHNgA2G9g2AILhsvJqrLJ 5s2Jy7HdruZAP3ByWkriQ/fY8ptkDbYhg4be+jPq5jymnzbST4ekC9gEfHpVC5gGa+2J 0TFyi5jQIChtk0YMjTBFMOwhfV3x2P8o9Bd0bt004Dz50FY7g37D/2dfAj+3S5W5IW9B lpOlScL8u9eScx/z/xxGE7wNLM3EM82nmrb0FeulGnj6VptP5nN2GG0sbBNdSNWxMtHc CHow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R55B5npFmuot3C0JLs4h1hJWWIZJhniiQEuouMVMYK4=; b=KAiu8lpgs331eGckijcnGQO4V9FY8jU/JgJxXyT3cxlpsttXDRLrspAkQdy5qQ8gOI nseJJj8+dI8Hnoox50o3WDrErYvr4bSI95rGjsmFEvWlVme569azDT93xMEsPO6xWQDX g7ukRZ2CHyn6d83qBRc9Rxf3WWgnN+gXkadW/pCzQBfv016zuJC3cU1qwuleQvjkTA86 toTihJe3UVQoYxjpaYdzIg1U31ahSSuTXk8RJlY3ak3yZVe5P9tCwaVGvFOJoDqXpIle 4j7QGqkBRfc7yOyBMNg9AUjfNyInBIOiZ16TyZS8C06+nc8ugzgVA+DYZ+7nrE40+b/U 6sXQ== X-Gm-Message-State: ALQs6tB90ojjIWBapyQYjy48yxujcJnQHKErG36uVlTYphm5NeXeuI4z gn/gFz4c4Qt7RUUs6pq0NecE6w== X-Google-Smtp-Source: AIpwx49PnfWhPXuMkZ1IF+ReF7Sx633V1NygpfLtTO5mHI5Xh6Ax1iiAbEq4Lf8Bmh1cW3xkh1711A== X-Received: by 10.28.101.6 with SMTP id z6mr14239390wmb.86.1524670073435; Wed, 25 Apr 2018 08:27:53 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z72sm14006412wmc.28.2018.04.25.08.27.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 08:27:52 -0700 (PDT) Date: Wed, 25 Apr 2018 17:27:38 +0200 From: Adrien Mazarguil To: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180425151852.7676-2-adrien.mazarguil@6wind.com> References: <20180419100848.6178-1-adrien.mazarguil@6wind.com> <20180425151852.7676-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425151852.7676-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v6 01/16] ethdev: add error types to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 15:27:54 -0000 These enable more precise reporting of objects responsible for errors. This breaks ABI compatibility for the following public functions: - rte_flow_create() - rte_flow_destroy() - rte_flow_error_set() - rte_flow_flush() - rte_flow_isolate() - rte_flow_query() - rte_flow_validate() Signed-off-by: Adrien Mazarguil Acked-by: Andrew Rybchenko --- v6 changes: Updated ABI changes section in release notes. --- app/test-pmd/config.c | 4 ++++ doc/guides/rel_notes/release_18_05.rst | 7 +++++++ lib/librte_ether/rte_ethdev_version.map | 14 +++++++------- lib/librte_ether/rte_flow.h | 4 ++++ 4 files changed, 22 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 216a7eb4e..b275d759d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1261,8 +1261,12 @@ port_flow_complain(struct rte_flow_error *error) [RTE_FLOW_ERROR_TYPE_ATTR_EGRESS] = "egress field", [RTE_FLOW_ERROR_TYPE_ATTR] = "attributes structure", [RTE_FLOW_ERROR_TYPE_ITEM_NUM] = "pattern length", + [RTE_FLOW_ERROR_TYPE_ITEM_SPEC] = "item specification", + [RTE_FLOW_ERROR_TYPE_ITEM_LAST] = "item specification range", + [RTE_FLOW_ERROR_TYPE_ITEM_MASK] = "item specification mask", [RTE_FLOW_ERROR_TYPE_ITEM] = "specific pattern item", [RTE_FLOW_ERROR_TYPE_ACTION_NUM] = "number of actions", + [RTE_FLOW_ERROR_TYPE_ACTION_CONF] = "action configuration", [RTE_FLOW_ERROR_TYPE_ACTION] = "specific action", }; const char *errstr; diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 752a2c308..e50caa74a 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/doc/guides/rel_notes/release_18_05.rst @@ -283,6 +283,13 @@ ABI Changes type ``uint16_t``: ``burst_size``, ``ring_size``, and ``nb_queues``. These are parameter values recommended for use by the PMD. +* ethdev: ABI for most flow API functions was updated. + + This includes functions ``rte_flow_create``, ``rte_flow_destroy``, + ``rte_flow_error_set``, ``rte_flow_flush``, ``rte_flow_isolate``, + ``rte_flow_query`` and ``rte_flow_validate``, due to changes in error type + definitions (``enum rte_flow_error_type``). + Removed Items ------------- diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map index 02713e430..180d2ca2d 100644 --- a/lib/librte_ether/rte_ethdev_version.map +++ b/lib/librte_ether/rte_ethdev_version.map @@ -127,11 +127,6 @@ DPDK_17.02 { _rte_eth_dev_reset; rte_eth_dev_fw_version_get; - rte_flow_create; - rte_flow_destroy; - rte_flow_flush; - rte_flow_query; - rte_flow_validate; } DPDK_16.07; @@ -153,7 +148,6 @@ DPDK_17.08 { _rte_eth_dev_callback_process; rte_eth_dev_adjust_nb_rx_tx_desc; rte_flow_copy; - rte_flow_isolate; rte_tm_capabilities_get; rte_tm_hierarchy_commit; rte_tm_level_capabilities_get; @@ -192,7 +186,6 @@ DPDK_17.11 { rte_eth_dev_get_sec_ctx; rte_eth_dev_pool_ops_supported; rte_eth_dev_reset; - rte_flow_error_set; } DPDK_17.08; @@ -208,6 +201,13 @@ DPDK_18.05 { rte_eth_dev_count_avail; rte_eth_find_next_owned_by; + rte_flow_create; + rte_flow_destroy; + rte_flow_error_set; + rte_flow_flush; + rte_flow_isolate; + rte_flow_query; + rte_flow_validate; } DPDK_18.02; diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index 44ae19d3b..26b95c772 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib/librte_ether/rte_flow.h @@ -1186,8 +1186,12 @@ enum rte_flow_error_type { RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, /**< Egress field. */ RTE_FLOW_ERROR_TYPE_ATTR, /**< Attributes structure. */ RTE_FLOW_ERROR_TYPE_ITEM_NUM, /**< Pattern length. */ + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, /**< Item specification. */ + RTE_FLOW_ERROR_TYPE_ITEM_LAST, /**< Item specification range. */ + RTE_FLOW_ERROR_TYPE_ITEM_MASK, /**< Item specification mask. */ RTE_FLOW_ERROR_TYPE_ITEM, /**< Specific pattern item. */ RTE_FLOW_ERROR_TYPE_ACTION_NUM, /**< Number of actions. */ + RTE_FLOW_ERROR_TYPE_ACTION_CONF, /**< Action configuration. */ RTE_FLOW_ERROR_TYPE_ACTION, /**< Specific action. */ }; -- 2.11.0