DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check
Date: Wed, 25 Apr 2018 18:27:05 +0200	[thread overview]
Message-ID: <20180425162705.GU4957@6wind.com> (raw)
In-Reply-To: <20180425133816.198161-1-qi.z.zhang@intel.com>

On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote:
> After add RSS hash offload check, default rss_hf  will fail on
> devices that not support all bits, the patch take rss_hf as
> a suggest value and only set bits that device supported base on
> rte_eth_dev_get_info, also rss_hf will only be updated when new
> rss offload is successfully updated on all ports by
> "port config all rss [!default]" command.
> 
> Fixes: 586ac442be96 ("ethdev: add supported hash function check")
> Fixes: 8c1f4aff92a6 ("app/testpmd: new parameter for port config all RSS command")
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Although this approach prevents updating rss_hf if at least one port doesn't
support RSS configuration (i.e. it can't be used to update defaults for
subsequent flow rules on mlx4), I confirm it does fix the startup issue,
therefore:

Tested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

  parent reply	other threads:[~2018-04-25 16:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  1:49 [dpdk-dev] [PATCH] " Qi Zhang
2018-04-25  7:43 ` [dpdk-dev] [PATCH v2] " Qi Zhang
2018-04-25 12:03   ` Ferruh Yigit
2018-04-25 13:34     ` Zhang, Qi Z
2018-04-25 13:38 ` [dpdk-dev] [PATCH v3] " Qi Zhang
2018-04-25 14:02   ` Ferruh Yigit
2018-04-25 16:27   ` Adrien Mazarguil [this message]
2018-04-25 16:34     ` Ferruh Yigit
2018-04-25 23:46     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425162705.GU4957@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).