From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 84E2A6D81 for ; Wed, 25 Apr 2018 18:27:20 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id j4so8199586wme.1 for ; Wed, 25 Apr 2018 09:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3eafOnquRu31ZoiTyMWBg7KaEJPlJR76KAT7WFrNM5g=; b=BB2L0WUXijz8VFBep/0KSSS70sbZVbhJ6q+yZvJgwwLp9g0pRkkS3FreG+Ch2s6Zwz AKEEHeRuyEoDgMHgwprZAoJs8U5/mngg3sJi+d9jAbxA1/TOH9WlHuzXzE7qEfg+lofF i5T6Yju6E5p6xi8z26yypHij9SFU7M9Z0M5ZeiB4zRRBAq+dDKs7531n7HZoS4nKIpdF FQ9WAW2vA1T1qZeC3V9SVgeVhzDI4u6HNGRDysDkJ8Qqh9M//0G5GQFlHU04qQpKgaGU SMlDKAyzlBxECU+5e4nhRsWBGCBK3pDLGlMVcqlisU/mY4aVV6O0oV2Ja0X91bK6dcA4 VWJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3eafOnquRu31ZoiTyMWBg7KaEJPlJR76KAT7WFrNM5g=; b=T0Pok9KhwfQ7TPQnUzjQNa8cW1Nt2tH7UE4IRA327JsjMq7IBahc5gXzIIVi6MKxs5 AfCTqdCjhEfAHXzADx9gRhCBZYO3GxKmZl8Ff1/gnHGJb89U827HRMLk3l75UKq9Lv8g 7f6Cm/jO9CrDXp1QtANHBNVQ4tF8reNYyIvm3++9HSv9PBxhcm5TyD2bGZgRzYxi0xn3 WBW4FpnJ8oxRGRgmA+hMu9MkBqn43br8FSKVJEraZBy+qszBU3rbKl8ePsXS7Rj89//V uFOsVZGnwPP3+whEDuSYVwxWEnjdfeGyD7X5FF8eKbXvw8oMBw9lvenxHzPH5fJRXC2H CejQ== X-Gm-Message-State: ALQs6tBktXVnFfVWij+PCekmKlDfRknxBO4N912OESdHff8U3/mBGo07 hMrZspN7UBfc0CNIQyRYO8/iAw== X-Google-Smtp-Source: AIpwx48Xa8XKX+Re6uR+dtZ7e5V7B46GU8twI/5Fsbg6ApL03DGTovUiiDVuVrVfZQOl/0wQ6CyIzw== X-Received: by 10.28.66.90 with SMTP id p87mr15798843wma.58.1524673640298; Wed, 25 Apr 2018 09:27:20 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 78sm16612704wmm.19.2018.04.25.09.27.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 09:27:19 -0700 (PDT) Date: Wed, 25 Apr 2018 18:27:05 +0200 From: Adrien Mazarguil To: Qi Zhang Cc: ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org Message-ID: <20180425162705.GU4957@6wind.com> References: <20180425014929.72014-1-qi.z.zhang@intel.com> <20180425133816.198161-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425133816.198161-1-qi.z.zhang@intel.com> Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 16:27:20 -0000 On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: > After add RSS hash offload check, default rss_hf will fail on > devices that not support all bits, the patch take rss_hf as > a suggest value and only set bits that device supported base on > rte_eth_dev_get_info, also rss_hf will only be updated when new > rss offload is successfully updated on all ports by > "port config all rss [!default]" command. > > Fixes: 586ac442be96 ("ethdev: add supported hash function check") > Fixes: 8c1f4aff92a6 ("app/testpmd: new parameter for port config all RSS command") > Signed-off-by: Qi Zhang Although this approach prevents updating rss_hf if at least one port doesn't support RSS configuration (i.e. it can't be used to update defaults for subsequent flow rules on mlx4), I confirm it does fix the startup issue, therefore: Tested-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND