From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 241C18DAD for ; Fri, 27 Apr 2018 15:49:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 06:49:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="194881373" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.223]) by orsmga004.jf.intel.com with ESMTP; 27 Apr 2018 06:49:41 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: hemant.agrawal@nxp.com, bluca@debian.org, Bruce Richardson Date: Fri, 27 Apr 2018 14:49:27 +0100 Message-Id: <20180427134928.4716-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180427134928.4716-1-bruce.richardson@intel.com> References: <20180418210521.277384-1-bruce.richardson@intel.com> <20180427134928.4716-1-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 13:49:43 -0000 When we check for libbsd we were just checking for the library itself. However, on some distros, e.g. CentOS, libbsd will be found even though it's not usable by DPDK as it's missing the string header. Therefore we should check for both the library and the header file. Fixes: 5364de644a4b ("eal: support strlcpy function") Signed-off-by: Bruce Richarson --- config/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 5815b5602..2179c689c 100644 --- a/config/meson.build +++ b/config/meson.build @@ -43,7 +43,8 @@ if numa_dep.found() and cc.has_header('numaif.h') endif # check for strlcpy -if host_machine.system() == 'linux' and cc.find_library('bsd', required: false).found() +if host_machine.system() == 'linux' and cc.find_library('bsd', + required: false).found() and cc.has_header('bsd/string.h') dpdk_conf.set('RTE_USE_LIBBSD', 1) add_project_link_arguments('-lbsd', language: 'c') dpdk_extra_ldflags += '-lbsd' -- 2.14.3