From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BBE7F728E for ; Fri, 27 Apr 2018 15:51:34 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 06:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="37508770" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga006.jf.intel.com with SMTP; 27 Apr 2018 06:51:31 -0700 Received: by (sSMTP sendmail emulation); Fri, 27 Apr 2018 14:51:30 +0100 Date: Fri, 27 Apr 2018 14:51:30 +0100 From: Bruce Richardson To: dev@dpdk.org Cc: hemant.agrawal@nxp.com, bluca@debian.org Message-ID: <20180427135129.GA89888@bricha3-MOBL.ger.corp.intel.com> References: <20180418210521.277384-1-bruce.richardson@intel.com> <20180427134928.4716-1-bruce.richardson@intel.com> <20180427134928.4716-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180427134928.4716-3-bruce.richardson@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 13:51:35 -0000 On Fri, Apr 27, 2018 at 02:49:27PM +0100, Bruce Richardson wrote: > When we check for libbsd we were just checking for the library itself. > However, on some distros, e.g. CentOS, libbsd will be found even though > it's not usable by DPDK as it's missing the string header. Therefore we > should check for both the library and the header file. > > Fixes: 5364de644a4b ("eal: support strlcpy function") > Sorry, forgot to add: Reported-by: Vladimir Medvedkin > Signed-off-by: Bruce Richarson > --- > config/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 5815b5602..2179c689c 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -43,7 +43,8 @@ if numa_dep.found() and cc.has_header('numaif.h') > endif > > # check for strlcpy > -if host_machine.system() == 'linux' and cc.find_library('bsd', required: false).found() > +if host_machine.system() == 'linux' and cc.find_library('bsd', > + required: false).found() and cc.has_header('bsd/string.h') > dpdk_conf.set('RTE_USE_LIBBSD', 1) > add_project_link_arguments('-lbsd', language: 'c') > dpdk_extra_ldflags += '-lbsd' > -- > 2.14.3 >