From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 977D47CEB for ; Fri, 27 Apr 2018 17:39:19 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 08:39:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="46546443" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga003.jf.intel.com with SMTP; 27 Apr 2018 08:39:15 -0700 Received: by (sSMTP sendmail emulation); Fri, 27 Apr 2018 16:39:15 +0100 Date: Fri, 27 Apr 2018 16:39:14 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180427153914.GH80648@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 8/9] mem: fix statement having no effect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 15:39:20 -0000 On Wed, Apr 25, 2018 at 10:56:46AM +0100, Anatoly Burakov wrote: > Coverity reports these lines as having no effect. Technically, we do > want for those lines to have no effect, however they would've likely > been optimized out. Add volatile qualifiers to ensure the code has > effects. > > Coverity issue: 272608 > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson