From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix ethtool link setting call order
Date: Mon, 30 Apr 2018 09:08:58 +0200 [thread overview]
Message-ID: <20180430070858.3yi3civcrhtyc73k@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180429180308.85361-1-shahafs@mellanox.com>
On Sun, Apr 29, 2018 at 09:03:07PM +0300, Shahaf Shuler wrote:
> According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS
> should be called before ETHTOOL_GSET as the later one deprecated.
>
> Fixes: f47ba80080ab ("net/mlx5: remove kernel version check")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 746b94f734..588d4ba627 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
> time_t start_time = time(NULL);
>
> do {
> - ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
> + ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
> if (ret)
> - ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
> + ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
> if (ret == 0)
> break;
> /* Handle wait to complete situation. */
> --
> 2.12.0
>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-04-30 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 18:03 Shahaf Shuler
2018-04-29 18:03 ` [dpdk-dev] [PATCH 2/2] net/mlx5: add Rx and Tx tuning parameters Shahaf Shuler
2018-04-30 7:07 ` Nélio Laranjeiro
2018-04-30 7:08 ` Nélio Laranjeiro [this message]
2018-05-01 9:58 ` [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix ethtool link setting call order Shahaf Shuler
2018-05-03 5:51 ` Shahaf Shuler
2018-05-01 9:58 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: add Rx and Tx tuning parameters Shahaf Shuler
2018-05-02 6:40 ` Nélio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430070858.3yi3civcrhtyc73k@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).