From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id B6034DED for ; Mon, 30 Apr 2018 09:07:58 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id u18-v6so7003379wrg.3 for ; Mon, 30 Apr 2018 00:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rnXo16bX3N8nNbNrveGuhIvTXOrOnv5B7Kvi4tV4I98=; b=YC1XEpfjVsgp4qDI4+h/gAmZJYwM1/RsKfF7sHA0hNI3varZNf/+WOPVade2hIVqnr 4ts7d/qxA+UYT4uMBTbFHFq8t/MbwZS2ediaV8yTA6ZwPApGx4N97AKMQV2qHi8NKNdZ gkHuj9jHwzvJVAPJK6pZ5AJTUk0dsZ2EIbIZdnzf4IPv4pH0CXUZu3xeVUav1Z5B4KwF IJfHIDgGmmfgPfEumUvlrRfWOr3BA+L5U+/Z3e7ofSQjEnEVrR0K5rEZ4gb0TqckGy5q r1feHYq50F+kkdvqAVSztx9oz5sXQFOW0wpNiH1IENvH4gEoz/lRJkmZARcPVoersjKS FlBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rnXo16bX3N8nNbNrveGuhIvTXOrOnv5B7Kvi4tV4I98=; b=KHQX48GCF9ubQvZoQvvZnfxcTXpEZBij9lydVg8mVbNgk0P1Kz+QL0ppXnMTPOdUSI oLWHjJUei3Re/ocuXXCHeOjRzEgPM99195RgbID6br8P1sIQKtiTPKMDH2GhBA4oN09V E+5LsrtD4JtV52+2K2WvTuzyXGM6VOwSnz/VipOjtAupVb3IeApLVVz4mdKqt9150m3F P3qBosOXNtMLf5ExtlkPjEHxcA9lU3ARaFmyncJTmw14+rsVkRUK+8YfMHLWKLTDQa1z usrZwop8JFF5QmiDCo5oaqSWmZFoYQOLDCh4Vfz2N2i1lVemzmRf74tn1OGfQs3W4Ki0 GQFg== X-Gm-Message-State: ALQs6tC+oKCeL0Bv2kQGJwIUAOA6mr5nVWNVV1K3zOTZmW/Dapk5PrST 6SODhF/hrbHdPcG2ukX6GIJ1 X-Google-Smtp-Source: AB8JxZphlvITahWU9YBkk2EDe3o/VCiFgO3c7RyGFpTFssDHzxKG29Et5o8tegKy2ORilN7jwmgc/w== X-Received: by 2002:adf:8a8e:: with SMTP id y14-v6mr8390768wry.267.1525072078519; Mon, 30 Apr 2018 00:07:58 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l1sm5608940wmh.25.2018.04.30.00.07.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 00:07:57 -0700 (PDT) Date: Mon, 30 Apr 2018 09:08:58 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180430070858.3yi3civcrhtyc73k@laranjeiro-vm.dev.6wind.com> References: <20180429180308.85361-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180429180308.85361-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix ethtool link setting call order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 07:07:58 -0000 On Sun, Apr 29, 2018 at 09:03:07PM +0300, Shahaf Shuler wrote: > According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS > should be called before ETHTOOL_GSET as the later one deprecated. > > Fixes: f47ba80080ab ("net/mlx5: remove kernel version check") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 746b94f734..588d4ba627 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) > time_t start_time = time(NULL); > > do { > - ret = mlx5_link_update_unlocked_gset(dev, &dev_link); > + ret = mlx5_link_update_unlocked_gs(dev, &dev_link); > if (ret) > - ret = mlx5_link_update_unlocked_gs(dev, &dev_link); > + ret = mlx5_link_update_unlocked_gset(dev, &dev_link); > if (ret == 0) > break; > /* Handle wait to complete situation. */ > -- > 2.12.0 > -- Nélio Laranjeiro 6WIND