From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
xuemingl@mellanox.com
Subject: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
Date: Tue, 1 May 2018 14:33:43 +0100 [thread overview]
Message-ID: <20180501133343.125260-1-ferruh.yigit@intel.com> (raw)
Many sample applications fail because of
dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
The sample applications need to be fixed/updated before returning error
on rte_eth_dev_configure()
This patch keeps the error log but removes returning error.
Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
Cc: xuemingl@mellanox.com
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_ethdev/rte_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 59810dde8..5a67e6a7d 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1148,7 +1148,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
port_id,
dev_conf->rx_adv_conf.rss_conf.rss_hf,
dev_info.flow_type_rss_offloads);
- return -EINVAL;
}
/*
--
2.14.3
next reply other threads:[~2018-05-01 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:33 Ferruh Yigit [this message]
2018-05-01 13:50 ` Xueming(Steven) Li
2018-05-01 14:01 ` Thomas Monjalon
2018-05-01 14:08 ` Ferruh Yigit
2018-05-01 14:12 ` Thomas Monjalon
2018-05-01 14:32 ` Ferruh Yigit
2018-05-02 9:58 ` Xueming(Steven) Li
2018-05-02 10:06 ` Thomas Monjalon
2018-05-02 17:09 ` Shahaf Shuler
2018-05-02 17:24 ` Ferruh Yigit
2018-05-01 15:30 ` Thomas Monjalon
2018-05-01 15:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501133343.125260-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).