From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 987EB126B for ; Wed, 2 May 2018 08:49:51 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id j5so22295607wme.5 for ; Tue, 01 May 2018 23:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FoX1mRIeG500qEM0GFyUjjecLail4dC0tnGDEtAA1i8=; b=iyAXYxkNABrtl5Cjf6cgagKSMNB9LXk6w1AIyqS7t9r8by6kUUIhofd1DjwCY0TglU XUVPerOIz/T0TlkhgieAJi76M1+/vMFVpAU2siTKV7l6pmfBZSpYbWtScsFYRH4yApf8 JTlDZH6z0LOxVkCUHlnNk4H7144qmygyQRr9qGPFirTcDvfe+8bNlha7M5Eye2XbWQun wxdmLDMMmGsdg0o2Xiu4BeTrRBSQkucifVVDec8wcCSMc47Sb+Zg6zn43i6aqU+iuAMP gCPnxJF3tUW+S4ZjfJgtbAOjT6bNwB3gKfoV5LDJak85P/NbL+QYR9zmQMDc/zsvk3AE r9cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FoX1mRIeG500qEM0GFyUjjecLail4dC0tnGDEtAA1i8=; b=mAlXoVi0YWz/JaLItmC5dgrPkaFcWGi4hk9oH7/tz7cn+wG2iqZvy0h7WLIR+/trFa Gsrr16jQ3VmHqV+Yjpzince7wrKJjtkNBRic2mdPkURIkx2zp6Sy8+XujQD60jKRJNfq MRRL68c00xwfBkjf2c7LzfKnvApkAqpeHYWF9R9Bdwk90ajIGMrLXqeA3rOV1VQxJNEN vWlB6P5rl3Y6cXIBFzUxBMB6B0/DBEvvAKB6Aal0cRFAdYjPcOPiFEn/i5HvujuYufcw R1GW6fiRXHjahc8QuNXkkWfKeaBrad+tMaal+XOdFjMw+8etL9l7wnhW5cUfFjGxHyUL GizQ== X-Gm-Message-State: ALQs6tCQl7Ryd5qziltX3KghybokwKnFdOor+lIW66HuTE5uH0te4STz 8qZNUAODy7VFKJVQDia5xx8K X-Google-Smtp-Source: AB8JxZrQNf4HHdWyN8jyUpzYkAHougQauZHL8i3PqNNb+vZNWqSvdTuIAlZrH+nUa2lJ/IIOYdLQiA== X-Received: by 10.28.18.71 with SMTP id 68mr10577034wms.74.1525243791394; Tue, 01 May 2018 23:49:51 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a13-v6sm10447217wrc.19.2018.05.01.23.49.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 23:49:50 -0700 (PDT) Date: Wed, 2 May 2018 08:50:56 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180502065056.cfvwd3j52s2paxpg@laranjeiro-vm.dev.6wind.com> References: <20180501111806.112319-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180501111806.112319-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix socket connection return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 06:49:51 -0000 On Tue, May 01, 2018 at 02:18:05PM +0300, Shahaf Shuler wrote: > Upon success, mlx5_socket_connect should return the fd descriptor of the > primary process > > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Yongseok Koh > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.c | 2 +- > drivers/net/mlx5/mlx5_socket.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 8f983061a0..46cb370a29 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -804,7 +804,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > goto error; > /* Receive command fd from primary process */ > err = mlx5_socket_connect(eth_dev); > - if (err) > + if (err < 0) > goto error; > /* Remap UAR for Tx queues. */ > err = mlx5_tx_uar_remap(eth_dev, err); > diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c > index e12c4cb2e1..99297d5c43 100644 > --- a/drivers/net/mlx5/mlx5_socket.c > +++ b/drivers/net/mlx5/mlx5_socket.c > @@ -294,7 +294,7 @@ mlx5_socket_connect(struct rte_eth_dev *dev) > } > ret = *fd; > close(socket_fd); > - return 0; > + return ret; > error: > if (socket_fd != -1) > close(socket_fd); > -- > 2.12.0 > -- Nélio Laranjeiro 6WIND