From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 0D28ADED for ; Wed, 2 May 2018 08:52:36 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id o2-v6so9820949wrj.13 for ; Tue, 01 May 2018 23:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YwVbOOtYxFKDlHsaSaAKVeJBFrmpM1CGuOYE8Z7FTGM=; b=Wrjj9i6tkBG+42WAJMSWmKW30JRpLtwe8rduy/Nl6Er90oNd9IdSEHV38NZBjPlS+A s4nCgNxjH9ULSp1Ls/HOU//fn3ExeOPfsYLvNnOmssNWHkMG3WWRX5mZLII/YlAaaFj3 XucQyCjCSl5qde2PbvgLBubhuINwrXe62OlrXhdo93HYxtucLg7Z6wawbeclCBV/0eCm aN1q4/yrrKywZqq3lk98piXHNIQhrYYVJ2fgwMCimzLVPUaAf6tvx+18Adwz+NMXMpU1 kuhVB53TgJze2ogjCkhBDdDH8AiK/M6SinwaVPg0xr0OGbMUpbFqiX8hWgb9YiQEIvgi CEOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YwVbOOtYxFKDlHsaSaAKVeJBFrmpM1CGuOYE8Z7FTGM=; b=LFgeED1i9FxzknVCmRegFDPup1oQaGJWhjyQqTRvD7eN99pQ+FpufJrOq/Pips+aoU Ay5qVafoQBUtFhVCPQBfZcD6SqOr7r/qv5JDwywxt3UghAsvpmmOUktbb8VvLdu3m2aR T0G7y/ywUUp+cO0f5ZobdJ9C4U1biop1UUztuzho1vN/+rOYf5c3mH9FPaftoArj3MmL yB1vxb1Jbr2npYE8cS7zwxAlJjv8rKx7BGEXvVidX78kkXB9K2ush12wYL1hy6i0szYH /vXA0DEv715Ei86QC2P+IiIBt2+4A02qL2c7W1cJIHPMjtHBJcs8z+6vZQ5XkSlDZELh gJmQ== X-Gm-Message-State: ALQs6tCgi1bMOsoVwP5Lc7d1b03ytZg6c1XSMjAdVPEg70Dxym3A4rvt LfdvAh1R7KlAWM+FvMGjHIQhi9Rokg== X-Google-Smtp-Source: AB8JxZpxSNIm/6JDC4iahHT3Q1+19izdWg2SZvfB+51mehLeYwTAKSPMDFeudPVk4ndupsHYz0/yFA== X-Received: by 2002:adf:e58c:: with SMTP id l12-v6mr13614580wrm.38.1525243955841; Tue, 01 May 2018 23:52:35 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d9sm21667129wmh.38.2018.05.01.23.52.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 23:52:35 -0700 (PDT) Date: Wed, 2 May 2018 08:53:40 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180502065340.cxwx4ahdm67nu4av@laranjeiro-vm.dev.6wind.com> References: <20180502061320.6675-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180502061320.6675-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix device reference in secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 06:52:36 -0000 On Tue, May 01, 2018 at 11:13:20PM -0700, Yongseok Koh wrote: > rte_eth_devices[] is not shared between primary and secondary process, but > a static array to each process. The backward pointer of device (priv->dev) > must be reset when a secondary process attaches to a device. > > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 8f983061a..f606e3dd4 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -799,6 +799,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > } > eth_dev->device = &pci_dev->device; > eth_dev->dev_ops = &mlx5_dev_sec_ops; > + /* > + * rte_eth_devices[] is not shared but static to each > + * process. The backward pointer should be reset. > + */ > + priv = eth_dev->data->dev_private; > + priv->dev = eth_dev; > err = mlx5_uar_init_secondary(eth_dev); > if (err) > goto error; > -- > 2.11.0 > -- Nélio Laranjeiro 6WIND