From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode
Date: Wed, 2 May 2018 17:28:35 +0200 [thread overview]
Message-ID: <20180502152554.23257-1-adrien.mazarguil@6wind.com> (raw)
Since the commit referenced below, compiling mlx4 along with its glue
library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation
failure due to undefined symbols.
They are caused by Verbs calls made directly from the PMD instead of going
through the glue library.
Fixes: ffc7411cabfe ("net/mlx4: fix inner RSS support for broken kernels")
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx4/mlx4.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index c1cc95786..47451b651 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -469,14 +469,14 @@ mlx4_hw_rss_sup(struct ibv_context *ctx, struct ibv_pd *pd,
" quirk");
hw_rss_sup &= ~IBV_RX_HASH_INNER;
} else {
- claim_zero(ibv_destroy_qp(qp));
+ claim_zero(mlx4_glue->destroy_qp(qp));
}
if (ind)
- claim_zero(ibv_destroy_rwq_ind_table(ind));
+ claim_zero(mlx4_glue->destroy_rwq_ind_table(ind));
if (wq)
- claim_zero(ibv_destroy_wq(wq));
+ claim_zero(mlx4_glue->destroy_wq(wq));
if (cq)
- claim_zero(ibv_destroy_cq(cq));
+ claim_zero(mlx4_glue->destroy_cq(cq));
return hw_rss_sup;
}
--
2.11.0
next reply other threads:[~2018-05-02 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 15:28 Adrien Mazarguil [this message]
2018-05-02 17:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502152554.23257-1-adrien.mazarguil@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).