From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0089.outbound.protection.outlook.com [104.47.42.89])
 by dpdk.org (Postfix) with ESMTP id A51512BAA
 for <dev@dpdk.org>; Thu,  3 May 2018 11:03:07 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=Vr9KeILJIeIqIqAb10gDfXIyWEEue8lfZ8Z0Q3lIyrA=;
 b=cn+vGO8JY3cMppdlotuUAPllZM1zHKGbTZcnjORih8UrWDeBJadr6iLrSqtC9b93k4aeDQ+glh6s+87VhGUY7kO2IyNY0WB2+7OBh0Rz0KXg1gF/ZVZZjh+Vaq5w4AZ+Rvm4W+06fjv5ipm8m9zDXzpFUsSqqKT2D9jxmp/sxxY=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; 
Received: from jerin (115.113.156.3) by
 SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.23; Thu, 3
 May 2018 09:03:00 +0000
Date: Thu, 3 May 2018 14:32:43 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Vangati, Narender" <narender.vangati@intel.com>,
 "Rao, Nikhil" <nikhil.rao@intel.com>, "Eads, Gage" <gage.eads@intel.com>
Message-ID: <20180503090242.GA10158@jerin>
References: <1524573807-168522-1-git-send-email-abhinandan.gujjar@intel.com>
 <1524573807-168522-2-git-send-email-abhinandan.gujjar@intel.com>
 <20180429160835.GA11546@jerin>
 <5612CB344B05EE4F95FC5B729939F78070701D35@PGSMSX102.gar.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5612CB344B05EE4F95FC5B729939F78070701D35@PGSMSX102.gar.corp.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Originating-IP: [115.113.156.3]
X-ClientProxiedBy: PN1PR01CA0081.INDPRD01.PROD.OUTLOOK.COM
 (2603:1096:c00:1::21) To SN2PR07MB2527.namprd07.prod.outlook.com
 (2603:10b6:804:6::27)
X-MS-PublicTrafficType: Email
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);
 SRVR:SN2PR07MB2527; 
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527;
 3:anCEwHz3wRwzkTiydBamhr4/x8Eont5mZ9iN5j+RuIzw61hMCY4Luct4zD8UPBhQp6H6wLCpDNKbUUQtrilHFF9asX3UeGAMnUxtGYzKoXNUyyjgnF+O/T2c8HHiKtykdCXajld9wyBncJIMmKgkoCnZlfpsyCYKrJWZSkPuGPmf2yB4kdQnrCRcXpawdI2AmLQGTV6JHanuHnC2o21c/M83MHigG+Bvzud+ka+fuSb3s8DkklL5VVqhCb/E3du5;
 25:xudpYUZd6X+uDmLMzBES/4n0WOqo9qkaw+RUA9DONH4W1Exzfhx9RrPHVC6OdSnJOjqcbjAXh768/3WtbnNlnyvUWpQIWdAvmOfzEW8Qy9og+tm0OJW0balFp1SqFQpjmfOwUe/0/36P59k3Y6kS7X4lYoilTPWgZLXMmGf3z4oP+RITn/0bV0uB+OjoOF9JKo6AdHMwz5O0HipjxnxZDtR1pc2hl1BtMklMxVQ/oovSusOK+eARloF3fajg78WjCfQS7tg2GOZSHToyzAWXxn1JRsRZVCSFDkx7BHJP4/AMX/z3dmr++bOfev+vWq75uVWnX8bGb9MsHC8/VSmL7Q==;
 31:/ZeutRsm8gg6rKp+ELOPg/hUa9fL+zxOdaKLNqTVOh1EPZwG43Pf8+vBzUu5TJB5u9qDECNsvbXCBucKByQIJWYatAW9fjsH1XWJdYAIfrmv1ZUTRkNyjOJ78fQYK6pBfcJi1BURViwQ2gUM+XtuPXly0DsO1I70pOwCt/m6xzWSsDlIZTYDxxJi5V+cVKV3EwnvnojFhtByLCEFJJw5igEb8wGXv6Ctu9GM2H1k/RM=
X-MS-TrafficTypeDiagnostic: SN2PR07MB2527:
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527;
 20:rFEowa05ietbB0PHX6nbRa3DYnD6mGwcA2N9+HVqnZzxwnIgjZiZzQHb/aXiBytFqVcPZCKeFZwTOHRcEUwd7nQ/jkMdlLNrN+xLd7Gjj6y5bE3vLhrCRJskBgcwttnVPU9S1ylsZeeeMdR9Cbkn+oAN+B863BxW9jtecRR+gwYOTjsnoNzPI2MeSeIB5wIdE8W48zyvjq3DRrqZo5jRa9LAltCcA2UZKEshD/BKFk/DWehQmIwaMEr/6Cqmu02dli3IQtne6eeFNLVeC73/+yIVj9Spg/4wi3Ee8nXTg0dGLFLjgpYXfk/GGaNoNgGUWTQ3+qpU/oKyUMmNCVIh/MX3Y9gcqgRxDUb3W5XlGq1og8RjwTwjlBbxjZnPXM+HlJNgpoT+ERV5EoW4Ha/BmQP9lmDxz0JXc5UZfZ3nVNfkZAIlrOMWF3PYGnqCoHstRoSnJc2/YKRqdr0GdvZfn3H2wl1EP/bE42ZP5L2J3DnTaU5sOipSi2CUm5nUV4QF/iOXp2Bd3OHBq+Cch7hO4CD04YX4DpFrRcfg5JD8i1Sx9STuAC00rfGsnmXuyf7CziKoVZAvFUVAaNfDfdiTlU+LN4cf7TNKJaJWKWa8Rlg=
X-Microsoft-Antispam-PRVS: <SN2PR07MB252767AAEE0F6A68DE90B865E3870@SN2PR07MB2527.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011);
 SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2527; 
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527;
 4:C9MTeAjDJPokZ/DdrBmyM90DsvbRfwa22SswQzUZeSTSNjuzfWT8xLBU19xR08cHGJv/J7TSNObIGWOvxJoNAYNy6zPAY8GrTqUMjiX5xcwkm03Cy2kcbzf25tPPj3jMEOJrHhhAnDrmBI9mDIVPcnEgPVb6e7RDeXOjau9exll8HV+PEvh+3bUYz/Y7LCY2ZTFZ5ZpE/858XFUb2BcX7vVwTVAVhRI+igi2xM3/0pENHz6dYgTEasmOn0NkJyw22zB/4I/33GpJUt3pr2TfgDcRbgrGu9aCaoiKIV0stNfriAokJfWOnapwEPLdwoXlqGza6o5KOc4KaXMj7dJRscLIcbdlLjWtUNiYZHOaStU=
X-Forefront-PRVS: 066153096A
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(39380400002)(51914003)(13464003)(199004)(189003)(6246003)(93886005)(6496006)(9686003)(50466002)(2906002)(76176011)(53936002)(5660300001)(52116002)(66066001)(97736004)(33896004)(55236004)(55016002)(33656002)(53546011)(81156014)(6916009)(81166006)(229853002)(478600001)(305945005)(8936002)(68736007)(6666003)(47776003)(386003)(186003)(23726003)(956004)(33716001)(6116002)(8676002)(7736002)(72206003)(105586002)(25786009)(26005)(42882007)(316002)(11346002)(106356001)(58126008)(3846002)(54906003)(1076002)(44832011)(16586007)(486006)(8656006)(446003)(476003)(16526019)(4326008)(18370500001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:3; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2527;
 23:QR5skLIqXE40cTzNltoIC27MGEb+kH84We2kukmWp?=
 =?us-ascii?Q?kurNdLBGdMA4I4kzpXWTIxGuVPWlYXigGqpFSJ6e6jxGcBYNCKHnr4YK8g/O?=
 =?us-ascii?Q?BjWbIHonYEH6Wby+q+LvvrvLVJAuzBSjfaGFhxqNHBqPWnTrqx1IRh7Rds1s?=
 =?us-ascii?Q?O4yfd5rOenH35OeiA9Qy71bVFjNCNWDiObcbpvpRgZJkpVDFwAYRy/pC+YP4?=
 =?us-ascii?Q?MjBTo1ocNU8WEqr7FWGDfwmGO1ZCM2BAyn1PYfVO1vXyLpEnmRL1ob1DJL7X?=
 =?us-ascii?Q?QHBhOTUi2AFrfpxZ9j5ZLt1nmxAUB5arI1rrcO3PFQ1W+0fbJRh1mqDAvIkP?=
 =?us-ascii?Q?rKI45CM4SABewh9vGE4fN1+kU8DiM/6GeTtOttsE6kr3sGagL+cYMX3ba/93?=
 =?us-ascii?Q?vco0ltyye2KENsVqvUaXZVTPCxQ/kUhbyVvoVp+MeZPjRJarZcpoRogn5KH9?=
 =?us-ascii?Q?gDizk0BikdKYrrqKpfZw9s25CqOHA5NndOwde2AsdnGe0BHUllxRv1vJZwGs?=
 =?us-ascii?Q?XXeb6ql6+vpL0Q0FHShC8U0HbPujvlUie0Fo92vm7ECq9LBKXh+m68krtBsU?=
 =?us-ascii?Q?DflE856fwl8I/DT31c10aFaT6PivdYS/Oa9eJjR/xTdkHJRubGCxmh/BS3jD?=
 =?us-ascii?Q?JxcSeZ6SANXr1HujK1xHuQGtnGNANf4iDvKVgfxv/Yf4n2EccltAVqefzw/l?=
 =?us-ascii?Q?hXUq4EcN0EMiZZCFSabGjICQK4ivuMTl0M176TgU89xvuSMgmZBYskMbuqeM?=
 =?us-ascii?Q?SG23SivnHvf9z1ndzBb2VtQdIVN2/fvdzBZSkiN5n20xpvQ51PXSMq6i9KRQ?=
 =?us-ascii?Q?r55qC4Z+VRtUnVeZlu8p6uyhbjAygZeEQ+8lUwQdPdiG3eSnmXzqqfOf44kQ?=
 =?us-ascii?Q?/LpagpOkSLpqJvOrXzHvkd2iTVYsGFYKaMf4aJu13WDgFBNFpdnnrRndXIHU?=
 =?us-ascii?Q?0d4ahElk6Bq3uDHGUQPZWXHaOnUxioZRG+hXEUYn0hMvo24bjrz8OTjxJGCp?=
 =?us-ascii?Q?CKrDwrzcJddYxcxBZxmzfl/Gang2I9dGS1R0URrWrMS4TU/hCRDayLwthwft?=
 =?us-ascii?Q?MAKEspMnRuME3ezt8kr5srxtErgC7ZPJrGgRkcg/QDr/JchB34+yWYyFQoAV?=
 =?us-ascii?Q?DzAAhrPGd8GlSgEO/cYyJaxe24C09V8d/CtRNcWiX7sZgeqAH/jIZC9IrGy0?=
 =?us-ascii?Q?SBvjHaLCrTW/3ylpsHDL/rgBVBV4tk9cXYD2lw51zl6IaUpJnRUv+0ZoYEKg?=
 =?us-ascii?Q?6SmtX2OT1zbG4rDGcIlqkDofkI7ebRsc1y14dPRdUP9B2UZBdgCbU36mxpEi?=
 =?us-ascii?Q?4BZJai57M7dkkSepT6nMG7uxPW0Hoc//Kwn0Q7RHKhoyubHekk46QT35IynX?=
 =?us-ascii?Q?7tv8V/aD4B40/3UC0vuzC00xuh3asZ3a8BHmkND8RFZ8xL6g3A1UbqElRwy3?=
 =?us-ascii?Q?O/mRMEf77n9w93Yx4Q9ieW6bLApwbdWEpdoeJ0gGv4aKs9A/OLS?=
X-Microsoft-Antispam-Message-Info: SfmUAuRMyBgsRX/q5PWIRiL5yeZngXLIaXLSxPX9St3rRWKHXSVcGVXMnWDjcbCyY8B9dL472fDMlB6dM482VBnJKGelYt4wCO0CU3uSCKP1y4Gxo11oQgaUhW2447kmpd2w0Z0mmoebCCdwtc62FD61KM4NaGedb3eGTg0oKE8CQIHa5LDCr2BQe40G5J5X
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527;
 6:DXowP0hSYeaXHRHiKla8DusPiPxYKpOpXcIUI4yjJiJO9xFfq5W3ducSIMKhqFBrmL4jc9YZaYkRnjF2qJoJV7YPJh/sl8cmNgqhQ8217zJAtngQfnPSjO1CTGTWDCM9jB2SeX8mFSizpAorp89bRuz/5XSXBpOL6lcRb+rf2mmdgOEteDirfUiS7S/RMmPlunOx4SawxwN4bW7Yx6eHbKhIyAXkjB/u+stW8SXqWC+6INuZXHXNf6DGwutiauHeLvPfTkyjy3fmI/cAPLztuSBwYMbKAbzIoiBvMfWK/X2k2FQdj5dqpHIbfLb8IxayLTcF/Cf9xg2n0yPn3c2fUbmmxEvxDUI41g//P9JdrdO1lJ9Pula9smOV5jrLixZ9R3eOy8YU2sAXazQ1ysJugGosAERdEvUcOUwCIfql8UrxRfCBeD+Tii/pWl0r4dTAEyNU3d490M35gVMw8ccVYA==;
 5:dY4TdBvgo1C+8zGgZIijJK6JJTZQPIgbcAs6pKyoAuH8CuVbphrOXWC3xGqZLWkuFGD1SHLlxpEw2ZDGuh5I8JPt+kB7AFHsrgxDQ2n8wNcdlqKULH798rv4fqJaAuOHnLlzJP/Zr3PYf1dBOmD0SMeanFUupvRdS7byyPwn+QU=;
 24:JacjhajI5YHKV05EKmD21Dc10DoPjG2vKoOMWiIgIOoY41JPv9p5tHrNF45FS0LCiMP80W32wm7xXmmXu3TQqjK06miXg6qZMV6piUwjsAQ=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527;
 7:agEgECy8aaBWj3IFUEPBnrYEWBSyTynmKmux30QvPFetKD0cGR73YQqQgzKgdAjRIIP8AQz2DskPqrpGCwmwj0YKTIKFNorzBwsR7t8o7G5iTfg0TCEGkalpm8sY4kPzJAcCRQQExjELHli66UXplAt20ypdL06vrd+Qis5wUjQFo8oIcixC6rBQiJf1b1gUqYzQxEgy23vi5qOZ+/He3IKkuk38a9ibSO3a8Ew7bztcDAIq2xpeQqH+Ix/7cM1O
X-MS-Office365-Filtering-Correlation-Id: c13e12b9-0a56-44ee-1752-08d5b0d4ae13
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2018 09:03:00.7210 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c13e12b9-0a56-44ee-1752-08d5b0d4ae13
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527
Subject: Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2018 09:03:08 -0000

-----Original Message-----
> Date: Thu, 3 May 2018 06:03:01 +0000
> From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
>  "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "dev@dpdk.org"
>  <dev@dpdk.org>, "Vangati, Narender" <narender.vangati@intel.com>, "Rao,
>  Nikhil" <nikhil.rao@intel.com>, "Eads, Gage" <gage.eads@intel.com>
> Subject: RE: [v2,1/6] eventdev: introduce event crypto adapter
> 
> 
> 
> > -----Original Message-----
> > From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Sent: Sunday, April 29, 2018 9:39 PM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: hemant.agrawal@nxp.com; akhil.goyal@nxp.com; dev@dpdk.org; Vangati,
> > Narender <narender.vangati@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>;
> > Eads, Gage <gage.eads@intel.com>
> > Subject: Re: [v2,1/6] eventdev: introduce event crypto adapter
> > 
> > -----Original Message-----
> > > Date: Tue, 24 Apr 2018 18:13:22 +0530
> > > From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
> > > akhil.goyal@nxp.com, dev@dpdk.org
> > > CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com,
> > > nikhil.rao@intel.com, gage.eads@intel.com
> > > Subject: [v2,1/6] eventdev: introduce event crypto adapter
> > > X-Mailer: git-send-email 1.9.1
> > >
> > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > > ---
> > >  lib/librte_eventdev/rte_event_crypto_adapter.h | 532
> > > +++++++++++++++++++++++++
> > >  1 file changed, 532 insertions(+)
> > >  create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h
> > >
> > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h
> > > b/lib/librte_eventdev/rte_event_crypto_adapter.h
> > > new file mode 100644
> > > index 0000000..aa4f32c
> > > --- /dev/null
> > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h
> > > @@ -0,0 +1,532 @@
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > + * Copyright(c) 2017-2018 Intel Corporation  */
> > > +
> > > +#ifndef _RTE_EVENT_CRYPTO_ADAPTER_
> > > +#define _RTE_EVENT_CRYPTO_ADAPTER_
> > 
> > Please reword if it makes sense.
> It is to the adapter through eventdev.
> May be elaborating little more something like, application gets crypto adapter's
> event port by rte_event_crypto_adapter_event_port_get() API.
> Application links it's event queue to this event port and starts enqueuing crypto
> operations as events. Adapter dequeue these events and submit the crypto operations
> to the cryptodev.
> 
> Does this make sense?

Yes

> > > +	RTE_EVENT_CRYPTO_ADAPTER_DEQ_ONLY = 1,
> > 
> > Why to mark it as explicit '1' ?
> Nothing specific. Have 0 & 1?

Let have 0 then so that enum you don't need to specify '0' explicit as
enum starts from 0

Thanks for the comments. Looks like we have sorted out all the issues.