From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 9D048DD2 for ; Thu, 3 May 2018 11:52:30 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id o78so29282373wmg.0 for ; Thu, 03 May 2018 02:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3yzX1L3KN0ENdJDxe6NJZSgOxtqIq5QoqgohL34wI0o=; b=LL0SgW0sr3IEhvRD0X94Y/Db1a3ca6MHkNS495XFDK4M3yRDKikMAaL/X4WdEM0zKV kEBfPVkTWbxsCcQ7DD5fKYwmB75tI8CDCCThtV/z1uLM2LaFxKadd1f4SlQ0Q4h3mxvc 01tuLcYsWGwnmBrlfT/PqUgaqEFYo5/W0rgu+TUXs6fLcbkEYVB8ta5k/51air5xFe64 W7kWJtQsfEMJhuYhWkxHZf4ug3M6qDetVzkBekK5hd2AxD0uGZG4aVDdmLgLBQfbU3/b x+vRON/dAAwaRfHzaSjoz657SV2g4EtU8SQbzC2ge4++VnbgO/+Vace0Tl8Zquo4nmwC R0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3yzX1L3KN0ENdJDxe6NJZSgOxtqIq5QoqgohL34wI0o=; b=oTPLxXDBemmPVxPgoJdsQHb8bpmUFuki+DvG4hdweT+jKbcupvWbSy+Udl602exO6a 3YYEyG5xwC2evxxl2hO6sz9wBIae7yIM511Mz+T3O7gZvO7VDdawpoGeqI6SAoiShf5N Or9EO1e7y7+rjyMGQiddFkWsDVndIVnttoaT+vNqZ64ST/cXMrksM5ZcN2AT1CMw5x2h CaHVcRwpphOkZZFtQa90Y8T2jnFLg2oDGbxougm/VznXI2zytvSnSjNi9en8+pqhHUyJ nWreykdW69X8OyG9jShyF2sdvXKHcoDhnqpOqekGbLRDTJlX0u5T8H9VS3ogf+X8wY2a v85A== X-Gm-Message-State: ALQs6tA3knP3UmCNV9S4CQVGxHoaTPjkbgugBo53+yf/OrAeyk7gK8di +MKGBdsny5/nrYWDh/IBilJn X-Google-Smtp-Source: AB8JxZokQlLfRTtYT1hSEZ/diZ7aNM0Jjl221VB3kqvj3q9JyYWs7Xa2ekCXBdiDYYpjuh1M4mYcRQ== X-Received: by 10.28.85.201 with SMTP id j192mr16515836wmb.160.1525341150299; Thu, 03 May 2018 02:52:30 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b11-v6sm11093913wrf.50.2018.05.03.02.52.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 02:52:29 -0700 (PDT) Date: Thu, 3 May 2018 11:53:37 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180503095337.cn2ne4ui3szycq3c@laranjeiro-vm.dev.6wind.com> References: <20180501111806.112319-1-shahafs@mellanox.com> <58bf3a469720a2b1cad4c84cb8ca971b756a2215.1525334236.git.shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <58bf3a469720a2b1cad4c84cb8ca971b756a2215.1525334236.git.shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix probe return value polarity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 09:52:30 -0000 On Thu, May 03, 2018 at 10:59:37AM +0300, Shahaf Shuler wrote: > mlx5 prefixed function returns a negative errno value. > the error handler on mlx5_pci_probe is doing the same. > > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler > --- > > On v2: > - fixed more polarity issues on different mlx5_* functions. > - aligned verb calls return values. > > --- > drivers/net/mlx5/mlx5.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 46cb370a29..7afdae863f 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -751,8 +751,9 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > DRV_LOG(WARNING, > "tunnel offloading disabled due to old OFED/rdma-core version"); > #endif > - if (mlx5_glue->query_device_ex(attr_ctx, NULL, &device_attr)) { > - err = errno; > + err = mlx5_glue->query_device_ex(attr_ctx, NULL, &device_attr); > + if (err) { > + DRV_LOG(ERR, "ibv_query_device_ex() failed"); Should be DEBUG() and not DRV_LOG(). > goto error; > } > DRV_LOG(INFO, "%u port(s) detected", > @@ -800,16 +801,22 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > eth_dev->device = &pci_dev->device; > eth_dev->dev_ops = &mlx5_dev_sec_ops; > err = mlx5_uar_init_secondary(eth_dev); > - if (err) > + if (err) { > + err = rte_errno; > goto error; > + } > /* Receive command fd from primary process */ > err = mlx5_socket_connect(eth_dev); > - if (err < 0) > + if (err < 0) { > + err = rte_errno; > goto error; > + } > /* Remap UAR for Tx queues. */ > err = mlx5_tx_uar_remap(eth_dev, err); > - if (err) > + if (err) { > + err = rte_errno; > goto error; > + } > /* > * Ethdev pointer is still required as input since > * the primary device is not accessible from the > @@ -873,11 +880,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > if (err) { > DRV_LOG(ERR, "failed to process device arguments: %s", > strerror(err)); > + err = rte_errno; > goto port_error; > } > - if (mlx5_glue->query_device_ex(ctx, NULL, &device_attr_ex)) { > + err = mlx5_glue->query_device_ex(ctx, NULL, &device_attr_ex); > + if (err) { > DRV_LOG(ERR, "ibv_query_device_ex() failed"); > - err = errno; > goto port_error; > } > config.hw_csum = !!(device_attr_ex.device_cap_flags_ex & > @@ -952,8 +960,10 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > rte_eth_copy_pci_info(eth_dev, pci_dev); > eth_dev->device->driver = &mlx5_driver.driver; > err = mlx5_uar_init_primary(eth_dev); > - if (err) > + if (err) { > + err = rte_errno; > goto port_error; > + } > /* Configure the first MAC address by default. */ > if (mlx5_get_mac(eth_dev, &mac.addr_bytes)) { > DRV_LOG(ERR, > @@ -983,8 +993,10 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > #endif > /* Get actual MTU if possible. */ > err = mlx5_get_mtu(eth_dev, &priv->mtu); > - if (err) > + if (err) { > + err = rte_errno; > goto port_error; > + } > DRV_LOG(DEBUG, "port %u MTU is %u", eth_dev->data->port_id, > priv->mtu); > /* > @@ -1031,6 +1043,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > if (err) { > DRV_LOG(ERR, "port %u drop queue allocation failed: %s", > eth_dev->data->port_id, strerror(rte_errno)); > + err = rte_errno; > goto port_error; > } > /* Supported Verbs flow priority number detection. */ > -- > 2.12.0 Unless the small comment above, Acked-by: Nelio Laranjeiro Thanks, -- Nélio Laranjeiro 6WIND