From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 7E70A29D6 for ; Thu, 3 May 2018 13:59:57 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id q3-v6so17305663wrj.6 for ; Thu, 03 May 2018 04:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=/B/KVYp2pSwUtAYbiBosanpc78MaqD1gUVWXi8DIIt8=; b=hwh7PecEB62pXXeNQ+9AWJ1soNmr81sdifaQltkMPzLAacEiwTYgGse5SA4/UFkfcV 7mE7DIWhEso7qnHbjXW4DOwF4HW0w2m/IerB5nJfgeFDOIvD5z8G+2ZRMt0UZlrNsmV2 q1HOJjUKMxFR1nH1BrgsXnO0J1DxxvaETaKhfuMe9yCwlaN1JCcstbjrFpiP9hgzyA98 QGiHCTos1AnKfl6H6ahAIS2NeIsGsSLfuPU26rU9gzrfDbX2aHn7j15slWk4YLbIG+Z5 6e9m79oCa6i7Zx8BkohhqVn3D6/YAP4ofeO1+FaJKqEw2U6tGaa0WuvXe0/19910JYpr WgGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=/B/KVYp2pSwUtAYbiBosanpc78MaqD1gUVWXi8DIIt8=; b=RzGlO3ELtgHX8wa2BsYsDydlEZordN0SEq2LSXFajiflXIDCH73Tk8QCwDdHbFXwwu RHJsddWaT1Cm7v39ADzq5SqhGiOEZfwWtLZQVEG09ry+8jP65RKhMJUxa7AJeCLpuej8 g99unFrq9h3ma7theQaacy1khxxEyfO2fHG0ky2wotkoWaPadyKjZRWGIUC4OElJp9ow 0YCvwzpHJvcSA57F0Ntk8rDByVlDY0WpCZWuYpEl3jC/vTLG3uLaYlCAojoso4LAtqeR 3Lq27GdVB5LDTFLj0dG6B9EWxsaLndxixmRdOvG+aCrGVmOjYTKRMg2kzqg6CRbkodpt XipA== X-Gm-Message-State: ALQs6tDs6zhJK41xQmGACWzJCZQvoQj6MRcQU5IbVbBBBzOZAIMc5Jq5 Pd87jKjEs/+p/BPGEjQU7HCZRA== X-Google-Smtp-Source: AB8JxZrnh1+eg86t+0I6M8lvEPqrTHjytuVGbHPXmuxVpagz9IkG8dYuh4QqzYYOu4P2gcRficMviw== X-Received: by 2002:adf:88b6:: with SMTP id f51-v6mr16907559wrf.55.1525348797173; Thu, 03 May 2018 04:59:57 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z18-v6sm18037104wrc.36.2018.05.03.04.59.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 04:59:56 -0700 (PDT) Date: Thu, 3 May 2018 13:59:42 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Shahaf Shuler , dev@dpdk.org, stable@dpdk.org Message-ID: <20180503115818.19744-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix empty list of RSS queues for flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 11:59:57 -0000 Since the commit referenced below, specifying a RSS action without any queues (e.g. "actions rss queues end / end") does not override the default set automatically generated by testpmd. In short, one cannot instantiate a RSS action with 0 target queues anymore in order to determine how PMDs react (hint: this is currently undocumented so they may reject it, however ideally they should interpret it as a default setting like for other fields where empty values stand for "defaults".) Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 5754e7858..f4ea0a5cf 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2896,7 +2896,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, i = ctx->objdata >> 16; if (!strcmp_partial("end", str, len)) { ctx->objdata &= 0xffff; - return len; + goto end; } if (i >= ACTION_RSS_QUEUE_NUM) return -1; @@ -2916,6 +2916,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token, if (ctx->next_num == RTE_DIM(ctx->next)) return -1; ctx->next[ctx->next_num++] = next; +end: if (!ctx->object) return len; action_rss_data = ctx->object; -- 2.11.0