From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 028C5DED for ; Thu, 3 May 2018 14:48:40 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id f2-v6so5663560wrm.3 for ; Thu, 03 May 2018 05:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QLqystVQdf35KoL0xZb/JrAWyozpy6a0aRG10x021vg=; b=bOevtCBTf0jRhkKCrA5nuTfQWcatYUK2yj+0yzTAU+PKy9NIddPYkkKz0tAMytyFsK bM0UQ9hAEpQjJoCeRHDcdxV9GbRl7OPl2tBmvFchtRts2A/uV9fJQ2tadppA/g22RBKe bFLu5CveYwk/4CCTXONY8LAMnXOmdYkBEI55ZWjXlj7qIreB7/7X8zIvH0Vcf3//l85M Eq40BJy49+CPfh/oDmEtGgigceJgZFJ5xAfS7UQhjTLMU0c28ce5wdrL2aqSGVHkHmZc 5VaVhR9p0GNDDy3rr/zsTCU0wppUVsR7ckAYJW2xFj0/xbLFrzM8arBOj3Lu4xujsEFH WvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QLqystVQdf35KoL0xZb/JrAWyozpy6a0aRG10x021vg=; b=KSaYa868QMfOYjNQVmcOMPkW0mog4uBlJcAD164BB/PBCteQGDzpHrFDniO9iHAYKH TZwqY0wB7Eh0b2RD+bLWHUAyEloHWD/TMehREZFecCShRVWCvD7vE3I1aKzrJ9devtx3 01VWSHkxYXTBa2UKYeMN3jPCp/t0ALo1/iSclhyXGYOGcgzkCiw0C0VzPp5/zYwnhCGf K2m9IrHjpRimEUk/tv4amgY1bYOjkh/SWJtFmnXT+ulqzyU3f6hoaQwdorWPIVIuRgyZ AfpU4aDCYGu53xn45fYH2G4LXWyVSJufGP7f1Iz5JgG12CAvlnHmE78gMGm3VOA8JWvo SqnA== X-Gm-Message-State: ALQs6tChBbJAc729OWsMfTen/qBrIYHLoHYz5P9Ghw1kpZPgPhw4BNaI pE1ExdjEroZ4zU9Idq3uEonVgA== X-Google-Smtp-Source: AB8JxZqqMU8Xcs+SUuYe7jCmSRHI4xwCv3Q7vtWpdLUEpuJhu1Nu6XCWSNSncXiW5nwpLOCzmxS/QA== X-Received: by 2002:adf:9d8c:: with SMTP id p12-v6mr17521075wre.14.1525351720701; Thu, 03 May 2018 05:48:40 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a129sm12127172wme.34.2018.05.03.05.48.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 05:48:39 -0700 (PDT) Date: Thu, 3 May 2018 14:48:25 +0200 From: Adrien Mazarguil To: "Peng, Yuan" Cc: "Zhao1, Wei" , "dev@dpdk.org" , "Xu, Qian Q" , "Liu, Yu Y" , "Lu, Wenzhuo" , "Wu, Jingjing" Message-ID: <20180503124825.GJ4957@6wind.com> References: <20180419100848.6178-1-adrien.mazarguil@6wind.com> <20180425151852.7676-1-adrien.mazarguil@6wind.com> <20180425151852.7676-8-adrien.mazarguil@6wind.com> <67D543A150B29E4CAAE53918F64EDAEA374F519B@SHSMSX103.ccr.corp.intel.com> <67D543A150B29E4CAAE53918F64EDAEA374F5274@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67D543A150B29E4CAAE53918F64EDAEA374F5274@SHSMSX103.ccr.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 12:48:41 -0000 Hi Peng Yuan, Apologies for the delay, I'll answer below to the entire thread. On Sat, Apr 28, 2018 at 07:45:31AM +0000, Peng, Yuan wrote: > Hiļ¼ŒAdrien Mazarguil > > There is a bug of queue region with 18.05-rc1 > The test steps are as below: > ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 > ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 -- -i --rxq=16 --txq=16 > testpmd> port config all rss all > Configuration of RSS hash at ethernet port 0 failed with error (22): Invalid argument. I assume this issue is related rte_eth_dev_configure() which was recently fixed [1], right? [1] "ethdev: fix applications failure on configure" http://dpdk.org/ml/archives/dev/2018-May/099858.html > There is a bug present with 18.05-rci when I test the feature "Move RSS to rte_flow" in i40e NIC > The test steps are as below: > ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 > ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1fffe -n 4 -- -i --nb-cores=8 --rxq=8 --txq=8 --port-topology=chained > testpmd> set fwd rxonly > Set rxonly packet forwarding mode > testpmd> set verbose 1 > Change verbose level from 0 to 1 > testpmd> start > testpmd> flow create 0 ingress pattern end actions rss queues 0 4 7 end / end > Caught error type 16 (specific action): cause: 0x7fff84e33658, RSS hash key too large > > The rss rule can be set successfully when I test it yesterday with older dpdk version without this patch. Regarding this issue, the testpmd flow command now requests hash key length from the PMD by default [2] if left unspecified by user. This value is taken from the "hash_key_size" field returned by rte_eth_dev_infos_get(). While most PMDs return 40 here, i40e returns: (I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t) /* that is, (12 + 1) * 4 => 52 */ Is this correct and really supported by i40e? Otherwise I'd suggest to fix the PMD as it may also confuse applications other than testpmd. Note that you should be able to revert to the old behavior with the PMD-specific default key by specifying a "key_len 0" parameter to the RSS action. [2] http://dpdk.org/browse/dpdk/tree/app/test-pmd/cmdline_flow.c?id=v18.05-rc2#n2780 > There is another problem with ixgbe nic: > ./usertools/dpdk-devbind.py -b igb_uio 07:00.0 07:00.1 > ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1fffe -n 4 -- -i --nb-cores=8 --rxq=8 --txq=8 --disable-rss --port-topology=chained > testpmd> flow create 0 ingress pattern end actions rss queues 5 6 7 end / end > Caught error type 2 (flow rule (handle)): Failed to create flow. > The rule setting command can be executed successfully with older dpdk version. > > Could you help to check if there is a relationship between the bugs and this patch? Perhaps a similar issue since testpmd now provides default values for unspecified fields of the RSS action, that is, a default hash key with a PMD-returned default length and the global "rss_hf" value for types (here 0 due to --disable-rss). Try appending the following arguments to the RSS action: key_len 0 types ip udp end If it works, it probably means the issue was always present, it just never showed up due to the inability to validate RSS action parameters previously. You should make sure ixgbe supports them. -- Adrien Mazarguil 6WIND