From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter
Date: Fri, 4 May 2018 17:17:47 +0200 [thread overview]
Message-ID: <20180504151421.24765-2-adrien.mazarguil@6wind.com> (raw)
In-Reply-To: <20180504151421.24765-1-adrien.mazarguil@6wind.com>
Since the commit below, mlx4_conv_rss_types() does not need to support
special value -1 anymore. Other functions rely on priv->hw_rss_sup
directly.
Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields")
Cc: stable@dpdk.org
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx4/mlx4_flow.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 3f754b480..cb3b9a952 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -78,9 +78,6 @@ struct mlx4_drop {
/**
* Convert DPDK RSS hash types to their Verbs equivalent.
*
- * This function returns the supported (default) set when @p types has
- * special value (uint64_t)-1.
- *
* @param priv
* Pointer to private structure.
* @param types
@@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t types)
uint64_t conv = 0;
unsigned int i;
- if (types == (uint64_t)-1)
- return priv->hw_rss_sup;
for (i = 0; i != RTE_DIM(in); ++i)
if (types & in[i]) {
seen |= types & in[i];
--
2.11.0
next prev parent reply other threads:[~2018-05-04 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:17 [dpdk-dev] [PATCH 1/2] net/mlx4: fix UDP flow rule limitation enforcement Adrien Mazarguil
2018-05-04 15:17 ` Adrien Mazarguil [this message]
2018-05-10 19:03 ` [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter Ferruh Yigit
2018-05-08 8:04 ` [dpdk-dev] [PATCH 1/2] net/mlx4: fix UDP flow rule limitation enforcement Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504151421.24765-2-adrien.mazarguil@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).