From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 47BC03256 for ; Fri, 4 May 2018 17:18:02 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id q3-v6so21460246wrj.6 for ; Fri, 04 May 2018 08:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9nTz0uD4wd1VunUEJnJdhcFlTjFQQ+sJW8NXpoIioIw=; b=Bgmdbxs/JcpOZVlgniXliTKMxhd+Gc9l5IRAz0KsUq5GyEQjFf2AGCtSeXr65Z0gJ8 lv0TWLtG/r7xK/7gXI4pq96qZ38a/pil9vKPPzI4tlU8YyFXWtQ8/kUty3CpGtQ9WuZs he+iTekKrH9JzAdi9x2f7q06VUTW9QMhqwjQul3OVvO+N9yebo68YOT9MBYRa1S5Rycy lr2aGxkekkmCVEfhL35TycLkpaubLs+e3XgtYrQzYa/o2zgoOmGtJPicXWJfspjNqgyh 48okHQP2eb2kk9hwHi1nDHyaBEIJHPRagCq9iJL+W9PFqjqiSnMH/24HDYhsoCm2CZla q5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9nTz0uD4wd1VunUEJnJdhcFlTjFQQ+sJW8NXpoIioIw=; b=jyxpMIgp6/fzeGd9iBI8NcqoWRDzRwTFByvELTDoX5zZma6o8s3vhZf3+3uNGK51I9 ZB6LQaXT+O4E2TIH20wCuNWd4cu5XmER07jKbs8tldxY+Qax3sNvFBwWtDIzVpy1f0Ay vO/1xb/mxOVYJTR3BIiZPL6j2QkkMd19pgXx7tqEq/IiN8l8z8b4cp4YDlV1wjvng7Ra 7jdeztE60eH/JnJ0HkMqJdfId907bbVlsXYHmhxC4pJZ+lxHmo8LN+fw1A4928l5it8U qWqfFe5PILHPNWkyb1KSA4M3a7z1zXZRJg7bI8hibJ0z7CTvNa5BrvDjWO1CEU62nrm3 X22A== X-Gm-Message-State: ALQs6tDCHcrlYHrUiXnwFwvZjba87QpfPGR2StOWfh0ys8xX42HomtC7 vVhCrf5tRAul1g6ny3IkDiO+kw== X-Google-Smtp-Source: AB8JxZr7jnbV4MbLOHHa08xC6vdE3CQFeQZp/DwxdxV/uySnELiBiXYsNNufoyvUwPtyt42dgQI9kQ== X-Received: by 2002:adf:b722:: with SMTP id l34-v6mr23782793wre.85.1525447081991; Fri, 04 May 2018 08:18:01 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x16-v6sm898687wmc.2.2018.05.04.08.18.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 08:18:01 -0700 (PDT) Date: Fri, 4 May 2018 17:17:47 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Message-ID: <20180504151421.24765-2-adrien.mazarguil@6wind.com> References: <20180504151421.24765-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180504151421.24765-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 15:18:02 -0000 Since the commit below, mlx4_conv_rss_types() does not need to support special value -1 anymore. Other functions rely on priv->hw_rss_sup directly. Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 3f754b480..cb3b9a952 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -78,9 +78,6 @@ struct mlx4_drop { /** * Convert DPDK RSS hash types to their Verbs equivalent. * - * This function returns the supported (default) set when @p types has - * special value (uint64_t)-1. - * * @param priv * Pointer to private structure. * @param types @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t types) uint64_t conv = 0; unsigned int i; - if (types == (uint64_t)-1) - return priv->hw_rss_sup; for (i = 0; i != RTE_DIM(in); ++i) if (types & in[i]) { seen |= types & in[i]; -- 2.11.0