Re: [dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, May 08, 2018 at 04:18:41PM +0800, Andy Green wrote:
> 
> 
> On 05/08/2018 03:36 PM, Andrew Rybchenko wrote:
> > Many thanks. I guess the most of below notes are applicable to many other
> > patches in the series.
> > 
> > Signed-off-by: ,  Fixes: and Cc: stable@dpdk.org tags are missing. See [1].
> 
> Everybody's project has different prejudices.
> 
> > Changeset summary should start from "net/sfc: "
> > I.e. something like:
> > net/sfc: fix strncpy size and NUL
> 
> Yeah if that's what you like.
> 
> > (it looks like "another" is useless in the original subject)
> 
> It captures my feeling at having to wade through making 18 fixes before I
> could compile the project on current Fedora.
> 
> > In general all patches should pass ./devtools/check-git-log.sh and
> > ./devtools/checkpatches.sh
> > (which requires path to Linux kernel checkpatches.pl).
> 
> Can you help me understand why adding CRLFs at 80 cols on the gcc errors I
> pasted helps anything at all?  The patches actually fix problems in the
> code.
> 

I don't think there is any need to wrap the error messages since they are
pasted verbatim.

> If you don't care about Coverity, let me know and I will register this
> project there and send you fixes when I have time.
> 

FYI: The DPDK project is already registered in coverity and scanned regularly.
We do try and fix as many issues it flags as possible, but not everything
gets dealt with as quickly as we'd like, sadly.

https://scan.coverity.com/projects/dpdk-data-plane-development-kit

Regards,
/Bruce