From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D2C207CCC for ; Tue, 8 May 2018 22:10:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 13:10:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,379,1520924400"; d="scan'208";a="47734759" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.223]) by FMSMGA003.fm.intel.com with ESMTP; 08 May 2018 13:10:19 -0700 From: Bruce Richardson To: Shreyansh Jain Cc: dev@dpdk.org, Bruce Richardson Date: Tue, 8 May 2018 21:10:17 +0100 Message-Id: <20180508201017.44057-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/i40e: fix missing defines for non-AVX builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 20:10:22 -0000 For non-AVX builds, the cflags used for compiling the i40e driver files are not passed to the call to build the AVX-specific code path. This can cause build failures. ../drivers/net/i40e/i40e_ethdev.h:888:42: error: ‘I40E_PFQF_HKEY_MAX_INDEX’ undeclared here (not in a function) Fixes: e940646b20fa ("drivers/net: build Intel NIC PMDs with meson") Reported-by: Shreyansh Jain Signed-off-by: Bruce Richardson Tested-by: Shreyansh Jain ---- Testing previously done on draft version of this patch. Ref: http://dpdk.org/ml/archives/dev/2018-May/100301.html --- drivers/net/i40e/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build index f2129df07..d783f3626 100644 --- a/drivers/net/i40e/meson.build +++ b/drivers/net/i40e/meson.build @@ -25,6 +25,7 @@ sources = files( ) deps += ['hash'] +includes += include_directories('base') if arch_subdir == 'x86' dpdk_conf.set('RTE_LIBRTE_I40E_INC_VECTOR', 1) @@ -40,11 +41,10 @@ if arch_subdir == 'x86' 'i40e_rxtx_vec_avx2.c', dependencies: [static_rte_ethdev, static_rte_kvargs, static_rte_hash], - c_args: '-mavx2') + include_directories: includes, + c_args: [cflags, '-mavx2']) objs += i40e_avx2_lib.extract_objects('i40e_rxtx_vec_avx2.c') endif endif -includes += include_directories('base') - install_headers('rte_pmd_i40e.h') -- 2.14.3