* [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx
@ 2018-05-09 0:14 Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection Xueming Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xueming Li @ 2018-05-09 0:14 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: Xueming Li, dev
Add document for hw header parsing and SWP.
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
doc/guides/nics/mlx5.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 853c48f81..bc08515cf 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -69,8 +69,8 @@ Features
- Multiple process.
- KVM and VMware ESX SR-IOV modes are supported.
- RSS hash result is supported.
-- Hardware TSO.
-- Hardware checksum TX offload for VXLAN and GRE.
+- Hardware TSO for generic IP or UDP tunnel, including VXLAN and GRE.
+- Hardware checksum Tx offload for generic IP or UDP tunnel, including VXLAN and GRE.
- RX interrupts.
- Statistics query including Basic, Extended and per queue.
- Rx HW timestamp.
--
2.13.3
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection
2018-05-09 0:14 [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Xueming Li
@ 2018-05-09 0:14 ` Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 3/3] net/mlx5: fix SW parser enabling Xueming Li
2018-05-09 8:14 ` [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Shahaf Shuler
2 siblings, 0 replies; 4+ messages in thread
From: Xueming Li @ 2018-05-09 0:14 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: Xueming Li, dev
Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading")
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 5190b9fcd..3885b0bf0 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -729,7 +729,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
mps = MLX5_MPW_DISABLED;
}
#ifdef HAVE_IBV_MLX5_MOD_SWP
- if (attrs_out.comp_mask | MLX5DV_CONTEXT_MASK_SWP)
+ if (attrs_out.comp_mask & MLX5DV_CONTEXT_MASK_SWP)
swp = attrs_out.sw_parsing_caps.sw_parsing_offloads;
DRV_LOG(DEBUG, "SWP support: %u", swp);
#endif
--
2.13.3
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v1 3/3] net/mlx5: fix SW parser enabling
2018-05-09 0:14 [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection Xueming Li
@ 2018-05-09 0:14 ` Xueming Li
2018-05-09 8:14 ` [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Shahaf Shuler
2 siblings, 0 replies; 4+ messages in thread
From: Xueming Li @ 2018-05-09 0:14 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: Xueming Li, dev
Fixes: 5f8ba81c4228 ("net/mlx5: support generic tunnel offloading")
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
drivers/net/mlx5/mlx5_ethdev.c | 4 +++-
drivers/net/mlx5/mlx5_txq.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 3fad199a6..271d94a5b 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -1129,7 +1129,9 @@ mlx5_select_tx_function(struct rte_eth_dev *dev)
uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads;
int tso = !!(tx_offloads & (DEV_TX_OFFLOAD_TCP_TSO |
DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
- DEV_TX_OFFLOAD_GRE_TNL_TSO));
+ DEV_TX_OFFLOAD_GRE_TNL_TSO |
+ DEV_TX_OFFLOAD_IP_TNL_TSO |
+ DEV_TX_OFFLOAD_UDP_TNL_TSO));
int swp = !!(tx_offloads & (DEV_TX_OFFLOAD_IP_TNL_TSO |
DEV_TX_OFFLOAD_UDP_TNL_TSO |
DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM));
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 44358744d..19c883d7d 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -773,7 +773,8 @@ txq_set_params(struct mlx5_txq_ctrl *txq_ctrl)
}
txq_ctrl->txq.tunnel_en = config->tunnel_en;
txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO |
- DEV_TX_OFFLOAD_UDP_TNL_TSO) &
+ DEV_TX_OFFLOAD_UDP_TNL_TSO |
+ DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) &
txq_ctrl->txq.offloads) && config->swp;
}
--
2.13.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx
2018-05-09 0:14 [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 3/3] net/mlx5: fix SW parser enabling Xueming Li
@ 2018-05-09 8:14 ` Shahaf Shuler
2 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2018-05-09 8:14 UTC (permalink / raw)
To: Xueming(Steven) Li, Yongseok Koh; +Cc: Xueming(Steven) Li, dev
Wednesday, May 9, 2018 3:15 AM, Xueming Li:
> Cc: Xueming(Steven) Li <xuemingl@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx
>
> Add document for hw header parsing and SWP.
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Series applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-09 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 0:14 [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 2/3] net/mlx5: fix SW parsing feature detection Xueming Li
2018-05-09 0:14 ` [dpdk-dev] [PATCH v1 3/3] net/mlx5: fix SW parser enabling Xueming Li
2018-05-09 8:14 ` [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).