DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: 'Pavan Nikhilesh' <pbhagavatula@caviumnetworks.com>,
	"santosh.shukla@caviumnetworks.com"
	<santosh.shukla@caviumnetworks.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers
Date: Wed, 9 May 2018 08:21:17 +0530	[thread overview]
Message-ID: <20180509025115.GA20900@jerin> (raw)
In-Reply-To: <VI1PR05MB4269D928F9C6ED0CEF5B95F8D79A0@VI1PR05MB4269.eurprd05.prod.outlook.com>

-----Original Message-----
> Date: Tue, 8 May 2018 07:49:01 +0000
> From: Ali Alnubani <alialnu@mellanox.com>
> To: 'Pavan Nikhilesh' <pbhagavatula@caviumnetworks.com>,
>  "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
>  "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
>  "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, Shahaf Shuler
>  <shahafs@mellanox.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
>  compilers
> 
> Tested-by: Ali Alnubani <alialnu@mellanox.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> 
> > -----Original Message-----
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Sent: Monday, May 7, 2018 3:31 PM
> > To: jerin.jacob@caviumnetworks.com;
> > santosh.shukla@caviumnetworks.com; ferruh.yigit@intel.com; Shahaf
> > Shuler <shahafs@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> > compilers
> > 
> > Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error"
> > for aarch64.
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  mk/toolchain/gcc/rte.toolchain-compat.mk | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > index 9f17131f9..0f2b0ff0a 100644
> > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > @@ -12,6 +12,7 @@
> > 
> >  GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
> > GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
> > +GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(CC) -E -x c - |
> > +tail -n 1)
> >  GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
> > 
> >  # if GCC is older than 4.x
> > @@ -73,4 +74,11 @@ else
> >  		CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
> >  	endif
> > 
> > +	# Disable octeontx event PMD for gcc < 4.8.6
> > +	ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 &&
> > echo 1), 1)
> > +		CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> > +		CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> > +		CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> > +	endif
> > +
> >  endif
> > --
> > 2.17.0
> 

  reply	other threads:[~2018-05-09  2:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 12:30 Pavan Nikhilesh
2018-05-08  7:49 ` Ali Alnubani
2018-05-09  2:51   ` Jerin Jacob [this message]
2018-05-09  9:06   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509025115.GA20900@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=alialnu@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).