From: Michal Krawczyk <mk@semihalf.com>
To: Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>
Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik <rk@semihalf.com>
Subject: [dpdk-dev] [PATCH v1 02/24] net/ena: remove support of legacy LLQ
Date: Wed, 9 May 2018 14:45:46 +0200 [thread overview]
Message-ID: <20180509124552.22854-2-mk@semihalf.com> (raw)
In-Reply-To: <20180509124552.22854-1-mk@semihalf.com>
From: Rafal Kozik <rk@semihalf.com>
The legacy LLQ should no longer be supported by the drivers, as this API
is deprecated. Because of that, it was removed from the driver.
Signed-off-by: Rafal Kozik <rk@semihalf.com>
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
---
drivers/net/ena/ena_ethdev.c | 29 +++++------------------------
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 4c90e65bd..81e36b1ef 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1342,16 +1342,11 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
adapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr;
adapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr;
- /* Present ENA_MEM_BAR indicates available LLQ mode.
- * Use corresponding policy
- */
- if (adapter->dev_mem_base)
- ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV;
- else if (adapter->regs)
- ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;
- else
+ if (!adapter->regs) {
PMD_INIT_LOG(CRIT, "Failed to access registers BAR(%d)",
ENA_REGS_BAR);
+ return -ENXIO;
+ }
ena_dev->reg_bar = adapter->regs;
ena_dev->dmadev = adapter->pdev;
@@ -1368,22 +1363,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
return -1;
}
- if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) {
- if (get_feat_ctx.max_queues.max_llq_num == 0) {
- PMD_INIT_LOG(ERR,
- "Trying to use LLQ but llq_num is 0.\n"
- "Fall back into regular queues.");
- ena_dev->tx_mem_queue_type =
- ENA_ADMIN_PLACEMENT_POLICY_HOST;
- adapter->num_queues =
- get_feat_ctx.max_queues.max_sq_num;
- } else {
- adapter->num_queues =
- get_feat_ctx.max_queues.max_llq_num;
- }
- } else {
- adapter->num_queues = get_feat_ctx.max_queues.max_sq_num;
- }
+ ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;
+ adapter->num_queues = get_feat_ctx.max_queues.max_sq_num;
queue_size = ena_calc_queue_size(ena_dev, &get_feat_ctx);
if ((queue_size <= 0) || (adapter->num_queues <= 0))
--
2.14.1
next prev parent reply other threads:[~2018-05-09 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 12:45 [dpdk-dev] [PATCH v1 01/24] net/ena: update ena_com to the newer version Michal Krawczyk
2018-05-09 12:45 ` Michal Krawczyk [this message]
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 03/24] net/ena: add interrupt handler for admin queue Michal Krawczyk
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 04/24] net/ena: add stop and uninit routines Michal Krawczyk
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 05/24] net/ena: add LSC intr support and AENQ handling Michal Krawczyk
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 06/24] net/ena: handle ENA notification Michal Krawczyk
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 07/24] net/ena: restart only initialized queues instead of all Michal Krawczyk
2018-05-09 12:45 ` [dpdk-dev] [PATCH v1 08/24] net/ena: add reset routine Michal Krawczyk
2018-05-31 15:12 ` [dpdk-dev] [PATCH v1 01/24] net/ena: update ena_com to the newer version Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509124552.22854-2-mk@semihalf.com \
--to=mk@semihalf.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=mw@semihalf.com \
--cc=rk@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).