From: Remy Horton <remy.horton@intel.com>
To: dev@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH] net/i40e: fix missing Port Representor data-path callbacks
Date: Wed, 9 May 2018 16:00:05 +0100 [thread overview]
Message-ID: <20180509150005.2531-1-remy.horton@intel.com> (raw)
This patch adds Rx and Tx burst functions to the i40e Port
Representors, so that the implementation within this PMD
can be tested using applications such as testpmd which
require data-path functionality.
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
drivers/net/i40e/i40e_vf_representor.c | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
index 96b3787..e205019 100644
--- a/drivers/net/i40e/i40e_vf_representor.c
+++ b/drivers/net/i40e/i40e_vf_representor.c
@@ -337,6 +337,25 @@ struct eth_dev_ops i40e_representor_dev_ops = {
};
+static uint16_t
+i40e_vf_representor_rx_burst(__rte_unused void *rx_queue,
+ __rte_unused struct rte_mbuf **rx_pkts, __rte_unused uint16_t nb_pkts)
+{
+ return 0;
+}
+
+static uint16_t
+i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
+ struct rte_mbuf **tx_pkts,
+ uint16_t nb_pkts)
+{
+ uint16_t idx_pkt;
+
+ for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
+ rte_pktmbuf_free(tx_pkts[idx_pkt]);
+ return nb_pkts;
+}
+
int
i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
{
@@ -365,9 +384,11 @@ i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
/* Set representor device ops */
ethdev->dev_ops = &i40e_representor_dev_ops;
- /* No data-path so no RX/TX functions */
- ethdev->rx_pkt_burst = NULL;
- ethdev->tx_pkt_burst = NULL;
+ /* No data-path, but need stub Rx/Tx functions to avoid crash
+ * when testing with the likes of testpmd.
+ */
+ ethdev->rx_pkt_burst = i40e_vf_representor_rx_burst;
+ ethdev->tx_pkt_burst = i40e_vf_representor_tx_burst;
vf = &pf->vfs[representor->vf_id];
--
2.9.5
next reply other threads:[~2018-05-09 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 15:00 Remy Horton [this message]
2018-05-11 10:48 ` Mohammad Abdul Awal
2018-05-11 12:29 ` Remy Horton
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 0/2] " Remy Horton
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix missing Port Representor data-path Remy Horton
2018-05-11 14:04 ` Mohammad Abdul Awal
2018-05-11 16:08 ` Ferruh Yigit
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: " Remy Horton
2018-05-11 14:04 ` Mohammad Abdul Awal
2018-05-11 16:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509150005.2531-1-remy.horton@intel.com \
--to=remy.horton@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).