DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: maxime.coquelin@redhat.com
Cc: lei.a.yao@intel.com, mtetsuyah@gmail.com, 3chas3@gmail.com,
	dev@dpdk.org, Jan Blunck <jblunck@infradead.org>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()
Date: Thu, 10 May 2018 15:04:14 +0800	[thread overview]
Message-ID: <20180510070414.8517-1-tiwei.bie@intel.com> (raw)

The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
contain necessary offload information. It can't be zeroed.

Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc: Jan Blunck <jblunck@infradead.org>
Cc: stable@dpdk.org

Reported-by: Lei Yao <lei.a.yao@intel.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index ff5424a92..47fd23eb3 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -400,7 +400,6 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 
 	for (i = 0; likely(i < nb_rx); i++) {
 		bufs[i]->port = r->port;
-		bufs[i]->ol_flags = 0;
 		bufs[i]->vlan_tci = 0;
 
 		if (r->internal->vlan_strip)
-- 
2.11.0

             reply	other threads:[~2018-05-10  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  7:04 Tiwei Bie [this message]
2018-05-16 10:55 ` Maxime Coquelin
2018-05-16 14:36   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510070414.8517-1-tiwei.bie@intel.com \
    --to=tiwei.bie@intel.com \
    --cc=3chas3@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jblunck@infradead.org \
    --cc=lei.a.yao@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mtetsuyah@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).