From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, andy@warmcat.com,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
bruce.richardson@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] test: fix wrong function type casing
Date: Thu, 10 May 2018 13:59:20 +0530 [thread overview]
Message-ID: <20180510082920.8779-1-jerin.jacob@caviumnetworks.com> (raw)
make flip_bit() as lcore_function_t.
Found this issue with gcc 8.1
test/test/test_distributor_perf.c: In function ‘time_cache_line_switch’:
test/test/test_distributor_perf.c:59:24: warning: cast between
incompatible function types from ‘void (*)(volatile uint64_t *)’ {aka
‘void (*) (volatile long unsigned int *)’} to ‘int (*)(void *)’
[-Wcast-function-type] rte_eal_remote_launch((lcore_function_t *)flip_bit,
&data[0], slaveid);
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Fixes: c3eabff124e6 ("distributor: add unit tests")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
test/test/test_distributor_perf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c
index 557715e13..edf1998ab 100644
--- a/test/test/test_distributor_perf.c
+++ b/test/test/test_distributor_perf.c
@@ -31,7 +31,7 @@ struct worker_stats worker_stats[RTE_MAX_LCORE];
* worker thread used for testing the time to do a round-trip of a cache
* line between two cores and back again
*/
-static void
+static int
flip_bit(volatile uint64_t *arg)
{
uint64_t old_val = 0;
@@ -41,6 +41,7 @@ flip_bit(volatile uint64_t *arg)
old_val = *arg;
*arg = 0;
}
+ return 0;
}
/*
--
2.17.0
next reply other threads:[~2018-05-10 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 8:29 Jerin Jacob [this message]
2018-05-10 15:58 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510082920.8779-1-jerin.jacob@caviumnetworks.com \
--to=jerin.jacob@caviumnetworks.com \
--cc=andy@warmcat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).