From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0048.outbound.protection.outlook.com [104.47.38.48]) by dpdk.org (Postfix) with ESMTP id 2C0314C9D for ; Thu, 10 May 2018 11:12:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=66I0upluLgLMYT3+MH8IAuwvLsVHSRI4PgYs1Vd3A44=; b=WOUUnEBonB2oSwCOjRCtatbuN7mRbd7rteXyfps5vSsX5K0vRDmpn2VamcgcG/wjkt5OeUsHFv/Bwldt8z3T0HJt571zP1dKCJ07SOYcs4ARWFUaS7DheCZ2X77s6uqhka5PiyWBxVWFja7VcLvMuVUC20CE0nzuYj6p5x0vYek= Received: from jerin (115.113.156.3) by CO2PR07MB2518.namprd07.prod.outlook.com (2603:10b6:102:12::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Thu, 10 May 2018 09:12:06 +0000 Date: Thu, 10 May 2018 14:41:48 +0530 From: Jerin Jacob To: Andy Green Cc: dev@dpdk.org Message-ID: <20180510091147.GA26838@jerin> References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <20180510061731.GB12718@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0055.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::17) To CO2PR07MB2518.namprd07.prod.outlook.com (2603:10b6:102:12::24) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:ss48bv/4oiSHXPFUJJWBFV6u3bhw/M4B/Ao2boZzQ/BwUYeFdEM7qYAbMZE/XAyjeaOuDZ61luAzmPDLFCqgFKknPJfvMKUH2khQrS38JtBmrmFxbE3D9mLvhlpabopHxQH+Akdz4FPsq9/Jcd1Gh8zirGv/UQ/WYCBW2KQ8MuSPSN0SyHbAdMuEfUMHsSb+a7zBisylODo/gCWUgFb0cQ2zbm2yJ/SslMn1KwZVE7+5CHwnUUt1wAKJAkYZ05Hi; 25:6oJIk1aPpNoGe+QilpwP5o2zdLb8E8bf97eXGEcxlh2t4QCjQ2MD/ypNlM7xfmfBnFfyXcsie+VLmRvtcTzz2Hnr60gotst+Sy8usIkie4R0z+Zocgl1J51+03tqW7sU4TO+xbklzN6aF5eNA+UMwgZIo2QNzoG2r2p3OfurMd5rSgme+AU5Sw7m1n7R/9SUPUcY/GzvbrU/82rIq40x2XdWxnCUjHlFepAjc6ojK0WCdhJFBE7e2JUL6KQIiAFHP5Wa8Z8vehCVPfxZigvVlpRZXmulo4ewKUOoxEGgDjccxckEN0Yfk0bNDdwWOYIcALJtVGNTzHryE8TyCsm06A==; 31:tlhH9WKZ8MiMbNjvWO6MvMAgwoJKtdIOUIZwuGUgvbNahJZ/Lt1/HEUqFLNkzewz0U0Q/yYWIBqyuA1iqkliNZ3mIFZ3vQuzSzD4SCUda17/EdKECb/fQdNXWBGY9/GaF0U7gffzo97Icc2k6pWj/anzhB0LzBe0s0fHva8lLDU3CC6ppRz/gHTqzrrEjDSN2pRh3l6WA2CEEdQzyzxENwm47ASK8Llg76LX2qzX0WQ= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:oL7kJok9ZynZug1YEscA8Fc5k7/AflzO5tO63tvAGwLzlkHLwC2+qwrOE95Pvm8Aetc3hrOVC9oRQkshbYS71DaYltnfF4Cle+bWGQ/LvLaH9l7iVm/3M/44HQBjzSpIlfryDLvPQ4mO20OJaKWSG+kt5Fl/00kAzTUo0WDuciT9HecKo/vcYUaMmJJgutjmaLraBKZBKK6vp5Kovl+oyKcFBqJvfrNHjaZY17Lw3v8haPFefFwL+Mi+m/8/QrBG68fEdTfR670KTOO6m0FcqUJIn9cftBDGWwTNPnshr1FZwDLXQnfCuLAGWGXdhMvc1xzxefkHcF698sqjbg2DTAJ7eGLMyj1hb+sJN1Cc33XN6P0Tvw9tNNjGB9TvQlXuyPdPIn8dx6ewlgjQCT9jhTQcTQZuVpSw4qc2nE5z9xfCDh+U0w/avTCr38hQpc5qFU4MNbWPJWfX4GtuubOpJZrvK+YcbkMKjgscrXp+X4WtztbcD8M1t7+NGBCiMcpgDiBo7FlMq9WZ7aNWWsBNTuTFkF2+mNYEOOYn88BPoz7iC3p1KO35kwOX6b2XOpf+o09SUW0PxBa3aKVTUZFDwLDRU2tNPa2oX17uDSPtOMc=; 4:TO43mLalwDGAvjCACiEj+a5cobiB0HsGiZ//LprQKCMgNm+Wgh6FozIoNxeik+X3tuFMaZQUvoRz2KEwulJ8xkCnpQY2dFyJ3HLfmYYb1VAwrP8mBQY+BROjQkzEGZaaqO3wBeb/BI4GVJN578MP0YWtT3AAHOlPN+9m0SAYrd6x3DaeMmZYv6zsqx5VlqWn8n2feSC9OCxtgNup9zYIoVanVpmncKIh0r2spqfGWx6YvPlDst6Um0EIsjtnQ8K5StI/FTLaQTbOjFZxccR0Kw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2518; X-Forefront-PRVS: 066898046A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(13464003)(58126008)(6116002)(8936002)(8676002)(486006)(55016002)(105586002)(33656002)(42882007)(23726003)(81166006)(3846002)(316002)(16586007)(9686003)(6916009)(44832011)(81156014)(6246003)(33716001)(1076002)(229853002)(476003)(52116002)(47776003)(956004)(72206003)(478600001)(53936002)(25786009)(7736002)(6496006)(6346003)(106356001)(33896004)(68736007)(2906002)(6666003)(386003)(26005)(5660300001)(53546011)(305945005)(55236004)(66066001)(16526019)(11346002)(4326008)(186003)(97736004)(76176011)(446003)(50466002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2518; 23:+i6E00pY06lGqmMjXtg2Bz5tZwY0JqFjSEEd4y1Cv?= =?us-ascii?Q?mqj/Jkf11iWWtC+78cVtaJ4iIZAq/vUE/zwDUX5YmHkE5cCGsSZrccueS0ui?= =?us-ascii?Q?EeYpMmAXNid6nPyFlxwdNrCZ2LQJ8bLbxu/GN4SmkfjKjH8xiOC38XqXdYlH?= =?us-ascii?Q?jH7e8YwJgKPmGEqW/dZmj2kVJZ22nD9qmZ2lkuvd6M6/JPXfvcDNE5po5I98?= =?us-ascii?Q?lSDEZKDCBDUm69kq3OwyeJbYlrbIHp2B61G0RKI+Ax/GWfCCJFeFj+fIOctB?= =?us-ascii?Q?5CqmvDkkYqBd1hGvtSD/DNXQmhSpbU+1d5uWeTlFUrVjGSIQcJw5dyVTacgQ?= =?us-ascii?Q?ELDonA+tQR+0jxnIzjhvaTrG5d6O7b6AZ82bO7CP6O7b6IemYRoY0e0516WD?= =?us-ascii?Q?Ut540jn6HUnVEeKL8XGuzATBzLED3WdzLcmpYTAqkfDoW4HNk8LgwKmF3OOj?= =?us-ascii?Q?K6ggJgeBlP6Tc867taIcvTlMbO+b8kr8hPz3CAGKD+Jr6aAHx8ZSff6JQcGK?= =?us-ascii?Q?YTBbRizBt5FFnPIHEYqkhIjef+w3EW7UFrjkGZpBCdedH8oeZp/B/hRpATNa?= =?us-ascii?Q?Ed8WY2vFNSUge3PyN6jhVrWc2kwR8UeV1Do/IQo5acwugq39nduoJXVBYjfA?= =?us-ascii?Q?8trAETpNi39Roqq/QI7ce6ufVyU92+8fHiRq3/WIoPKNWBFc4RSCufxMyQCH?= =?us-ascii?Q?UyZc4RDrKzbs085op3Yo11eQLOTHHtIULrSEyld11xZHfKeXUsNI5s+NLodl?= =?us-ascii?Q?1ZA26blgyZkVFnwajOjuLBioRr8HDZiY8GCHx67djUf8pwh+xz5+/2zuOb7L?= =?us-ascii?Q?NxrEJFmnflfgSeqIzN+0CzZFZfeM/cURaEdnctKUA0TF5hnAqWPWyJT+DwoS?= =?us-ascii?Q?0zsdEL1JsfAghAZEg1Fx9ZjwMoXhvdCT5AdIcHDB6knPFbPLeJm/RUt/SkNn?= =?us-ascii?Q?pyL+xff1F4A3ifRaYIyFL4esdXOzDnMF+ZvCkfX9CZbTZhCcVI7gEanNKMGG?= =?us-ascii?Q?2KxtIaJBPeSZtGsk19gmeoe1KU4e5wo3XN1nuWF5TXDHZ9VMSS5IjyZd0Xw/?= =?us-ascii?Q?G8GTDiFYaoMdJWNlZpcrfIIDVl3WdlTunrzukHmnlca9MUN9x6Z7ET+TNVFy?= =?us-ascii?Q?6794W8prz6jzwucWuwgJA9EOcoMDKcImNYrnQnM9JICTA6Nd6tYELr+22v3k?= =?us-ascii?Q?WF2jQF/HwdvCyw32a5yaSalUl1pjIbapxBs2L0SX1IlrVenzL02neCU/ErE+?= =?us-ascii?Q?/FXkuJirQqwpORdAPR29eR2O1EI3vHQU8QndVF0mLHjwarIBq1eaCVHLLzSz?= =?us-ascii?Q?lcs97F7cHNKvESVGqZURUtpgbHBQc7ay1cMHMepdsKCG5MRgKp0OBi9UYmxp?= =?us-ascii?Q?MpGijkn7PaSL0Em1M0BSHhVojrRzTA+G7gtjkmFKEbAbJei?= X-Microsoft-Antispam-Message-Info: SNUOixMa/f1gHlTynlyaeUNYhIuV2J4i0CeXQixBvosm+YltjfvBb+ivVPVcDzXp5xW2Xm60jtz6ZdJZb3QkZ1xKIw6ndMLnicOI12Yx9hGQkVuilexuKTOBnecuSdeqKujX1Q6N3Elimhm/fc+QVnIeSKgqlnG9aAlm7Qub1p5MHSkrzMBXTpQoQ9HPa2I1 X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:34nJMX62/ZmM0sgjHEuMZ44JOwVE+VWVC5BUMnX/bwz5Pcrthl3eChQqM6onywisllkmF7KollkvYNseqC1XETCvY4m2s+H1ZZESAWyddANE1a7EJfxQ5zaTm33+8NXTA2TkEp+0Fl8BtSy7meg1t0qX/mtgJjr3sSxdSHmWYTsZ/bPEMrlgu326R9x8SDHZ7xN+ftWX19QEwngK0o9VR8VpdDKb3dn51mXN0cKvj7FF5S29Wlq62sC1XXnujdYvH/81pWcds+mgzmef3dpE8OxIFF9i4YtC8/ha8Ak8lsinl/4DyGu5Wl6UGzDIs66NSAWjgn4GWLyJNZNX9KD6E/Okt56julne5ataQMgD3wb6nX1nimNyPfGaxzi8gHLJYyCMkfNbYs+2pEtSYAAfUITXLMXHh9R57Yiga1JxRFRBitISbd/85q94h3sQfyMxsGlOXqnkTVPKqXahF+Telw==; 5:GAVzx8efbMq0jmgpoSynH+NlWTzhnKjmWq/eD7JOVi8pv8NSek697MIWn6b06+XDOOucoasP+GOSyAWcPNt5deVBDkPQZrfHhvhi2gEw4zZgUCQ5Uo7EWXMx8s8xHyVHWO5WoJqJQW3r49x3mdgK0CdSXFxhu1kHRpdzhnrC3jM=; 24:SQROdsvufwpDpJ4BhUB++p/aIDuPvMTn4Fu/ofkQMxUGiuzwOIP5IQfS6T+1Nx6XdYMPPVZbjKcnvDVvsaNB4Dl5kWqW3GBQIEJliNV+hDM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 7:ya4NTH9wvrTbkq0ivV9uuEbUMXyGTusoFdCg/7PTEub7HcGxDs6KAjS/YiGX9h0qfO6uUF1/3Kktw7NvE8fqg6cPl14VdVdEUEYNrNHBxiyHjvH93GoVjQDAiaR2sn86NOETNwMhPMV17NGLG2bgpKFf6yc8aFWG59T++1+bbd93hHst1chotg9ddSbioNHmDjK5L34Tyyuw7JT1m2fb9agAy72glzAt0XJISYYYpekhmNTk99EGlEzXJZ8YyDfK X-MS-Office365-Filtering-Correlation-Id: d8880def-5ab7-409f-91a6-08d5b6561aca X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2018 09:12:06.1187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8880def-5ab7-409f-91a6-08d5b6561aca X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 09:12:11 -0000 -----Original Message----- > Date: Thu, 10 May 2018 14:46:42 +0800 > From: Andy Green > To: Jerin Jacob > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.7.0 > > > > On 05/10/2018 02:17 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Thu, 10 May 2018 10:46:18 +0800 > > > From: Andy Green > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > > > User-Agent: StGit/unknown-version > > > > > ./devtools/check-git-log.sh > > Ugh... > > Wrong headline format: > drivers/net/nfp: fix buffer overflow in fw_name > > ... snip something "wrong" about every patch title... > > It's just doing this > > # check headline format (spacing, no punctuation, no code) > bad=$(echo "$headlines" | grep --color=always \ > -e ' ' \ > -e '^ ' \ > -e ' $' \ > -e '\.$' \ > -e '[,;!?&|]' \ > -e ':.*_' \ > -e '^[^:]\+$' \ > -e ':[^ ]' \ > -e ' :' \ > | sed 's,^,\t,') > [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n" > > It probably seems to whoever wrote it that adds "quality", but actually > inflexible rules like this do nothing to help quality of the patch payload > and actively put off contribution. > > So on this first one it's hitting the rule ':.*_', ie, this project believes > there should never be a patch title mentioning anything with an underscore > after a colon. > > Can you help me understand in what way banning mentioning relevant strings > in the patch title is a good idea? It's actively reducing the value of the > patch title, isn't it? I think, the underscore check is to make sure that the subject should not have C symbols. Change to following will work: net/nfp: fix buffer overflow > > -Andy