From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id A4F411BB3D for ; Thu, 10 May 2018 21:17:45 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id p14-v6so1522822pfh.9 for ; Thu, 10 May 2018 12:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6aLIgB9gxXupLI1BPsew53F8AvQkULJOD7bEg9gGzc=; b=UVa1N3GTFWe9ZGzgNWmUVBdBh5L7s6kl6TxLHZjVgfuXgaQhmVAMTlssAhaokUi4aY 1xdsuaRRi8AH5YlwwZNt8bDHTNh9o5bBP0k06InVa5CL4gdWyv3DI2ZqVwM0LtAkZ1S5 y4pjbATc64H5+olqJyofag5u3a8nu2AkpqPzFVIvezq479Kt5o4Z2eOUOjg8p9GDd+ue V4cH9Pi4WXL108NLiF6QRLbw/wkzkiHIPEogKsSzw6tBhMyVs/pzZ/HL/fPtG9ohX0bs AHvzUJpymj7BHxGi/zUHFQHtaGF0uMIKkca3Y3Si4/UhLvm/AbRjsu2DcscLKimMGvBr d1hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6aLIgB9gxXupLI1BPsew53F8AvQkULJOD7bEg9gGzc=; b=cnbng9wjIGo/ta2fUetUa/M2W8wvQ+4mm785cynGM5tdilzh+fTsCo3/tLosKZrY/G U9cixOjcyv2xR2HAovQKaaUweWtf9wuNVx8GrFyNyGhzTm96/O+cpAt5QSJOPO2jaJ/v O+WUtRPLZo7JJtY7Z0tAGZxWRuf/0wJyGwD2xhpirTDsG7s67FJb8mHJNzqsssxaIUG1 AJr0qz5z+wEztuubYLYYPi1aFl3oIK9MHZebAPOh0QHFk9eaPHV1aoiz+xlMwnVrE8r/ cXG8PN+vGhmANB+i2dY64w0ZWUEyKs5vQbWUUAN91Xw7bvqmfiPxzylVH7uledbenjWC HE0Q== X-Gm-Message-State: ALKqPwdTdFnsNvkKzTxT2pA/G95MRht5yRmAz6nbS99DNx1CFBRmV4f3 96u5xPokgON1xiKaiVnVxt7+QNoRQ0I= X-Google-Smtp-Source: AB8JxZpoj2ucIzB+GJjOvTNQJOPJMCIM2XrRavEtRRdUC8/V1lRFiu04GEW0nen6FhOM0AhZycqbTg== X-Received: by 2002:a63:774e:: with SMTP id s75-v6mr2061364pgc.162.1525979864784; Thu, 10 May 2018 12:17:44 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id d3-v6sm2724350pgc.12.2018.05.10.12.17.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 May 2018 12:17:44 -0700 (PDT) Date: Thu, 10 May 2018 12:17:42 -0700 From: Stephen Hemminger To: Andy Green Cc: dev@dpdk.org Message-ID: <20180510121742.137ed26f@xeon-e3> In-Reply-To: <152592058043.119328.8002624265714725703.stgit@localhost.localdomain> References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <152592058043.119328.8002624265714725703.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 40/40] rte_string_fns.h: explicit cast for int return to size_t X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 19:17:45 -0000 On Thu, 10 May 2018 10:49:40 +0800 Andy Green wrote: > Signed-off-by: Andy Green > --- > lib/librte_eal/common/include/rte_string_fns.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h > index fcbb42e00..51413a55e 100644 > --- a/lib/librte_eal/common/include/rte_string_fns.h > +++ b/lib/librte_eal/common/include/rte_string_fns.h > @@ -55,7 +55,7 @@ rte_strsplit(char *string, int stringlen, > static inline size_t > rte_strlcpy(char *dst, const char *src, size_t size) > { > - return snprintf(dst, size, "%s", src); > + return (size_t)(unsigned int)snprintf(dst, size, "%s", src); > } > > /* pull in a strlcpy function */ > I would rather see a proper version of strlcpy extracted from libbsd