From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Nikhil Rao <nikhil.rao@intel.com>,
ferruh.yigit@intel.com, lei.a.yao@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eventdev: make ethernet port identifiers 16 bit
Date: Thu, 10 May 2018 20:46:43 +0530 [thread overview]
Message-ID: <20180510151642.GA25202@jerin> (raw)
In-Reply-To: <1779610.xE5Tc50yFF@xps>
-----Original Message-----
> Date: Thu, 10 May 2018 16:54:45 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Nikhil Rao <nikhil.rao@intel.com>, ferruh.yigit@intel.com,
> lei.a.yao@intel.com, dev@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] eventdev: make ethernet port
> identifiers 16 bit
>
> 10/05/2018 16:30, Jerin Jacob:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 10/05/2018 06:31, Jerin Jacob:
> > > > > Date: Thu, 10 May 2018 02:22:40 +0530
> > > > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > > >
> > > > > Ethernet port ID data size has been extended to 16 bits size 17.11
> > > > > Update the Rx event adapter interface and implementation accordingly.
> > > > >
> > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> > > > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > > > Cc: stable@dpdk.org
> > > >
> > > > Since it is an ABI change, please bump the library version.
> > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is
> > > > required.
> > >
> > > The ABI changes must be described in the release notes too.
> > >
> > > There is no deprecation notice for this ABI change.
> > > According the the policy, you must send a notice in 18.05,
> > > and do the change in 18.08.
> >
> > Even for the APIs with experimental tag?
>
> No, experimental can change without prior notice.
>
> > If so, I don't see any
> > difference between experimental vs non experimental API?
>
> Rx adapter is not experimental as far as I know.
It is experimental. Please see the links.
http://dpdk.org/browse/dpdk/tree/MAINTAINERS#n351
http://dpdk.org/browse/dpdk/tree/lib/librte_eventdev/rte_event_eth_rx_adapter.h#n276
If you agree then take dropped patch.
>
>
next prev parent reply other threads:[~2018-05-10 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 19:17 [dpdk-dev] [PATCH] " Nikhil Rao
2018-05-09 20:52 ` [dpdk-dev] [PATCH v2] " Nikhil Rao
2018-05-10 4:31 ` Jerin Jacob
2018-05-10 13:48 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-05-10 14:30 ` Jerin Jacob
2018-05-10 14:54 ` Thomas Monjalon
2018-05-10 15:16 ` Jerin Jacob [this message]
2018-05-10 15:45 ` Thomas Monjalon
2018-05-10 16:11 ` Thomas Monjalon
2018-05-10 5:35 ` [dpdk-dev] " Jerin Jacob
2018-05-10 5:49 ` Jerin Jacob
2018-05-10 3:16 ` [dpdk-dev] [PATCH] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510151642.GA25202@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lei.a.yao@intel.com \
--cc=nikhil.rao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).