From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7BF4A1BB94 for ; Thu, 10 May 2018 18:23:22 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id w194-v6so4794946wmf.2 for ; Thu, 10 May 2018 09:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=316VAI+qhDQab8rIkyGbes+chaFLM+q9YKDZO6+azg4=; b=FYACl13xlpjvzNldxHW6sODbnT2lXgXnljKOZoM1yTasdiTKN4xNlzpxLNng2OWQkd nYBl3YN6H617OySsMGlx6EOmhtZkC7/DkT8yeozdvqjx3A9SZITpIIWqoUZj+ou/rjpl EX5H9F4b7XH0ynhseKOApouhJmy7Tj2Mmhag4PO67wTeEILNMAnXHWSxKPX+96lGgOwj Q7aeThJam3cZBWo1pCDSliWysQ3YtTa1Z5NPiKeQKPuh5sg4BLBLK0Q8iWQq05JlElDJ 8WsPK1Clc3j450WxAWu0oxJKVfiifbFa3KZjw30/FHfrej1T8THq8/JCTxJ13GGB9tTI ZBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=316VAI+qhDQab8rIkyGbes+chaFLM+q9YKDZO6+azg4=; b=CARncyCFOaVvEDwzkxTnGC1YvqqVRhtZ2vV4W9TrM4UvK4pAQAgNrpFAeTAz2jcLba sCMvOzcjsu9sTrosKkx+gUvzn7vgezOAQLbGe1ipGeGFQ83RaRL35zgonuFbvXg8ZIqF +a7L8ym7m0t1MiwmIk3O3D4QspRHTzvUf5JrJDGaZ2L+QdU6wF4zmBnfhLpf9uKK9Vpd NyxTkiJ/2p9frHnFvvm76rqw2QRlk6vFqgFbwrnrvZYDpY0ndfhUKV4nenqVdGlKTwe4 gtp36GEfrbQb18SgqfU1m/zTi6rW/ge/70XyI/RPHlyhoYMBnXZlwC2vUWW4EnWX5/Ww GhKQ== X-Gm-Message-State: ALKqPwc92qz3vkj4zoVXzubLzK7f+fXd+ZCqXdd2wseaJwoAEywYzK7j O2FsBeA0k/suI8sQxZtiiCNzh1dK X-Google-Smtp-Source: AB8JxZrH0U3XpzgCgI38w+F8w5YL2qRpv4sXf3THPVB8z1KOTa9VwBlvkCn5c39+FHckXErFBtSIYg== X-Received: by 2002:a1c:5f82:: with SMTP id t124-v6mr1681683wmb.124.1525969401899; Thu, 10 May 2018 09:23:21 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g78-v6sm1815277wmc.27.2018.05.10.09.23.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 May 2018 09:23:20 -0700 (PDT) Date: Thu, 10 May 2018 18:23:06 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20180510162306.5wklgeeqftprm53d@bidouze.vm.6wind.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180509224313.27289-1-thomas@monjalon.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 00/11] ethdev: fix race conditions in iterator and notifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 16:23:22 -0000 Hello Thomas, On Thu, May 10, 2018 at 12:43:02AM +0200, Thomas Monjalon wrote: > We have discovered some race conditions when using the port iterator > and/or the notifications recently added. > The work was done mostly with failsafe but some bugs could > be reproduced with other drivers. > These 11 patches are fixing all these issues. > The PMDs are modified to call a new function after probing each port. > > v2 (address Gaetan comments): > * rename rte_eth_dev_allocated_lock_free to rte_eth_dev_allocated_nolock > * do not use uint32_t for avoiding port id iteration overflow > (should be fixed separately with BUILD_BUG_ON) > > > Quick survey: > Do you think it is too late to merge these fixes in 18.05? > Or do you agree that these bugs really deserve to be fixed > by this series in 18.05-rc3? > I'm usually of the opinion that it is almost never too late, so I vote for including this series in rc3. -- Gaëtan Rivet 6WIND