From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 786211BBA3 for ; Fri, 11 May 2018 01:58:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 21AEA2251F; Thu, 10 May 2018 19:58:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 10 May 2018 19:58:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=HkeYd5wM9V8Gk6 yVUnNqbjKemR4w/0X95ym83yphB4E=; b=DEhakkPiD50oLFd4NEUOvklIq64cbA GKmAYzz7jYJQlt/EgibyM0/fFBUNlgOxQMWx9Es6BYRqfmEhQwpd9D5cpW/tNsiN vIivfzd2jsJ8igh6q3zCeHBxA8fxDcfp+dqnO6MQaYxiJhncvgxKSYGxpyEnK2WV gWgt3U6qnsZB8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=HkeYd5wM9V8Gk6yVUnNqbjKemR4w/0X95ym83yphB4E=; b=EhEkqMip K8kP3lloIhA3MheYDs+Q9dsBS3HjCjmGkYg74RBdtpcRoS2WTEFjRE7BSjW/saTo idsN/VrkXKdlpQv9rrkczzrzJid2/VSXlS9laoGQbPUZy0qMZXoYzmK+ekKpB3ga 6+GiWtIFJOhud2hPDl2vDCmSjIcfpWm6tAbPsdhWyuEuH18V42E8zS+8D686wWuo dsy29YO4E0M0YRQtEQaWR8RLiMmBi6vyJr5wb9YYc/E8cDL2h0ShMaAQ7B3uspQA bBmhCcacbYTEmFeSGN95f9ZM2dV0uuhVNXaJ1g/brDagg4UlMkwSKoVtHUN/0VPm +THlujwD+TtjOQ== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 32046E4393; Thu, 10 May 2018 19:58:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: matan@mellanox.com, arybchenko@solarflare.com, stephen@networkplumber.org, ferruh.yigit@intel.com Date: Fri, 11 May 2018 01:58:28 +0200 Message-Id: <20180510235836.1099-4-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180510235836.1099-1-thomas@monjalon.net> References: <20180509094337.26112-1-thomas@monjalon.net> <20180510235836.1099-1-thomas@monjalon.net> Subject: [dpdk-dev] [PATCH v3 03/11] ethdev: add doxygen comments for each state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:58:47 -0000 The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes: d52268a8b24b ("ethdev: expose device states") Fixes: cb894d99eceb ("ethdev: add deferred intermediate device state") Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Fixes: 7106edc12380 ("ethdev: add devop to check removal status") Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Reviewed-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2271337dc 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -1269,12 +1269,16 @@ typedef uint16_t (*rte_tx_callback_fn)(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[], uint16_t nb_pkts, void *user_param); /** - * A set of values to describe the possible states of an eth device. + * Possible states of an ethdev port. */ enum rte_eth_dev_state { + /** Device is unused before being probed. */ RTE_ETH_DEV_UNUSED = 0, + /** Device is attached when allocated in probing. */ RTE_ETH_DEV_ATTACHED, + /** The deferred state is useless and replaced by ownership. */ RTE_ETH_DEV_DEFERRED, + /** Device is in removed state when plug-out is detected. */ RTE_ETH_DEV_REMOVED, }; -- 2.16.2