From: Stephen Hemminger <stephen@networkplumber.org>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: ferruh.yigit@intel.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/tap: add default name to tun
Date: Fri, 11 May 2018 08:24:45 -0700 [thread overview]
Message-ID: <20180511082445.26a38561@xeon-e3> (raw)
In-Reply-To: <1526028119-142177-1-git-send-email-vipin.varghese@intel.com>
On Fri, 11 May 2018 14:11:59 +0530
Vipin Varghese <vipin.varghese@intel.com> wrote:
> The change adds default name to reflect TUN PMD instance. if option
> name is not passed, the default dtun is taken.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 172a7ba..fa59a76 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)
> params = rte_vdev_device_args(dev);
> memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN);
>
> + snprintf(tun_name, sizeof(tun_name), "%s%d",
> + DEFAULT_TUN_NAME, tun_unit++);
Use unsigned to avoid integer wraparound?
next prev parent reply other threads:[~2018-05-11 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 8:41 Vipin Varghese
2018-05-11 15:24 ` Stephen Hemminger [this message]
2018-05-12 6:22 ` Varghese, Vipin
2018-05-12 6:21 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-05-14 16:01 ` Ferruh Yigit
2018-05-14 16:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511082445.26a38561@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=vipin.varghese@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).