From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 53E011BD8D for ; Fri, 11 May 2018 10:32:10 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id o78-v6so1697566wmg.0 for ; Fri, 11 May 2018 01:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TmQIEC+0xDr0AUuBS5beJ1lWM1GbXFYr8go2/SnRNbw=; b=I1+PISzeQOi+RA1RMchAj6FdDYNCYDbmZ//gMJzKw1jmoROUyHO3Ptycx3lB+8/0Ye Fo5KboKHOXtEnCQHQlOH8BEOmTAYCZV3csgzU5nIP5exCDBNg8N4uy55NTu0O73+PhzI XNaB9yvp3yd81YA7pt49wOE+HHS/IvzRmdEa9u1FBxnWU1k3F9tVUd2Hi0Kt+Z8049GT E8I4wiv9hyGWLXcMFuv69Tvu8yn587E1rvXEyveE5pFkEXtejZsO63E/9MRGsIyzSczS kT8l3DQZVsZfFrIXh5fHhENDQyzECQWSJlDMuMTFyeB+SBdTHRjXLLG92BL+Rx9wWoeh FG0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TmQIEC+0xDr0AUuBS5beJ1lWM1GbXFYr8go2/SnRNbw=; b=pPQ5SPdwAYJOiI6E5VaqDK/oIYpW0M0gFBWvQbVshZIaAWngRmkVSpDOvipnFKzyKw 5k169nUFfr8CclClVNPjiPt6TDDCpjpifJu0247pDyAWs3UnhPuO6ygE8cMOmY61BeNz WD7LlJ0y9rRQJRDrAUxPls/UJCfcq4f2MMgOF2sCzW14EnpvsT8b/HAqvs3IghSRO6WN ASKUlPxAiFnrUX/G6m6B2mkPg3BKJTnb/3spzn1LHZRmqLR93o+USyajHYBKtB4FSn8Y gjB7Muo3RdnMYLvI1g0RcdEo3GvKMVsHDE+fA7iuI9DKaHsfEhwLBG/L58gC2zkSUA7g nRag== X-Gm-Message-State: ALKqPweLvIyVj5sYkjUBC4WiPMlMI6Qjt/JGYSaSpEjWeGIr1G7t7kob RVF6u1cq5RWlqJbe7cfYFqLdQg== X-Google-Smtp-Source: AB8JxZovAhRhuRhBijJm5PAMZPeO9dbUMb3wPP+6uCGET5H8O7wH2OYjCvXsiGmWezRGUnd8rPdyvQ== X-Received: by 2002:a1c:711c:: with SMTP id m28-v6mr1322197wmc.92.1526027529923; Fri, 11 May 2018 01:32:09 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k9-v6sm2975462wre.1.2018.05.11.01.32.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 01:32:09 -0700 (PDT) Date: Fri, 11 May 2018 10:31:54 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Shahaf Shuler Message-ID: <20180511083154.fjgmzoeggqfjy2lo@bidouze.vm.6wind.com> References: <1525963090-17097-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525963090-17097-1-git-send-email-ophirmu@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: add an RSS hash update callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 08:32:10 -0000 Hi Ophir, On Thu, May 10, 2018 at 02:38:10PM +0000, Ophir Munk wrote: > Add an RSS hash update callback to eth_dev_ops. > > Signed-off-by: Ophir Munk Thank you for submitting this, the patch is clean. Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_ops.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index 089f114..d04277b 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include "failsafe_private.h" > > @@ -947,6 +948,31 @@ fs_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr) > } > > static int > +fs_rss_hash_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf) > +{ > + struct sub_device *sdev; > + uint8_t i; > + int ret; > + > + fs_lock(dev, 0); > + FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) { > + ret = rte_eth_dev_rss_hash_update(PORT_ID(sdev), rss_conf); > + ret = fs_err(sdev, ret); > + if (ret) { > + ERROR("Operation rte_eth_dev_rss_hash_update" > + " failed for sub_device %d with error %d", > + i, ret); > + fs_unlock(dev, 0); > + return ret; > + } > + } > + fs_unlock(dev, 0); > + > + return 0; > +} > + > +static int > fs_filter_ctrl(struct rte_eth_dev *dev, > enum rte_filter_type type, > enum rte_filter_op op, > @@ -1005,5 +1031,6 @@ const struct eth_dev_ops failsafe_ops = { > .mac_addr_remove = fs_mac_addr_remove, > .mac_addr_add = fs_mac_addr_add, > .mac_addr_set = fs_mac_addr_set, > + .rss_hash_update = fs_rss_hash_update, > .filter_ctrl = fs_filter_ctrl, > }; > -- > 2.7.4 > -- Gaëtan Rivet 6WIND