From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40058.outbound.protection.outlook.com [40.107.4.58]) by dpdk.org (Postfix) with ESMTP id 8131F1CBD5 for ; Sat, 12 May 2018 03:36:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wpvjSg8VcEX/MWF9j1kFmcuBuvMxZuwZq4JCRNdicVU=; b=ebTZCcn2CYERS142KeUXg2TdtQaI6Jrj29OneOeoa65aIoRvjGRE3ODtJ/mTRtfiRC4JmG8G0XDkS0QHNga+/qG7iYpMHKXJ7YOJ2LyU95S5cl+E5MIwqZWNcy+Z4/dFj/szYw+Hm5YN5+ISyaSUj3d/9ChObEgYhSF/u5gDbEE= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.755.16; Sat, 12 May 2018 01:36:05 +0000 From: Yongseok Koh To: shahafs@mellanox.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, Yongseok Koh Date: Fri, 11 May 2018 18:35:42 -0700 Message-Id: <20180512013545.22279-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CO1PR15CA0053.namprd15.prod.outlook.com (2603:10b6:101:1f::21) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:x3ilCaECpGYPmMRj7ArcAGAAjSwm43oVAJs/dqX0E5fOMTdHgLO5o6rsMI8vH3RhsKwcRkzFnARAfY9ZpWWblphjiKx6iEbIoKVJOrvK72CO/kOgcr9io+esNQTVMQCXiaMT1Y2UCG9jLk9+KrpS5gxaJgPndbeqj+v1w2F3dZI6mjHtDwdq4rrS8S0r43taI8l6NM76w2pgCkDXejxZkHlCWDJZGK9hVI2m8GpandR84I/vcd3JZkPAVpDP9B6C; 25:WZf0uSYCR+2ecxEVTQfa3YKcdNmg3PNv7BsmIqYT3XS0Blgb9LbIGtWqS7ZKojPchsvqwhZu1JUtnzBB2boam4jYD3/8Joa9V8W0VMrUQ+RrQblC4XW5+1N9ps4yvXfviB5zUuU3eBCPPwBZRMgKSlC5423oG+KxaTanmzoRkNwNAD7aCu5Q53jCvF8fwl3rm2xfeZKdKz0nKTDXjtb6wNzdEar0EAqOyJoz3FZk7W9h0SwjfQKRm/iZOS2ztwQHYdStt5gSarFpyd4gV9DGUw7YoQtCcldtyJkwOZ5lY8v5FNSxSEaGdBb1hPAahZuoMZLg76EdzPWfcZCfUX2xlw==; 31:nDin2h5psivwrSSuaK+OnnmxIiFZo9eJQHR2zIgI36eqAMlBwYdEkjr5CqLrCwNUSQmz8JpI6IZRAdT4nry13C+nwE5y7c/9dQoSQxc+NyIZHnNAMM3lgKc459MRwbxCeF/ehBFZi6wwSe6+rXF49WgbCXHHCIjAEr34/4c5CL77pKM0OqNBC+GpEZ6v/Lt49I9ghymO7fCc8uovjQ0/OTtWxfWvoINf/Xe5Pe9w+fU= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:yECvAVvwp60eMegij7wPSCtbrj/ZqcKnh2t0/2vZBXKkvY8ADW7pDiIIirs1XbnaoDJoLA0LQtnrXkbQ2lDpHTRazV3nUEqymxf2x5gUvk+q+lEZJbiUjtZ0XlsHTXHsZ1erSqwd+E3RZkxUlPrcDUd3zjJK7GbQJsu10c7jDpv16cWA8NEHxiLhbCf/GmrzkrJVcE2+UlsCdgMdN/QVglk1Fapkh0cv4kXEt5vim1ZSIsmaZxnverUbE0DNlkD+fXAxMRZld151em1PmwiZnLfv59YSv4/YyKnnrAHrlts169s+rPatR44Ko4Pda+qtoUVeKhK/qYetRwDYcNJKZaM7tAPMM+9U4mjN+Vvbimk7A+ipgV/mI1OH30B8pmYHnjJujc5c/aN1nDyIa3yEjGU9KlqhC4WA+vSayktFCqFxf1YxAwGQkU2Ns1AK/YEyOA0Sncn87LQramNECYoa+7plxhxDVub5tlrVOJG4uoesm+sESPO2jV1uujITfofu; 4:Pg707+mtUwL+v3nYij2STXZdd8v2XWBxAZWRgt11Lw51nHJPzN77VtuImJuHfhp+BrpJjGRqwxHB3qXdLakujhYYKzJzbKkPKxog1EZJqhRi7geHqprol3Yjj5Ibzhrzi+X9K533JvMIp2aHrWyRRYvzIYd/30d3fZsjIYzvtGAX65cTtK5MHpBc22erBx0d+pCDortbukz9a2JRw4BDiTKnKWsAtn5cfC8zrfwIr1RFNc7qg9jXTIQo7n2NwG72vGPX+Kq2QZQc042kTBKb3g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 067071EFC8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(39380400002)(346002)(376002)(199004)(189003)(107886003)(4326008)(2616005)(575784001)(86362001)(478600001)(97736004)(316002)(59450400001)(956004)(386003)(26005)(53936002)(486006)(476003)(25786009)(21086003)(16526019)(2906002)(6666003)(5660300001)(36756003)(47776003)(305945005)(7696005)(8676002)(81166006)(51416003)(1076002)(50226002)(3846002)(52116002)(48376002)(7736002)(8936002)(106356001)(69596002)(68736007)(50466002)(105586002)(81156014)(55016002)(16586007)(6116002)(66066001)(83323001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:ls5cLIDr4l7VnTUULnbpGJPcx2XpBTaUE//CWoA?= =?us-ascii?Q?caCqpy4JcmHj8/V65s0qcwTTjbxVoXlIHH4I0d2QsZCTbzAOtKGWpD1saGYv?= =?us-ascii?Q?OrXfu7WB1YiO/23v7JjyrYE5Vp0z+hBphq2D0SYhirLS9zHf6dliD3uuwlpj?= =?us-ascii?Q?b1IfxdP4a1wNSYJjtgKyWYfwELUCkTCtMiMx7tIC73e4CpKdxZIZ9InuDQ4K?= =?us-ascii?Q?0mzCwX1ikPxRh7tGLVD7ni2eZxfbSuPgWys/6OD5ccTjuRYDa69g7oI99LKr?= =?us-ascii?Q?3lcno5kVyq7OIEzg4a7CqeqLM/4k+xNSy8g/QDjQDQL9O1f0pfsPbucGkPdk?= =?us-ascii?Q?y7ctz57qopuJLZc+yeQNB773U+YAoYU546jfRvFaeVX0eZixRbYjZoWp5Ub/?= =?us-ascii?Q?0GoJqyivYch3ZPShmYBhnJ4FFWhqK2efpznGO7pyPgR1IFPEGKvLLZ0UhMwW?= =?us-ascii?Q?jqoKqWI2Z/sN6pqzumdX6lIMxxidV6fuCrDe0CcIyLtT9h1XV5w1+bOswObu?= =?us-ascii?Q?QN+24MMXa4Z4qnKFaczNPMp6f1ZF/ol3+iGMYueXQewE23NJUp8FxiZvuiQk?= =?us-ascii?Q?pmvHeAL+x0L2Ysjkuj5HEtwX6ppuuMmBNc+70KOB8pEtOll9WXw6BUl57Bjw?= =?us-ascii?Q?0LZ1wHgonyzWYzt30tjsBk0DvcLyhlkTNLnDoMrANRU0Py1/LpOmP7m7q2Kv?= =?us-ascii?Q?1Z6pXmpavmUo7ezesq39SwrnKRP8Csgquef0KZNeRvBKuHzRhoQcSlQKxlhQ?= =?us-ascii?Q?IQstW8CslaElV7Sw/voUbLd0HL1iReR17gR465+lCzwD0FTwoLFubwc3sq8T?= =?us-ascii?Q?2RI0KG9sOezeCM50vH7fK8nIRv1D+9fYXK1tSJIaWk361tpJ4IysHEibaJZB?= =?us-ascii?Q?wQv0hleQpk9x98bviiplydXlQZYCnFvHe5Dv8aechuH82fFjzFxVbjXMLXUy?= =?us-ascii?Q?QPIK1RPj/s+Y3veWskEwgXlIKtaZXPuvMK5sGhs+vvCQw3q9hLVcasInT6OR?= =?us-ascii?Q?pn03s4R9aeL9IbmK+NqvImzQPR0BylYoogqpeUP/CsieFTZtn8xbiP5jA5el?= =?us-ascii?Q?oHB0pPfb9HLWeXL5aYkWMoMW8nxO6aUZSGDNTZqTw3Umy2Vj/Ghp8SFxnp6c?= =?us-ascii?Q?XJTwaLfuQsfYpxLXfZ/URypbrAnCWt79JCrWNlz6HsZ7cbeqoZk2gYNkCjMq?= =?us-ascii?Q?u6y2tjBdrRRvcSTVAfbTV6d1eQ4wtGxssXKW8mTEfj5BcJJ1G2UFLUXuXqQ?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: naiWOtQF+cqyGUzvYqXB94meboZohtPATDu38RAkwuF1/ZX7cY5omO7vUlO3dsVvhe96c/DgsS+ZIN8Z17o9RDLKqD0oqjlCBp64mjBp5eX0B+n33RaWfR0c8lv8hll19ngXeoHXFAATsCKHIaaOFoTVg5e/TeXkqTruD13TYErS5S1OGErBv91RFQobtzTU X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:vnX4ilwtkinfDADJYwFXaSvXonzwdlU67uC6nMZnibh987Oq00qjHikA+GvMrzI320APTzD9E/WMNIkEtEk9s1KiSlAfU987VSQMdVmIMuIeMQJixJAe9R7Ambi+W2Rueo+KE0HHaPvMENCifpHYILt+E0uRTTKeoIiBdxZxOZCHaqqnH9VCVhtfvj4qQ9pmUIm+WWWkmCrnUqLpenLxJljjx5O00uSYgpso1llG0fK+FFP0JuZE5PkKdlNsG1DkvpGuwIvjbGKOk4b6zjVvRIPMycPHLkmp1F4RYdJT/sZxLBKt2z+iTAv77v1K6CdwvcSHNxp6DKuy1ecqaqYsu+R1POjiFXERpAMWylYyMGEgxNWNPPdt7r8bjo0yUqEh54spA8foDjUGHV8rfewB50um+4ZDtFQpUkHUzyfCznSsb+5bHhZ/cOZg77ocm6XR5lIslpzt2tN5GrkmWGN4xg==; 5:DIK7voPywLMgtwcfxrgV3lEs9rXWvPkT1/GvVrfsLziukmAfkj0aC5664Lg0N/mLQ3A7bbjeJT4iJ/E+XW043gPFzA7xvXjj24LdCgYLIkggstDmkguYopSFHVBRT3MZLG8UM/eDRCHb3DB0ZCFUZYcmDayioeTae41OOYAmNys=; 24:wOeEXOlx5aGtuBRYkSRuXsvU4RUWSczq3+HnyJVo90OGUEqyrYKPcnAXXlJPB5KZ65ZcNu0W8P6Hh39Hoygqq0FZXq0DBHa4jkrlMQlHvmA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 7:i9sCGdpeWDpjVOe35wlAB5tL62jqebx+2oPZnJuN1edYhs97p15qdaaXI8B+gZLARM5OY9V3PhL88gCircp4IOq5585u7xCRzyuN+lHH7yBIJOpvhZAZrRW5XYi2tBOf/x944fSaokxo6NPu+XPwhkuP48P7VQHSG7cAuSI03xuMrTnlmP/6iF8jdQYMQe/GqIFBSSiR7P62sIerc7JcOnOkao2EuIHkPq4y/h/d0NAqTcVelH3zzZi+eYrPeVX1 X-MS-Office365-Filtering-Correlation-Id: 5e78f862-e17d-4465-c4ce-08d5b7a8baf9 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2018 01:36:05.0081 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e78f862-e17d-4465-c4ce-08d5b7a8baf9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-dev] [PATCH 1/4] net/mlx5: fix offset calculation of Multi-Packet Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 01:36:08 -0000 Offset in a MPRQ buffer must be calculated before updating the stride index. Fixes: f0d61f8f8953 ("net/mlx5: add Multi-Packet Rx support") Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index d960a73d5..387463792 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -2146,6 +2146,8 @@ mlx5_rx_burst_mprq(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) consumed_strd = (byte_cnt & MLX5_MPRQ_STRIDE_NUM_MASK) >> MLX5_MPRQ_STRIDE_NUM_SHIFT; assert(consumed_strd); + /* Calculate offset before adding up stride index. */ + offset = strd_idx * strd_sz + strd_shift; strd_idx += consumed_strd; if (byte_cnt & MLX5_MPRQ_FILLER_MASK) continue; @@ -2169,7 +2171,6 @@ mlx5_rx_burst_mprq(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) assert((int)len >= (rxq->crc_present << 2)); if (rxq->crc_present) len -= ETHER_CRC_LEN; - offset = strd_idx * strd_sz + strd_shift; addr = RTE_PTR_ADD(mlx5_mprq_buf_addr(buf), offset); /* Initialize the offload flag. */ pkt->ol_flags = 0; -- 2.11.0