* [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
@ 2018-05-12 7:02 Pablo de Lara
2018-05-13 10:07 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2018-05-12 7:02 UTC (permalink / raw)
To: thomas, rosen.xu; +Cc: dev, Pablo de Lara
Gcc 8 reports a build error:
drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified
bound 256 equals destination size [-Werror=stringop-truncation]
strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/bus/ifpga/ifpga_bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 16b7e06b6..45597a1bb 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -20,10 +20,10 @@
#include <rte_memzone.h>
#include <rte_eal.h>
#include <rte_common.h>
-
#include <rte_devargs.h>
#include <rte_kvargs.h>
#include <rte_alarm.h>
+#include <rte_string_fns.h>
#include "rte_rawdev.h"
#include "rte_rawdev_pmd.h"
@@ -158,7 +158,7 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
rawdev->dev_ops->dev_start(rawdev))
goto free_dev;
- strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
+ strlcpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
if (rawdev->dev_ops->firmware_load &&
rawdev->dev_ops->firmware_load(rawdev,
&afu_pr_conf)){
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
2018-05-12 7:02 [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy Pablo de Lara
@ 2018-05-13 10:07 ` Thomas Monjalon
2018-05-14 10:06 ` Xu, Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-13 10:07 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, rosen.xu
12/05/2018 09:02, Pablo de Lara:
> Gcc 8 reports a build error:
>
> drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified
> bound 256 equals destination size [-Werror=stringop-truncation]
> strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
2018-05-13 10:07 ` Thomas Monjalon
@ 2018-05-14 10:06 ` Xu, Rosen
0 siblings, 0 replies; 3+ messages in thread
From: Xu, Rosen @ 2018-05-14 10:06 UTC (permalink / raw)
To: Thomas Monjalon, De Lara Guarch, Pablo; +Cc: dev
Hi,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, May 13, 2018 18:07
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy
>
> 12/05/2018 09:02, Pablo de Lara:
> > Gcc 8 reports a build error:
> >
> > drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified bound
> > 256 equals destination size [-Werror=stringop-truncation]
> > strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
> >
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Applied, thanks
Thanks a lot Pablo.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-14 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-12 7:02 [dpdk-dev] [PATCH] bus/fpga: use strlcpy instead of strncpy Pablo de Lara
2018-05-13 10:07 ` Thomas Monjalon
2018-05-14 10:06 ` Xu, Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).