From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Ophir Munk <ophirmu@mellanox.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@mellanox.com>,
Saleh Alsouqi <salehals@mellanox.com>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter
Date: Mon, 14 May 2018 17:03:46 +0200 [thread overview]
Message-ID: <20180514150345.GG20388@6wind.com> (raw)
In-Reply-To: <DB7PR05MB44261E3789FBD22971226CB6C3990@DB7PR05MB4426.eurprd05.prod.outlook.com>
On Wed, May 09, 2018 at 09:57:31AM +0000, Shahaf Shuler wrote:
> Wednesday, May 9, 2018 11:47 AM, Ophir Munk:
> > Subject: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default
> > in RSS converter
> >
> > Hi Shahaf, Adrien,
> >
> > This commit (in next-net/master since 8-May-18) is breaking all testpmd calls
> > with mlx4 NIC, see [1].
> > Can you please revert it?
>
> What is the root cause? Why is failsafe failing due to it?
Root cause is the omission of a single line change in the original patch
(although successfully validated locally, dumb mistake). I'll send an
updated patch.
> > [1]
> > PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not
> > supported"), flow error type 16, cause 0x7fffdb5bb3a0, message:
> > unsupported RSS hash type requested Fail to configure port 0
> > EAL: Error - exiting with code: 1
> > Cause: Start ports failed
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil
> > > Sent: Friday, May 04, 2018 6:18 PM
> > > To: Shahaf Shuler <shahafs@mellanox.com>
> > > Cc: Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org;
> > > stable@dpdk.org
> > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS
> > > converter
> > >
> > > Since the commit below, mlx4_conv_rss_types() does not need to support
> > > special value -1 anymore. Other functions rely on priv->hw_rss_sup
> > directly.
> > >
> > > Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > > ---
> > > drivers/net/mlx4/mlx4_flow.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/net/mlx4/mlx4_flow.c
> > > b/drivers/net/mlx4/mlx4_flow.c index 3f754b480..cb3b9a952 100644
> > > --- a/drivers/net/mlx4/mlx4_flow.c
> > > +++ b/drivers/net/mlx4/mlx4_flow.c
> > > @@ -78,9 +78,6 @@ struct mlx4_drop {
> > > /**
> > > * Convert DPDK RSS hash types to their Verbs equivalent.
> > > *
> > > - * This function returns the supported (default) set when @p types
> > > has
> > > - * special value (uint64_t)-1.
> > > - *
> > > * @param priv
> > > * Pointer to private structure.
> > > * @param types
> > > @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t
> > > types)
> > > uint64_t conv = 0;
> > > unsigned int i;
> > >
> > > - if (types == (uint64_t)-1)
> > > - return priv->hw_rss_sup;
> > > for (i = 0; i != RTE_DIM(in); ++i)
> > > if (types & in[i]) {
> > > seen |= types & in[i];
> > > --
> > > 2.11.0
--
Adrien Mazarguil
6WIND
prev parent reply other threads:[~2018-05-14 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:47 Ophir Munk
2018-05-09 9:57 ` Shahaf Shuler
2018-05-14 15:03 ` Adrien Mazarguil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514150345.GG20388@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=rasland@mellanox.com \
--cc=salehals@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).