From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 396F51C8F6 for ; Mon, 14 May 2018 17:04:01 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id f6-v6so14103457wmc.4 for ; Mon, 14 May 2018 08:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wgU7X2oSKGD8q+UcVCAnrRDyd5rt6Ayxf9GLx+Q4siI=; b=Zv8sgc2ndTrEI7diQkgUsvJaln6E8lCM2I9yZfz28Q/WxmnNAaF6Z+sHCVgkcNU2m2 q6cSAY9dcrv37vghkJtn2P5MVht5jshIlFmrCdkfD6roy0cuPcPKXUQpJO2BPi5riuUv fIVTIksMVeRPXOnCsF72CSjGvL85OLfHxdxbaGZFqwrm08DR35TM3cz6EkkYH/WKwZZG KSf5JWDt0vIFsJ8VPU7G7zXbTW82psw6CfbzVwmtF14SOoFz2Xzu6Y1RzBkD4XNLoIP4 6HgI2XcSMu7vIflsH/lfPGD9vEDSzNgOlVK0ZsfPyoBa7W4u2nfq9WNdfMWAj6vvYoKR CEXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wgU7X2oSKGD8q+UcVCAnrRDyd5rt6Ayxf9GLx+Q4siI=; b=cHSRSflJIeoJI/o6N0wttnjvT/vQXssf790sLTJokbdCs+6ZsTlOPDmf359csxy3oB j8cOG9e7PXYGEw/FX3g+DBFcI8E8eTfBnnqg2eelrlNkSJMJyP50MoDfdSlEsggssAJS E70pH7UUKZ8z68yj4K0CJLarOa9xvyoMihJqeLqx5mCZfr5efHyE+P9u8/wmW8Txp0Xp VKGnRBtqArTxbcWZbzEu5aHpHM+mD8HcZaIZv2UO6zS8VU5c+efQhT3ofJsc8yI6rkuP 2aJoD9aF/F4FX7UpborHykQ3oiauTjvJXz9AFD4A2oWK+4xAqNBjg5gvpf2EvqNMersL /vKQ== X-Gm-Message-State: ALKqPwfISTlBaz213wrMvdGN3fKSj1DT878VKb1are6WNK+iQzAPpKpa mHjXFv0rsCUPt5vFNinJ6JjMag== X-Google-Smtp-Source: AB8JxZo+4mTPi8+Hp5xJVGIPYKnQoFq471ARdWguIgoWwaUApBVriKOaoyWLdTZ4XwSZI+zfwdfl3A== X-Received: by 2002:a1c:1c55:: with SMTP id c82-v6mr5731073wmc.69.1526310240927; Mon, 14 May 2018 08:04:00 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d8-v6sm12844741wrb.52.2018.05.14.08.04.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 08:04:00 -0700 (PDT) Date: Mon, 14 May 2018 17:03:46 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: Ophir Munk , Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" , Thomas Monjalon , Raslan Darawsheh , Saleh Alsouqi , Olga Shern Message-ID: <20180514150345.GG20388@6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 15:04:01 -0000 On Wed, May 09, 2018 at 09:57:31AM +0000, Shahaf Shuler wrote: > Wednesday, May 9, 2018 11:47 AM, Ophir Munk: > > Subject: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default > > in RSS converter > > > > Hi Shahaf, Adrien, > > > > This commit (in next-net/master since 8-May-18) is breaking all testpmd calls > > with mlx4 NIC, see [1]. > > Can you please revert it? > > What is the root cause? Why is failsafe failing due to it? Root cause is the omission of a single line change in the original patch (although successfully validated locally, dumb mistake). I'll send an updated patch. > > [1] > > PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not > > supported"), flow error type 16, cause 0x7fffdb5bb3a0, message: > > unsupported RSS hash type requested Fail to configure port 0 > > EAL: Error - exiting with code: 1 > > Cause: Start ports failed > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > > > Sent: Friday, May 04, 2018 6:18 PM > > > To: Shahaf Shuler > > > Cc: Ferruh Yigit ; dev@dpdk.org; > > > stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS > > > converter > > > > > > Since the commit below, mlx4_conv_rss_types() does not need to support > > > special value -1 anymore. Other functions rely on priv->hw_rss_sup > > directly. > > > > > > Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Adrien Mazarguil > > > --- > > > drivers/net/mlx4/mlx4_flow.c | 5 ----- > > > 1 file changed, 5 deletions(-) > > > > > > diff --git a/drivers/net/mlx4/mlx4_flow.c > > > b/drivers/net/mlx4/mlx4_flow.c index 3f754b480..cb3b9a952 100644 > > > --- a/drivers/net/mlx4/mlx4_flow.c > > > +++ b/drivers/net/mlx4/mlx4_flow.c > > > @@ -78,9 +78,6 @@ struct mlx4_drop { > > > /** > > > * Convert DPDK RSS hash types to their Verbs equivalent. > > > * > > > - * This function returns the supported (default) set when @p types > > > has > > > - * special value (uint64_t)-1. > > > - * > > > * @param priv > > > * Pointer to private structure. > > > * @param types > > > @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t > > > types) > > > uint64_t conv = 0; > > > unsigned int i; > > > > > > - if (types == (uint64_t)-1) > > > - return priv->hw_rss_sup; > > > for (i = 0; i != RTE_DIM(in); ++i) > > > if (types & in[i]) { > > > seen |= types & in[i]; > > > -- > > > 2.11.0 -- Adrien Mazarguil 6WIND