DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue
Date: Tue, 15 May 2018 17:11:34 +0530	[thread overview]
Message-ID: <20180515114133.GA19163@jerin> (raw)
In-Reply-To: <1526376227-25534-3-git-send-email-gavin.hu@arm.com>

-----Original Message-----
> Date: Tue, 15 May 2018 05:23:46 -0400
> From: Gavin Hu <gavin.hu@arm.com>
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue
> X-Mailer: git-send-email 2.1.4
> 
> ~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error:
> 'rte_memcpy' call operates on objects of type 'struct rte_event'
> while the size is based on a different type
>       'struct rte_event *' [-Werror,-Wsizeof-pointer-memaccess]
>                 rte_memcpy(ev, &m_data->response_info, sizeof(ev));
> ~/arm_repo/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49:
> note: did you mean to dereference the argument to 'sizeof' (and multiply
> it by the number of elements)?
>       rte_memcpy(ev, &m_data->response_info, sizeof(ev));
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> ---
>  lib/librte_eventdev/rte_event_crypto_adapter.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
> index 831f842..0f34fe0 100644
> --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> @@ -527,7 +527,8 @@ eca_ops_enqueue_burst(struct rte_event_crypto_adapter *adapter,
>  			continue;
>  		}
>  
> -		rte_memcpy(ev, &m_data->response_info, sizeof(ev));
> +		rte_memcpy(ev, &m_data->response_info,
> +			sizeof(struct rte_event));

Following could be a shorter replacement.

rte_memcpy(ev, &m_data->response_info, sizeof(*ev));

>  		ev->event_ptr = ops[i];
>  		ev->event_type = RTE_EVENT_TYPE_CRYPTODEV;
>  		if (adapter->implicit_release_disabled)
> -- 
> 2.1.4
> 

  reply	other threads:[~2018-05-15 11:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  8:28 [dpdk-dev] [PATCH 0/4] *** fix native clang compiling errors on ARM64 *** Gavin Hu
2018-05-15  8:28 ` [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib Gavin Hu
2018-05-15  9:00   ` Bruce Richardson
2018-05-15 10:10     ` Gavin Hu
2018-05-15  9:07   ` Jerin Jacob
2018-05-15  8:28 ` [dpdk-dev] [PATCH 2/4] Driver/Mellanox: fix PMD compiling issue Gavin Hu
2018-05-15  9:11   ` Jerin Jacob
2018-05-15  8:28 ` [dpdk-dev] [PATCH 3/4] cryptodev: fix the clang " Gavin Hu
2018-05-15  8:28 ` [dpdk-dev] [PATCH 4/4] ifpgai_rawdev: " Gavin Hu
2018-05-15  9:23 ` [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib Gavin Hu
2018-05-15  9:23   ` [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue Gavin Hu
2018-05-15 17:05     ` Yongseok Koh
2018-05-15 17:52       ` Sirshak Das
2018-05-15 18:38         ` Yongseok Koh
2018-05-15  9:23   ` [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang " Gavin Hu
2018-05-15 11:41     ` Jerin Jacob [this message]
2018-05-15 13:34       ` De Lara Guarch, Pablo
2018-05-15  9:23   ` [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: " Gavin Hu
2018-05-16  5:13     ` Jerin Jacob
2018-05-15 11:38   ` [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib Jerin Jacob
2018-05-16  6:08 ` [dpdk-dev] [PATCH v3 1/3] net/mlx5: fix the clang compiling issue Gavin Hu
2018-05-16  6:08   ` [dpdk-dev] [PATCH v3 2/3] eventdev: " Gavin Hu
2018-05-16  6:08   ` [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: " Gavin Hu
2018-05-16  6:45     ` Jerin Jacob
2018-05-17  1:47       ` Gavin Hu
2018-05-20 22:28         ` Thomas Monjalon
2018-05-17  2:46 ` [dpdk-dev] [PATCH v4 1/3] net/mlx5: " Gavin Hu
2018-05-17  2:46   ` [dpdk-dev] [PATCH v4 2/3] eventdev: " Gavin Hu
2018-05-17  2:46   ` [dpdk-dev] [PATCH v4 3/3] raw/ifpga: " Gavin Hu
2018-05-20 23:02   ` [dpdk-dev] [PATCH v4 1/3] net/mlx5: " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515114133.GA19163@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).