* [dpdk-dev] [PATCH] crypto/aesni_mb: fix capabilities
@ 2018-05-13 12:46 Pablo de Lara
2018-05-15 19:15 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2018-05-13 12:46 UTC (permalink / raw)
To: thomas, declan.doherty; +Cc: dev, Pablo de Lara
Missing AES-CMAC supported parameters
in PMD capabilities.
Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
.../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 9d685a09f..81a65cc61 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -289,8 +289,27 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
}, }
}, }
},
-
-
+ { /* AES CMAC */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.aead = {
+ .algo = RTE_CRYPTO_AUTH_AES_CMAC,
+ .block_size = 16,
+ .key_size = {
+ .min = 16,
+ .max = 16,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 12,
+ .max = 16,
+ .increment = 4
+ },
+ .iv_size = { 0 }
+ }, }
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix capabilities
2018-05-13 12:46 [dpdk-dev] [PATCH] crypto/aesni_mb: fix capabilities Pablo de Lara
@ 2018-05-15 19:15 ` Pablo de Lara
2018-05-16 8:27 ` Kovacevic, Marko
0 siblings, 1 reply; 4+ messages in thread
From: Pablo de Lara @ 2018-05-15 19:15 UTC (permalink / raw)
To: declan.doherty, marko.kovacevic; +Cc: dev, Pablo de Lara
Missing AES-CMAC supported parameters
in PMD capabilities.
Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:
- Fixed structure type from aead to auth
.../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 9d685a09f..01530523f 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -289,8 +289,27 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
}, }
}, }
},
-
-
+ { /* AES CMAC */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.auth = {
+ .algo = RTE_CRYPTO_AUTH_AES_CMAC,
+ .block_size = 16,
+ .key_size = {
+ .min = 16,
+ .max = 16,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 12,
+ .max = 16,
+ .increment = 4
+ },
+ .iv_size = { 0 }
+ }, }
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix capabilities
2018-05-15 19:15 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2018-05-16 8:27 ` Kovacevic, Marko
2018-05-17 16:40 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: Kovacevic, Marko @ 2018-05-16 8:27 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan; +Cc: dev
> Missing AES-CMAC supported parameters
> in PMD capabilities.
>
> Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
> Changes in v2:
> - Fixed structure type from aead to auth
>
> .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 23 +++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 9d685a09f..01530523f 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -289,8 +289,27 @@ static const struct rte_cryptodev_capabilities
> aesni_mb_pmd_capabilities[] = {
> }, }
> }, }
> },
> -
> -
> + { /* AES CMAC */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> + {.auth = {
> + .algo = RTE_CRYPTO_AUTH_AES_CMAC,
> + .block_size = 16,
> + .key_size = {
> + .min = 16,
> + .max = 16,
> + .increment = 0
> + },
> + .digest_size = {
> + .min = 12,
> + .max = 16,
> + .increment = 4
> + },
> + .iv_size = { 0 }
> + }, }
> + }, }
> + },
> RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> };
>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix capabilities
2018-05-16 8:27 ` Kovacevic, Marko
@ 2018-05-17 16:40 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-17 16:40 UTC (permalink / raw)
To: Kovacevic, Marko, Doherty, Declan; +Cc: dev
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Wednesday, May 16, 2018 9:28 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] crypto/aesni_mb: fix capabilities
>
> > Missing AES-CMAC supported parameters
> > in PMD capabilities.
> >
> > Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
...
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-17 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 12:46 [dpdk-dev] [PATCH] crypto/aesni_mb: fix capabilities Pablo de Lara
2018-05-15 19:15 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-05-16 8:27 ` Kovacevic, Marko
2018-05-17 16:40 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).