From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0083.outbound.protection.outlook.com [104.47.33.83]) by dpdk.org (Postfix) with ESMTP id 8D9A41B6AB for ; Wed, 16 May 2018 07:13:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XLuK9rvRVDMVqiZ+elinncnCyzCuwhhCl0ISJ/pberQ=; b=DSSyY840ZyybzUDHoowrvoLFBdmVBuRERQDZCG/ONi0iLzOA/yqfQysLPvNpu0UuS5Gw4QhfVLai/ad7drWt+KTlidMaouNYTOqo8qzfAQnfFggtARVY4RreKxWDH1NyK3ZvxcQFTL1pscvlgpzZLvE3KK/7e+rdkKT5SFg6g8M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.178.202.31) by CO2PR07MB2520.namprd07.prod.outlook.com (2603:10b6:102:13::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 16 May 2018 05:13:54 +0000 Date: Wed, 16 May 2018 10:43:36 +0530 From: Jerin Jacob To: Gavin Hu Cc: dev@dpdk.org Message-ID: <20180516051335.GB16248@jerin> References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-4-git-send-email-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526376227-25534-4-git-send-email-gavin.hu@arm.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-Originating-IP: [122.178.202.31] X-ClientProxiedBy: MAXPR0101CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::12) To CO2PR07MB2520.namprd07.prod.outlook.com (2603:10b6:102:13::7) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:AAFVkx66AB6vNGHsKp9BeyGeN4aNCya53jkI8v4o10m/FKccNa4jKR6L1gKhWGoUQiqcPTR0lK4duJtJrH5HzSkuf3UWZgh4T0Q3KQUh3pczCPl8g486c8Yh1g/h8pcNwms86sgkL5dUVQmJFWwXDnruE1bQby6IwEXrhvtgt3L1K5pkY5GOQKKYrcg8CO+cryrV7UOVe9ZMsaHKYi2SU5nzwp39W265/VQKrEwZXPN90kybnrm6AQe5BjiHGSVo; 25:n32A7TKYcPRDJSULGlXKA8mQvmAhYmDIgKYu/EoYwlMM+gwglaWQ/fQRB8YF5jvWZQPCUNnL5aMV3KXnzv/6lBP9/TZber6gXlwNMx9h+7Lmhm9txjX3/ieudi2sv8eFQ9lErrPQKs4/i8ZRxGs996RzLZb0qtX22AztAtufsYwwV6YCiphrVdGwz17WcGnLyL2LVnabOE6a9pFJ9PNfuylfX9I7iMn059c40W5b8N5hqrWQAB5skKDeNAzK1H3ViJ/QHMDHv2cSDMlz3PWQArXKpbqqd8XSZs4mCpeBlHu7snUq0gjWe83VdKRLDx0MYPs7dZn+Y3j5I/OuIjqFaw==; 31:nxZk2v1qVqMYv22UAX7SDQ+1ZkEZPvRwKikynqz/r8K5Znib4/BS3kCvhxfLB5QzmtQ0VSsWZ9Fl7JW+382cSJdP/gabe26x8H6AoNXJ5RE9xebCa580bmZg6FzO73A/SJr5NkPFJZfubkKoBUoNI7nCZ+tacIDbZkN/u3HxqaCQxZLPPXyR5lEdtBTCkG6rWiTRY2IFhryklJAATyyN9k1cE9FqRCAXixLVsYWlwh0= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:pplLuj9cMtE+XzAfbqYTs1hjrTZVyqKKhIxw8QpgVfqlKHMzf0WnYe7f/L+WGIyY5AhNcR8SfRx22Uecx2YFE9wzNz3DbyJE4apOfAMKH6v6RbiuiGLWX3+RtMo5Rcqw7SVz8/GUh94nntBghiiJDrmUDy5tV4Zedtss5zG8Em8Us8ovw3g0gNeKjqd+ReTQ1NVONxPu6fCzmXBUZGMB5CtyGwzzYArH26d09PZmxGr0Gw0pp5ax/LAP6WaJVLVWVTZDs2RBslQoPjx3k+dP7t3HryZ1Jux/ydra6V9t/Rp5GXuL6vWJAOuSWiYc9+V8ISP/6DBoa5bGa4yPoN1K2jZY7feavMH3nKz6r3tuTr+XcKyrrLI29VvB3ta5ZUEGwZlFO5hUt//IzDQcPBy24IT61ipQ4h0e+k599KKg3fnOZ6AwcoKGNTnMuHt+CgAyT8hFJfFtaxymQszdJ4rBZk7HGX0mmRnZa7Sn4oxbiYMiDVxcjgaBQ4yZwrQnnpZNpNXkU+gb/WiUc82H74VVmvmRNKkSXsaPubaA+B5YLQBz4sBf9/rNxscLdx4cpO2JboGO9kmjWRmBc968WNaR5qcs+KH869T1lDDPjhotgY8=; 4:iMx8kQkeX/NYJ57lscNfvvkgbikOLospyzDfQCvPpg2wbNJ6ovq78oQveT1NxcGQC4Qv88lzH6FZuSPscUDF4FYYpsKiFjcS5wqp7eVtW/l1ezJe/XJ4sNVRw63Eno48Gw02zPY4Mxi0T4FaTMQivsYWTG2+cFkU+iUpz+5RpuIq2MjgBVZUNMxwkDOBDzbRgitEyFVwV1C/eEYSLQnz4sL6j7fb6jvXqgZhdhFG63ZxcH8CmU7877bzSyecVXjsjyudg4MiFRfXMy0yVpRgnHIOGxk1pJ9cc2Z/wE3KZpKPXb0LLnyYxbimQ3vtiqar X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2520; X-Forefront-PRVS: 0674DC6DD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(396003)(366004)(189003)(199004)(13464003)(72206003)(58126008)(229853002)(4326008)(478600001)(6916009)(6666003)(33656002)(305945005)(25786009)(7736002)(33716001)(68736007)(26005)(186003)(16526019)(23726003)(1076002)(106356001)(105586002)(53546011)(97736004)(386003)(3846002)(6116002)(6496006)(76176011)(52116002)(59450400001)(16586007)(446003)(50466002)(33896004)(53936002)(2906002)(316002)(486006)(476003)(11346002)(8676002)(9686003)(55016002)(81166006)(81156014)(8936002)(42882007)(66066001)(5660300001)(956004)(44832011)(6246003)(47776003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2520; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2520; 23:/S6SO9kRSyaQXdU3QaLIT6hg1tq/N38ETrAt0OJWj?= =?us-ascii?Q?ycJ9n//UBnL4zZWoSJ8uTphUcxe6uTzBjamhf6K8F+bMvVPbg+64XNbdWAN0?= =?us-ascii?Q?cvy0VPz0N2FzGmqf1tlQST/dSls0VgLrTAPHLXNacfmKo4RIj4rcgiVww+Ga?= =?us-ascii?Q?WYPhlcTeUU3SXIdKAOQ0SrhekCmwwsixki95SgwIuUFRo/ox2CO+rmaCh4NP?= =?us-ascii?Q?WAvfiwYGc+qmATwcrCcuXVgWh+7TDZdkTtgIfnYAPmUdSJ+GvmOYFo76yhDq?= =?us-ascii?Q?3tm/O+7dcfje53ayL8uGNZOkSGZfMZLpn7OXVPeibxQeIsgTuD0yHVirGgaN?= =?us-ascii?Q?X7CIfk+n8sMYcZXRp5F2Kfo3kTlWtr0eRSHh6CrtxsSVdlbSNikiCpb8z+Hc?= =?us-ascii?Q?turu0qkqsJl+aL28CDnR+FUaKSRL1qwZx8OJVVCa/QxZdCVgU0jTU9UeR/cl?= =?us-ascii?Q?85uvvED//sNC4dKnaoUSLWsZye7z3ErWVzA5YZwgy4M+g94j+uR/tTo2W2dP?= =?us-ascii?Q?9ckBpyjI8OvoopF9qx/mPqekELRq//u+m9XUMzVaS9/7AspRsE5/dsDsymHN?= =?us-ascii?Q?/JS/UTzuKh2272wOWYfdeSNSdbqo4J+JooXcron9z/Wi/UgBQ/tT2SDUaNfB?= =?us-ascii?Q?TcDbOQBtWoj8QrDO+y+LJqjHg4t5Oa8p9F++Cv4uL957iEuZdOh1ZGH+kXyx?= =?us-ascii?Q?9C2EGGR0LwXlOuLjvZvVTNqFU52ol8bGcG0OTLlImlNIqLHOP/lo7Cgws7bS?= =?us-ascii?Q?+Cq1vvtIiwlo+Oqeu/Y4kQBChX8YrhqBPNUtwEtddNE38RuBK7e44chEvluC?= =?us-ascii?Q?Oqb2GtBOh8kBjR3g5ZHk9vJHwWhphAr1gVjTbEgfqV3lcsJe8HfSdcAYWrWK?= =?us-ascii?Q?xBlfISsbr3oa69mZsHXz9fgwBvi+7WcJwT91vNiqhaCSGNhigf30Rg1q3xI0?= =?us-ascii?Q?kJe8rqsbG3y1b0e3NEzhu9Iepy5+jasPQ28AqZDqa8DUUzUUEnApjsrx47xV?= =?us-ascii?Q?yZok98sf4b5BcVlt5yYn1Vr/xBrKcbSy5u6nYpD8ddVyJtGhPJ0FM/73Gi1O?= =?us-ascii?Q?WX6iN4ankHxr0vPTrQ/HiT4AGRBqH8flFzrfSpCSX5UL/PKbBdhJ8Y5x2a9x?= =?us-ascii?Q?ZGoKsq5VUorz9fUFxUcrrNRLLF2ABho0Uk6Hk0KObt7Pu5kroMWdQ/ZUnqHg?= =?us-ascii?Q?R4BxC6G4dADDKbgPBJ/XpzVxYJoanRNIXaxEa8DEpl4NPm0ciF77ympsXQ/O?= =?us-ascii?Q?h92vo1dzDgjW0QTkiNJECQ3Ft8Oqnva5QOe9/gLRU0W/YozUMJNUG0+uth9b?= =?us-ascii?Q?bzM4Fozcss3LVoCh3uCFmssKRi+d9qAN+rNl7DTOWIBgZk5PblHwsCBVpR6h?= =?us-ascii?Q?PJKKzMPqpuS7C8qiG/SFY581FE=3D?= X-Microsoft-Antispam-Message-Info: x5Fs8xt/NIhW4Dx8mE07XdqXl6xH8fwyuDi5BaRmayvFHPM+ex/hHGl/gwHTnYBOLG1ktjbBGyqiNPNtVYiCfAJ3xOB760kd16r2KHjFuzo9AATUBLt1pD9NyRsA73rthiilZNUiFaAxdvI8WFs1fNvVcVeaU0Hu//bIP4GbS+jCLSUpV5PlmraVNMeaDwXu X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:B0OfxWP9oV1qvmpn3TCD2BKoxiwIIUiaZHhZMIgKYmARPdPNLjhTfzOf3l2HWoApg1IkAoreuC011YHA4QwzioKxfbvNj9KK72ZDjQQwV/Pruj/zQt3uQ/6IKSmBNG+BVKJkmFiEwmBtrB+2U0KCmVuobNnDyAFJWrCZ7VokHLEXem0ArAJm0p8rEyqrb1o4ibKKhefV3IFxDBNuuhIS0QHuAdqdo07rwSVtXS3Y2N9TWQok8+aiYqtq06yVxVToGkKwYzW08qqj0oT1x9nqaNf5I2sq+Tde8LBJ6egJjPuNNfBNiJXfM1qpbc9ssqKvzfb0uTo0Xk2nDioCOrun5xtcXFQH2HwJCXrQcG7HmoTQjs6pGsDGOkqW1BvA3ufBpRNjbehZzw114gpE3W92QGJjCxRtpl252O6COj1RWzck4+84GFsxuCoKRmEF8UaaOn4LFiDRcn9+GCcUlqOWog==; 5:wUuUqpuiBuADndWrsEbanYqYkWsh10t9wKi8RZzuEh1UkJnjhJ3myat8ih4lOA6NtW8dEUWgPjQ6g8ZilHlhW6GtViQxo1XQOrvSZCctQYW3Tt6dEUEqMI3hbMDZGH7qAd5SeP9oyQ1xO28Xg+cW2AHvg5WIRpTiiT4ijdzYFBE=; 24:1pHdl81HaSn+iqShu83E3zdxIvL72aKMHZRGZA+gP8zgwbKOrCsUgSu0uhMVwgaFsgo9qzRstzf/U0ii63UJDepwNR53D2Y0EqC/gsDyUXg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 7:Tg8UwOnHsNmtEYFsMspVz1B3iUdxbvcI6BZrBl41X/Kbcw8ffVkfCupx+rncRnxAN/9EkjGB5cm9Tn74+pDsdFh2ZEh4MAblgD6F/HygxUszEwNMFb722YEws+QZT8zxuNvllatSasWt1OQKOUz18ICWLhOe/ewtiKGdoRHhTUVqFeifXyTezX99vz5QegzqcncgBgMFMM85Vi5jEeaAyIRx2IfbBH69XvYfOngWAclTbuX63RTVnWn8PEDFkozF X-MS-Office365-Filtering-Correlation-Id: 5cfb3621-0617-4b6e-115c-08d5baebd26f X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2018 05:13:54.0087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5cfb3621-0617-4b6e-115c-08d5baebd26f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Subject: Re: [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: fix the clang compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 05:13:58 -0000 -----Original Message----- > Date: Tue, 15 May 2018 05:23:47 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: fix the clang compiling > issue > X-Mailer: git-send-email 2.1.4 > > Newly introduced #pragma pack(1) in the header file caused comipiling > issues for the files who included it. > > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_fme_dperf.c:5: > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h:8: > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_hw.h:8:10: error: the current #pragma > pack aligment value is modified in the included file [-Werror,-Wpragma-pack] > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_defines.h:100:9: note: previous > '#pragma pack' directive that modifies alignment is here. > > The fix is to change the #pragma pack alignment locally and not have > effect on other files who included this header file. > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli Perhaps this fixes compilation issues clang6 + x86 too. Please change the subject line to start with raw/ifpga:.... With above change: Acked-by: Jerin Jacob > --- > drivers/raw/ifpga_rawdev/base/ifpga_defines.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > index 0b9622d..aa02527 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > @@ -97,7 +97,7 @@ enum port_feature_id { > /* > * All headers and structures must be byte-packed to match the spec. > */ > -#pragma pack(1) > +#pragma pack(push, 1) > > struct feature_header { > union { > @@ -1659,4 +1659,5 @@ struct bts_header { > (((bts_hdr)->guid_h == GBS_GUID_H) && \ > ((bts_hdr)->guid_l == GBS_GUID_L)) > > +#pragma pack(pop) > #endif /* _BASE_IFPGA_DEFINES_H_ */ > -- > 2.1.4 >