From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0048.outbound.protection.outlook.com [104.47.36.48]) by dpdk.org (Postfix) with ESMTP id 197551B421 for ; Wed, 16 May 2018 08:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3cgwih4AeVtuzWgSog9llPxk+lWLEniiDFfT75C+AM0=; b=opeiVjUDvjDSdck86D1u0J3WXhBptzKOu3GxGxfsxoX8f6bnAac8cUmjPyACBZh4kCgbqUgAsEWElZxafN2xIhimDPMIclWJLyeyXO+KQ+EVeB8cdXcmqrwDvO68VPyV7wLkJDDSRHldZH1Kw6VEyVY3wIc0dckH1sO2fBSOu14= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.178.202.31) by SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 16 May 2018 06:45:50 +0000 Date: Wed, 16 May 2018 12:15:43 +0530 From: Jerin Jacob To: Gavin Hu Cc: dev@dpdk.org Message-ID: <20180516064542.GA6418@jerin> References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <20180516060802.36181-1-gavin.hu@arm.com> <20180516060802.36181-3-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516060802.36181-3-gavin.hu@arm.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-Originating-IP: [122.178.202.31] X-ClientProxiedBy: CO2PR04CA0098.namprd04.prod.outlook.com (2603:10b6:104:6::24) To SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 3:sUdUD2E08hGmzxtFLvhR2LUXUIMur45W5Yrk+DO7OIm7hP8wSOmTSi/jCowlB3nict39A+PSSgwFoRxJ1u8IU6xPVaRLdqrA6XmgTkKTOhhhPACQUwcW5d1R+IfTQHZPnqgfxBWqn2Ebqh9I2Go+hjRA4V2tYBjmmDwGfMveugSG0/W/RuwCyg4t0B+odX3tjtmb2InLdcy1ye3ncssCw37IHZpOhFTDrIhG8EP+7osY0tqDotyXjjLuYTGazwTA; 25:c19bYVk7G37VwvaZ2BnrulEANPBoqr1sUKueV19dT0klxkAcFasIXrOSVBXi3NbDcA1a8sk+QV4t3CYZHNsdZbbwijx7p8HAyzw05P0UnWff1xqQfyZgtfugD/VodkJXbLGgP34TJrAWpCqdUno4KnOJPYjQabm0/H+sTNHfZLHTPxXRpjuDctjcD37VW6zJYG0mzcEaqK7PEZN2rMFWS2sUKXk/8HAc1rxtrKG+Nyrm01FJHY1DWi+6YrdCLBtlWz2RL8PdF3ODDlwjq13B7K72wd5rhf+V7PnYKK9JaAJOm96KhdcoFmn3g9IbZ+GdVFdNVKalQXeWPHwO8xXUoQ==; 31:ME3Mlvvx9SM2+IyTdpHiAwCtqfftT1HaF3j1en+nDM8cwNckVKxqriIJqiRPoyqROW/7FtzjjI5l6YNWmVsf8RCcGYUwM4LlhE8KV3D0pl67qhePP8uoJuJAg3DdSokGHBCDTArxBsAnEO9pcLvRGftL+jv8AdgzcHwIc7aUkHSxbBUN3xsmbCSbPu/3/q7TbKSO2ffsziAJhpugJfIwt5EuULp5ko3fAJTCRAEOqFo= X-MS-TrafficTypeDiagnostic: SN2PR07MB2526: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 20:Cf2fcdLRFczVcY20CLoF6GQj34Gs5UJyEfPjM4VJNaDqGrwfAjZ9CPCHFFMoDPWzVVnrTIPH1nf2dq0uV2EtiR1MZ7bCEYy4cMgRxbyBVP0DgBfcdnKrJRdDPir9FymN5oNs8mQOzgiHxyKSlXplMYpNMJVpsXlFa8yjIf8ZPgHGWhPccy9zV2Eor+UStXWGKuom1B58UULpkm1S0NrEiCtJbxNo/7lxe7ke5Fn1Kga78lTv0wwWbLyIy1UdChiwJr8mweC7SRPyd31pHlpjQTk7qs2zcma81wzm7E2hSXvltHXNo10eA2jubMnxpDguDj4MqV13Q5nYasehtsF+k5vQ56t+eQ/zX7XAnlschM2tsd+fzW+N9QQ27hkunq49MmyKytEH2tSsYUrg9oJMeWTruifm2l6vvpF04mDFWPwKAt8Je4myEfHa2LxNlcEIBcir8rBtQGxdj0P8d/Askpx/HmOvaT9HcHwFJvgNHsZfCKFhpBVbvGEEeTeGsUlH0AIpsWUvUghx0sXH054BEckPK6ORLdoSzMZgv1eJ1m6QsKa03eBNf/cWqOWe7u56GiM/s4K+wcpRUIVlEH168wLj/IXwOy0/Zj70zZzlwhs=; 4:XLTS4P5/bc5XIASCFKq87B14Gpt4y0FXA5JlzhZNFYfRulZI6nWJslT5N0fzgzhD4X/oO5bCL24EhyVsWof9FTjPa0yCgkKY68rvN1A03VwiEVQgQsD82hXC363ADssi+R0lFj9hXk2rkzzH8ZxkEmEvxrcLpNsh825NaNZU+b7R4P2+JhyqvuLUBiOYpmq4rxE8Z4/jQlm/IXty+eOHKM76aSYNBtG2IGNRlK7k4JWBKrUMc/KWVanEcgUfyYwaQOxGkj8zNBesRchO3i8d+DGjIQ6NTeXu1F4IpDqffWClAPnCxJJYSNtiIL/yZ7xj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2526; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2526; X-Forefront-PRVS: 0674DC6DD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(39380400002)(396003)(346002)(39860400002)(13464003)(189003)(199004)(446003)(229853002)(478600001)(33716001)(52116002)(81156014)(81166006)(6496006)(68736007)(105586002)(44832011)(2906002)(53936002)(6916009)(9686003)(6246003)(55016002)(97736004)(476003)(956004)(486006)(25786009)(4326008)(11346002)(5660300001)(16526019)(42882007)(6666003)(186003)(26005)(72206003)(106356001)(386003)(59450400001)(305945005)(33896004)(7736002)(8676002)(76176011)(33656002)(66066001)(8936002)(47776003)(3846002)(6116002)(16586007)(50466002)(1076002)(23726003)(58126008)(316002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2526; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2526; 23:HuQFCv+Sk5Cg0DDKb4nZrYqmaBn43Gon+rKyobKVr?= =?us-ascii?Q?Wl1gzDLL+nwplx5M8/mL5tWSHnHGkpzhpjy17msi+zIc8+vYm6FHJZVIGceb?= =?us-ascii?Q?EbANJ5YA7edDMrdijI0e1maD9K+7AD16ZQu6sCN7m1S2HJvHHHxges5TA9V2?= =?us-ascii?Q?15bauENAyVFFJVuVZOQ34tpaBTZKu5GLHbv4ilmQ+o7UXDJY4G//Ol71eQ0s?= =?us-ascii?Q?GP0Qf9c9DrZFj4mtScRxH9Aragyuza3sSKGViAlPw4ZBKtSuCu+rh1FL8sT4?= =?us-ascii?Q?z/tV9RnXkgbosira5XnisEgBgiOl/ywpNiui5ZjX9WYv5+97QwienrcmIh3E?= =?us-ascii?Q?lh1FAfqrf+wVKSD3gUNeFRigHyyvO3cRyuXLBnnvRI7x3OSjt6R4Ll8NDv/G?= =?us-ascii?Q?cnBeToW7gI6cv+dvrejJaOAW+Krlt7iFSEPj8GLeIfNm049ooIZ8V4Gh25RI?= =?us-ascii?Q?KTdte92gLDrDN7g9xpWjwbC/5VS8/YD5iTP8i6bW2WgIc8svWPJIfDik7gzG?= =?us-ascii?Q?C6SphPvKVCaXfQVqP1H5U6w4hRUKOhZkxzQAtnRCVVVMdxUQZp7FeNlGE5Af?= =?us-ascii?Q?Q4q9dzHzhXXMjxaetbRDoQQWVOHP/Qx/ul8XCDtrVwy4ma1waTlasAvV9GIH?= =?us-ascii?Q?MfIqrLz9O/cOQSu8MBHhEI03OgEFt1w/9s7oWlz7UAfRK5pZgdooAH+MzG3O?= =?us-ascii?Q?EwDpsKa3Dhm9lVkJbjmb6QN96T5R90Pg6vmTDdr0D/CoSWTRCnSIaA6aYYRp?= =?us-ascii?Q?ft7h52NubWaxNEMt/RbSVQIZzxgZIRcIYD1EFXdxITqw8aNdzrzjumwoBM5l?= =?us-ascii?Q?sqtzr+X/dpAok7kYNcXyZk9jmNFzGOLah+oFROZcAhhJpMEum5OeIkBHbPV6?= =?us-ascii?Q?/nP5wP3/j2c6a0kr0QHbkB92uJhEoI36n2b0dJ0fbHZqVFPj+KyphI+mcfDN?= =?us-ascii?Q?DR89sZOYblNi8WkknXNWlgYge+Mqfr4y9zSXytmgYUEZaKBWcCR5GnCn/XNV?= =?us-ascii?Q?Hb8wbk0rMnd0SHl8sj1AuOkrH2Usr+4y+mZp5DouAMLwuLiRgvjtzuF1NKgB?= =?us-ascii?Q?I673VhDG6O3ZG9SBlSWquP+QX0xVqGb80U/pX81BPbDYkuJb0SuCgJlf5hSb?= =?us-ascii?Q?xElNprPUHJYOLJqzsyezCHLq2tGq7z1GoDQeCWI+oqbMi+oTLrruMpzQ2FX1?= =?us-ascii?Q?8CtWRqZXaS37N1ChC//iHcGMVwyfpVtM3Z6PCjfVnemG4tXin0i579E0hpqP?= =?us-ascii?Q?G3gzMM2gK/7Aad8N/rzCw5dw7+99NfA3G+Bpkj20e7jKsDZB5dc6Tfak1DX6?= =?us-ascii?Q?1hjTZpSRrdXtd4cq+UXd7uxBuRracsnWSYk/vfSIc2AKqsK6axZvybKHgMPX?= =?us-ascii?Q?DLaCQ=3D=3D?= X-Microsoft-Antispam-Message-Info: IAcZzlfSc0vNzLRWDnB8mW6j8qkI3A8hW/iI1AK2asrvflt5a2rVu5UA4DXkm7+4JomsWN+5dd0z5S0YqOz6YJgLIdO4HScyzY6lezdZa8yLu9Ra7wOGSSyvogWVAJPoWNUpei3K4NYBKNbwJfYftgLKZOY8j2TzkthnsMr4mjdJ+sXEGYVcbepYihEE68T7 X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 6:qTprzUD63Pj2F+JZdAh8yXdvSXPLfNLGs2L1GfL00xRMvId0vpvU7BQVpIVVvcAXRJWK8WTeZBh2crirF1x2/0oVJ7YCQqLvld+LdwqEWYIpHFu5ICpARdYszlPtO8SYvi4qSzlQuD8RkSdEjwYBiTZedNfpn5g9E/WAkiv5I8X6Jqjv7UeHZiDbWJo8Npi8s8hcHyhN2GYjMhaaIPSom8i+IwPV2B9la9LJ98Gg0GLRytJVgMuyNczBQ5nvwZg42T4Af4x3SQOeAotl/Mu2gw0X6BpZHvgL+vcm2wBd3gt5o+XqgTJ2b61RcsyUWQwkhqwTCESELZI+ZFTQZ26esuIDDQy8y2iVfA7wwx9EdWMdHV8gBHfcIbOJ15j9N4ovr1F2Tu2M/TgNYMJGdleFcE5lEEVmQPyCh3V2HWOSVrKdWlXedMH8iPpWjGE/lbryuJMK4iZqj5YeX276XYTx2A==; 5:vW5FDxJZp7O2n1BkB60aiWtGWl4VvzEQcP/ACcYhz8RgNtuzG+ocYxyqGE5DZtvRyGYEsb6qi8r+GwpZ7l2G7oZDiShE6zbelcMq0GSmayrgPW+W4NcYBqjJVUVdinRgzphb/oFpGNQJ3+h7UBMruVOfKx75dCErvYUbQ1VJJGs=; 24:WPmA+mFZV67Hj7EwHyL2TFimZKG1YdVIzvdq/XB/kpllygLByuwn+CGAt/+76GJtdX0BUPwBDpuN0AdTzcl1CJm75bX1AgZX4APtMfY8R0M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 7:DbuHsHR/BhdfxCsrmOZ+wogXFhm2ybcIncCr5wCFSCgSWP+8C3NoSRdAENL6jQRdBJO7BdN3NcwpmZzfUnn5xic3b9Mv/k7LEeeCaaFZXtBkMU4ncnkstFLBgN6aoVU/UWWXGQk3WO2bi/5BzQkmb3IKRz+xtpJU+Mpf6IG8dZVlgt2vpQJX/qtQCLDrfT2LNmASBjYcs74JOeTT+1nRRmqTh5gCBJF0ZoK/sKCOnGhuyCNC2WeAX+gmxH40Cika X-MS-Office365-Filtering-Correlation-Id: 9cfe6ad1-fe07-4612-4007-08d5baf8aaa6 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2018 06:45:50.3595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cfe6ad1-fe07-4612-4007-08d5baf8aaa6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2526 Subject: Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 06:45:54 -0000 -----Original Message----- > Date: Wed, 16 May 2018 14:08:02 +0800 > From: Gavin Hu > To: dev@dpdk.org > CC: gavin hu > Subject: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang > compiling issue > X-Mailer: git-send-email 2.17.0 > > From: gavin hu > > The patch fixes the compile issue with clang on ARM64. Even ARM64 gcc 8.1 could detect this as an error and this patch fixes too. > > Newly introduced #pragma pack(1) in the header file caused comipiling > issues for the files who included it. > > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ > ifpga_fme_dperf.c:5: > In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ > ifpga_feature_dev.h:8: > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_hw.h:8:10: error: > the current #pragma > pack alignment value is modified in the included file [-Werror, > -Wpragma-pack] > ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_defines.h:100:9: note: > previous '#pragma pack' directive that modifies alignment is here. > > The fix is to change the #pragma pack alignment locally and not have > effect on other files who included this header file. > > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code") > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob The subject could change to raw/ifpga: if Maintainer wishes to do so to maintain the consistency. > --- > drivers/raw/ifpga_rawdev/base/ifpga_defines.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > index 0b9622d5f..aa0252720 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_defines.h > @@ -97,7 +97,7 @@ enum port_feature_id { > /* > * All headers and structures must be byte-packed to match the spec. > */ > -#pragma pack(1) > +#pragma pack(push, 1) > > struct feature_header { > union { > @@ -1659,4 +1659,5 @@ struct bts_header { > (((bts_hdr)->guid_h == GBS_GUID_H) && \ > ((bts_hdr)->guid_l == GBS_GUID_L)) > > +#pragma pack(pop) > #endif /* _BASE_IFPGA_DEFINES_H_ */ > -- > 2.17.0 >