From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
stephen@networkplumber.org
Subject: [dpdk-dev] [PATCH] log: fix pattern matching
Date: Wed, 16 May 2018 15:05:23 +0100 [thread overview]
Message-ID: <20180516140523.75519-1-ferruh.yigit@intel.com> (raw)
loglevel set wrong when ":" is used as seperator, like
--log-type="user:debug"
This is because fnmatch returns zero on success. Fixed fnmatch return
value check.
Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
Cc: stephen@networkplumber.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_eal/common/eal_common_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index c660ca659..818118944 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -184,7 +184,7 @@ rte_log_set_level_pattern(const char *pattern, uint32_t level)
if (rte_logs.dynamic_types[i].name == NULL)
continue;
- if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0))
+ if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0) == 0)
rte_logs.dynamic_types[i].loglevel = level;
}
--
2.14.3
next reply other threads:[~2018-05-16 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 14:05 Ferruh Yigit [this message]
2018-05-16 14:09 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-05-21 13:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516140523.75519-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).