From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B48051DA4 for ; Thu, 17 May 2018 12:37:02 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 03:37:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,410,1520924400"; d="scan'208";a="229379631" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga006.fm.intel.com with SMTP; 17 May 2018 03:36:59 -0700 Received: by (sSMTP sendmail emulation); Thu, 17 May 2018 11:36:59 +0100 Date: Thu, 17 May 2018 11:36:58 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org Message-ID: <20180517103658.GA16984@bricha3-MOBL.ger.corp.intel.com> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627457252.53156.7037125685610031955.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152627457252.53156.7037125685610031955.stgit@localhost.localdomain> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 01/23] lib/librte_eal: import libbsd strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 10:37:03 -0000 On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote: > Signed-off-by: Andy Green > --- > lib/librte_eal/common/eal_common_string_fns.c | 34 ++++++++++++++++++++++++ > lib/librte_eal/common/include/rte_string_fns.h | 7 +---- > 2 files changed, 36 insertions(+), 5 deletions(-) > While I'm aware this was suggested by other reviewers, I really don't feel that it is necessary to actually import the code. If libbsd is present on the system, we will use it directly. If libbsd is not present, the snprintf provides an acceptable fallback for strlcpy IMHO. Having the full function without good justification seems excessive. /Bruce