From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 4F5655A44 for ; Thu, 17 May 2018 13:21:00 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id p4-v6so5293975wrh.3 for ; Thu, 17 May 2018 04:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0Gq4+WSfJdP7lVHrQGABPgrqiZOrTEvQuFNrXHrMETA=; b=P2FjlTuo6K0ugxCQt68eeUVEaTM8rQtB6nrcqdw0FuixNf87b0W9ECMeLyxlU+gn6d 9oP5arFhw/5ModsOxvchQHfblyYoNwMfGqjzIHOH5BDIB68w2slEwSe5gQ2TTW7UG+Fo uS/CEfTN8wbT5VP/BYytg+4FfNwowXrDE5RSRbt49Xf96HzU4TR4M6856cwCVWKRsIu2 XvxwLFry+rejxdvp32JCdGRhnuyzjswPuJMdJvD07NulwMEUXy1hKhVttarNv2dww6RJ e6jcegRXYlrwgcEp4fmZ35GbcCIpzADCxaWSoosqzIlIYCcHuqBALNLfbl7jn9b6lixw yp8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0Gq4+WSfJdP7lVHrQGABPgrqiZOrTEvQuFNrXHrMETA=; b=WtI9viT2rKbfORiF05HjLhWxd3nnLwA3lwQIj64ualbLYOOfVfbSdv41yzX3aF6Rbe MYIg56Pg7fri0XQNkWMNJL7tZBZUHezpoNpK3WHfR9s3ndbMz/4yivInxIj+77+GX+Le DLG4h/CH0u7udYF1QCpcriZTajxwL4lJj6kfsUtbY3VGNdHkKWWcjFOFPCqDPwHco8rG REqWTp5K91DMlcSDh23ZfT/RkwsXlBuP0GCd4N1s/9WzzA8amf+S547f829Ft20HGsYY /xdqTrSxFgJYw6R6fuTD7H7dhepnUx4yB7BVSgvVmjn6vHubcN1okK/wAmI49ZaOE4XQ 1IQQ== X-Gm-Message-State: ALKqPwfZqcJ/HjRk/h80FLtgI75V93SObtYl1aLG7KHFaBRz8PJ5/sgy xDjPUry2GVW6bHqqm0KqFHIsZw== X-Google-Smtp-Source: AB8JxZpRRMyPevdJhNthVoDy2KBSRTcEvny9+Pny6sljWzn9bf4sXhC1I8ogvFygAqa6t+VK8wbnMQ== X-Received: by 2002:adf:a850:: with SMTP id l74-v6mr3659372wrc.42.1526556060050; Thu, 17 May 2018 04:21:00 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h12-v6sm4370677wmc.7.2018.05.17.04.20.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 May 2018 04:20:59 -0700 (PDT) Date: Thu, 17 May 2018 13:20:45 +0200 From: Adrien Mazarguil To: "Iremonger, Bernard" Cc: "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180517112045.GE6497@6wind.com> References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com> <20180515162211.7030-1-adrien.mazarguil@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com> <20180516143517.GA6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 11:21:00 -0000 On Thu, May 17, 2018 at 09:26:15AM +0000, Iremonger, Bernard wrote: > Hi Adrien, > > > > > > > Subject: [PATCH] maintainers: fix responsibility of flow API bits > > > > > > > > The following commits lack MAINTAINERS entries for this mess. > > > > > > > > Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") > > > > Fixes: 19c90af6285c ("app/testpmd: add flow command") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Adrien Mazarguil > > > > Cc: Bernard Iremonger > > > > --- > > > > MAINTAINERS | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS index bd08d4292..187817fff > > > > 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -303,6 +303,8 @@ F: devtools/test-null.sh Flow API > > > > M: Adrien Mazarguil > > > > T: git://dpdk.org/next/dpdk-next-net > > > > +F: app/test-pmd/cmdline_flow.c > > > > +F: doc/guides/prog_guide/rte_flow.rst > > > > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > Should be added to the list of flow related files. > > > > I did not add it because there is no way to split responsibility on a > > documentation section basis AFAIK, and only a fraction of this file contains > > information about rte_flow-related stuff. > > > > -- > > Adrien Mazarguil > > 6WIND > > There are already several maintainers for testpmd, adding another maintainer for the flow parts of this file should be ok (I think). True, however providing an exact file name instead of a directory or wildcard makes me the main maintainer/contact for that specific file (e.g. "app/test-pmd/cmdline_flow.c" vs. "app/test-pmd"), basically I do not want to be responsible for the entirety of testpmd's documentation. How about the following instead: another patch that extracts the flow command documentation in its own file (testpmd_flow.rst?) using the include directive (somewhat like cmdline_flow.c). This patch will update MAINTAINERS accordingly. -- Adrien Mazarguil 6WIND