From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] maintainers: fix responsibility of flow API bits
Date: Thu, 17 May 2018 17:50:38 +0200 [thread overview]
Message-ID: <20180517155038.GJ6497@6wind.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CDB76@IRSMSX108.ger.corp.intel.com>
On Thu, May 17, 2018 at 02:51:43PM +0000, Iremonger, Bernard wrote:
> Hi Adrien, Ferruh,
>
> <snip>
>
> > (Another patch will separate testpmd_flow.rst? and add maintainership for it)
>
> There is also a lot of flow related code in dpdk/app/test-pmd/config.c (lines 985 to 1623), maybe this should be moved to a separate file also, with maintainership added for the new file?
I will consider it also, although the majority of that code is a copy of
rte_flow_copy(), which was added later for failsafe PMD needs.
Testpmd was supposed to use the public version but I wanted to replace
rte_flow_copy() with the more flexible rte_flow_conv() first [1][2].
[1] "[PATCH v1 2/7] ethdev: replace flow API object copy function"
http://dpdk.org/ml/archives/dev/2017-October/077553.html
[2] "[PATCH v1 4/7] app/testpmd: rely on flow API conversion function"
http://dpdk.org/ml/archives/dev/2017-October/077555.html
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-05-17 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 9:29 [dpdk-dev] [PATCH] maintainers: add maintainer for testpmd Bernard Iremonger
2018-05-15 16:23 ` [dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits Adrien Mazarguil
2018-05-16 9:18 ` Iremonger, Bernard
2018-05-16 14:35 ` Adrien Mazarguil
2018-05-17 9:26 ` Iremonger, Bernard
2018-05-17 11:20 ` Adrien Mazarguil
2018-05-17 11:26 ` Iremonger, Bernard
2018-05-17 14:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-05-17 14:51 ` Iremonger, Bernard
2018-05-17 15:50 ` Adrien Mazarguil [this message]
2018-05-16 0:44 ` [dpdk-dev] [PATCH] maintainers: add maintainer for testpmd Lu, Wenzhuo
2018-05-22 20:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517155038.GJ6497@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).