From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 5604E7CD9 for ; Thu, 17 May 2018 17:50:54 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id w194-v6so9267260wmf.2 for ; Thu, 17 May 2018 08:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lavTTK+YBNPljDm8ZfJCQ/J1fSHxvjGXSC6R6BVN9/E=; b=LgXLlnSIUvY/dx49vJ0nvLuOPbNVPGiUwSkXtDrN9DhxmhQjV7dEixEuSC5+pPCiX3 b7fVpw/Ax9RIYqBYKJzSRvaMijdWJcnAPqv4Olf1m5LJpgrKDA6Jsqeh2GA6DENUILOM /1mpl6tHF7BhWkcIIgBGQaVVs8DknXZQoIPFLd5L7yrbTdW5enM33UENuOI3ZLn6WorS IijNhWz/8LWFp/xSklx9sfyDRyrEViwYgFlGMxm1YGgsMKgI/NKlJLUJsQVeQum7rIoA Y5792s3qH2WfqRxkuwTcqLv9v3qqUbCMjDZiTnH2k1pcakR34QJefBRCzw/irVzXGJmY eOKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lavTTK+YBNPljDm8ZfJCQ/J1fSHxvjGXSC6R6BVN9/E=; b=eCmU2E6jHWrvdn0mcefSbSrjjjdepSlmAfuggE7aLcLCHOjY6ppT5QiJSWCw3n57CH qD0+lnw3gCqLA5PLJdFxpGHu7F8fUnXDS5H5XpiMP07NFT5yq0K//1pvWUm2CqIWVQu4 NMrnvtQhE7COcqwo0lBJ7F2QUgZRurKV8KLCrtXx1ayNr/9tq+v0s2uzPBcriHcgIO0D Sg+bq8HyjfQF3REZI70u59ZuuVrjW07JCDer6PKXQ3WaGH24Gn/E0+pSyMRClACx/Fv7 WUgSmGJGviq6DDCOvWMbR2jNhmgEYapYbtsxqGBSOPTvzT19I4znwN+lLKFHfkKY4J7k Bqdg== X-Gm-Message-State: ALKqPwdObolKX3uliokicY83ONhOzLrhL3AUaas2lrBx+YAxNuEw4+7l 6sbPH9YIXzOA+fxtv+wj9E3DUw== X-Google-Smtp-Source: AB8JxZr/6DXX3neH5m6VwLI/Bp8Fni2Wc7PCt7ad+diIG5EM6FtAfZr7mVmGcd/OevkuxCAH9k8rAA== X-Received: by 2002:a1c:1f47:: with SMTP id f68-v6mr2049817wmf.4.1526572254117; Thu, 17 May 2018 08:50:54 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f83-v6sm8427847wmh.32.2018.05.17.08.50.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 May 2018 08:50:52 -0700 (PDT) Date: Thu, 17 May 2018 17:50:38 +0200 From: Adrien Mazarguil To: "Iremonger, Bernard" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180517155038.GJ6497@6wind.com> References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com> <20180515162211.7030-1-adrien.mazarguil@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com> <20180516143517.GA6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com> <20180517112045.GE6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com> <7431a0f3-e87e-6b8b-04ae-9fd6e919a699@intel.com> <8CEF83825BEC744B83065625E567D7C24E0CDB76@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CDB76@IRSMSX108.ger.corp.intel.com> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] maintainers: fix responsibility of flow API bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 15:50:54 -0000 On Thu, May 17, 2018 at 02:51:43PM +0000, Iremonger, Bernard wrote: > Hi Adrien, Ferruh, > > > > > (Another patch will separate testpmd_flow.rst? and add maintainership for it) > > There is also a lot of flow related code in dpdk/app/test-pmd/config.c (lines 985 to 1623), maybe this should be moved to a separate file also, with maintainership added for the new file? I will consider it also, although the majority of that code is a copy of rte_flow_copy(), which was added later for failsafe PMD needs. Testpmd was supposed to use the public version but I wanted to replace rte_flow_copy() with the more flexible rte_flow_conv() first [1][2]. [1] "[PATCH v1 2/7] ethdev: replace flow API object copy function" http://dpdk.org/ml/archives/dev/2017-October/077553.html [2] "[PATCH v1 4/7] app/testpmd: rely on flow API conversion function" http://dpdk.org/ml/archives/dev/2017-October/077555.html -- Adrien Mazarguil 6WIND