DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: dev@dpdk.org
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Nikhil Rao <nikhil.rao@intel.com>
Subject: [dpdk-dev]  [PATCH] eventdev: remove ethdev Rx adapter event type
Date: Sun, 20 May 2018 22:18:43 +0530	[thread overview]
Message-ID: <20180520164843.4386-1-jerin.jacob@caviumnetworks.com> (raw)

The initial thought was to create a separate event type
for each adapter, in order to make consistency with
new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER
event type and use RTE_EVENT_TYPE_ETHDEV event type instead
like other event adapters.

Cc: Nikhil Rao <nikhil.rao@intel.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
 lib/librte_eventdev/rte_eventdev.h             | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 6f7050952..8b9887b3d 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -468,7 +468,7 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
 		ev->op = RTE_EVENT_OP_NEW;
 		ev->sched_type = sched_type;
 		ev->queue_id = qid;
-		ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
+		ev->event_type = RTE_EVENT_TYPE_ETHDEV;
 		ev->sub_event_type = 0;
 		ev->priority = priority;
 		ev->mbuf = m;
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index b6fd6ee7f..cef0a55d8 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -948,8 +948,6 @@ rte_event_dev_close(uint8_t dev_id);
 /**< The event generated from cpu for pipelining.
  * Application may use *sub_event_type* to further classify the event
  */
-#define RTE_EVENT_TYPE_ETH_RX_ADAPTER   0x4
-/**< The event generated from event eth Rx adapter */
 #define RTE_EVENT_TYPE_MAX              0x10
 /**< Maximum number of event types */
 
-- 
2.17.0

             reply	other threads:[~2018-05-20 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 16:48 Jerin Jacob [this message]
2018-05-20 17:21 ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520164843.4386-1-jerin.jacob@caviumnetworks.com \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=nikhil.rao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).