From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0044.outbound.protection.outlook.com [104.47.41.44]) by dpdk.org (Postfix) with ESMTP id B88F38D94 for ; Sun, 20 May 2018 19:21:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVefsr6bSqQuyPDmKCxX3auKwCe6VEJVvb2VRFDhSb8=; b=Nohs0Y0pBMHBw1pvKEfpESxRFs9p+dZYQQnKttC0WTRew/OjfxdwzpWOESAT3FkOH4kkwRtuWydHsXmTFfNFR2z3iWvMqbNNESQKVhbCu8hRkIafWgzWaioYddM6NT+kGLo85P3Y5VzZTMmidhcxmJEYKdev4xlw9570IpTDuCk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (202.83.56.49) by SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Sun, 20 May 2018 17:21:22 +0000 Date: Sun, 20 May 2018 22:51:05 +0530 From: Jerin Jacob To: dev@dpdk.org Cc: Nikhil Rao Message-ID: <20180520172104.GA6224@jerin> References: <20180520164843.4386-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180520164843.4386-1-jerin.jacob@caviumnetworks.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-Originating-IP: [202.83.56.49] X-ClientProxiedBy: MA1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::19) To SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:wqypdBqEOZCV8OlZ9XvXBcfqRYXvbOIqgPyixVdvjpFd4sdYNSsfFmDoyJ6+PSooAu7rO1QeG0SSwIoXSYmqQ3hDq40F05dyzMszOshnA+OAMr1dgNV6A8pDMiv1jJJbr9K1nrk4XyE8pJ/Fzou8N9bDyzcul7lZ6ySzb5m/lvVT4JyjKsHX1fADUApOmXxZHklreCFJFI5Lzb3miytIP/DCZxnAHU06SbN6cfupe2t1DQHHUtPDoAu+OBZKNrv3; 25:uoE97PTtuNhe7b+QMO/hHuZ4/oxbRWjM4U3paYp6YuyZ0h43zH+jOlZnwnQVemwF1y0YxtZY/J8wszf2DgrRS046IVa36+m65t5RBfR79IV/VWY7NgeJvasfO21gomWXLoz6fzYa7D7MtkCnXliHOlBmIlRymiSi78zxoVQ63OyZc8+JDu4CX91JVzF+cqCXUbpONZGdqJhIHKeAQuESeFaMRzJ/XRoqeN8uCYl4i+YlGCLFDk2JCpDUQW3PaHBQ/B+hmamVJX0tNsITpnYRK/B90eWARxmZj/GSq+LTfOeSVguX3omYTB4VjIpDSafjF/okH/jEMmENrJ32Ty9Jsw==; 31:iC+1VmRbbk4rZDRfj7RIIlwjg/fBxLC6ztGjIUHXZMzDTRjRYuejQs6Hg6sXYm6wVBYMqI/Znk2CTurj+RqyaFQ6rqYzXset2QrYiNPpKcIqW9n089WraXz/208Y1u8PsMZv50oY2Tr9xHHoKhEfErF490YXbC32/TC3ELAH7aELXPgKeVRDrXukZ05DB5lkXj8PmnSVvAXO0u3sXISNqcyntwYmuxAXdA868Bp4iqs= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:g8boEwRG56d68VbtEnF06nCBrjpeLhToFcZtFUtJmpIYx157paLl4Rlm8ehrCpU8bsK/qpk07W7Dm6bXYEFSnUf6FUT96R1zWcP6ZjqhFzM2ycX4k0N2F/SegsuZhh8sch8gvHWaXtoeE5u1GVG2omnGS8p2X9vSzHjW26vuzaR3EGCPFGSwPs1Q+GPczwJSB0GGG2P4E7ndwKVihNQCIhWoHqbkKxt7MCy1Slr7eAcveVG6Q9XGwf2bS6LzBjeOYBvyu4c6grOfsMEfZz+dbZMJHB4nVrZNBUdHCxHRBA//TIA5SC2+aegjK8YLh/HMxsigAxf+q4TXiMYo8TCQjcqNRxSK5PJ8EDJRPrRWhw1HrxoN4Fs47GTUUtp5X91IzWVLR7+iizO//npJ/0RyZzFvUbEHZe7MChUgiqt2Q21FDaNgXtaMY8/qfzpRwyi6tLEXXABJDbTGUiM9BZjTJ7HHOVQuJ8MJIJYgLpgM21NBGC9HCQq9Z0i1zAPJkza0mm/yplJcj7tXXGEVrxElIQLMQsBvM6Jkc5nKIoG9nKaFSCoF5O5y02syMVRDdvrp1B+mQQWlyQh9DhbErflmsRypHi0ZLNluV3qBFArfguY=; 4:4OBl6gfio7tYAH3SYjJEe1DmAHfWJY20i3ktQdlul2xGopCVnhzgaU++tiFynxatBQvLij/FDy9AS8iwDcKMSm+Fx+LDvjrDsN//sykLNQ7JFirZF4nDqncJEsue8FjNSSNA/ZoJXsn1mpiIDR2DIGmm+tl3fGs4Enq1AFF6bVohnpg1zvfxyBHT/l4hInHhzXmXC6l5L5824lfFO/WoVYQW7RvkS1NkBAfsQ99yeGpW/B1oYGubEJZrS3dzFERSn5+zjIOjPpi9y/TyxJE1m4T6LxN4Q2cz8Jm32mG8sSJJDq25Q75ICZbLh1/sqrKd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(3002001)(10201501046)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2527; X-Forefront-PRVS: 06780E24F8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39850400004)(396003)(366004)(39380400002)(346002)(13464003)(189003)(199004)(16526019)(26005)(2361001)(4326008)(2351001)(186003)(42882007)(316002)(33716001)(16586007)(105586002)(106356001)(58126008)(76176011)(59450400001)(6496006)(11346002)(5660300001)(50466002)(52116002)(486006)(6666003)(68736007)(476003)(956004)(6916009)(44832011)(33896004)(446003)(9686003)(55016002)(6246003)(386003)(53936002)(33656002)(229853002)(47776003)(66066001)(8936002)(6116002)(575784001)(72206003)(23726003)(478600001)(1076002)(2906002)(8676002)(25786009)(81166006)(81156014)(7736002)(97736004)(305945005)(3846002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:3; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2527; 23:ldUsoxvlS4FCG0ol3nq9OICEpIiIeFaEmPVx4C6Pi?= =?us-ascii?Q?mMwm3iVTEG1XbziE4Y5rYXgtRRfppkoW9dJO9EudMpYAlmMS9DSGb5gXsiFb?= =?us-ascii?Q?8JNwyRue6Cfpl+Td/sr8xvW4tdAasLSzy7BKbqBRLzN9+w67BStGm9YHi5ws?= =?us-ascii?Q?5Z7OlzR+bSaN9dpyhgSCLDKeSoLn2RzN+6V/7R9dmfuciSoy5vMwLO49lVei?= =?us-ascii?Q?5qTQbTifLlcrS479dDBRckRaMKd9w8wcVuGBla3rmdaohDe/yCR6SVo/pn8H?= =?us-ascii?Q?FUXI0gMfWe2q7yTB9Ny0/JN2RsOfT1AxxD+h9vgcJJJalUFZn+nGSLYsS8Xw?= =?us-ascii?Q?F1POFna6+Cn4NVtbGzaEIxxpXYtfo68P+qIDhC9Q+xOi4Jn48mbUQsddUN6x?= =?us-ascii?Q?3gvg9EQ4dvupgWotR6z/rfZF4pcx0I4CMrDrf9yslC3dDFRjcD/eB/B7LxVA?= =?us-ascii?Q?c3XWzqWp7OtP4r1hGmrvvRO1g2KrNSV+uYM6ufMYyCreMYekKNkdcVVcAX6E?= =?us-ascii?Q?vIk+oDgzEZLeJcNKDRg7sXQPSSiVqziWzQ1Ejs4NcSsuCCH65n4oh0KLYW1x?= =?us-ascii?Q?DkgFmFkyaEWJKVzkTrZIQQqXb40uyLPy/soO7b4OpMTMGfZ74rUfjj7SzjQ+?= =?us-ascii?Q?MwP9fU7iQWirB7YKK/RoG2NlE95LEDW1K3cD0wgMLdLXATQ/HlR+ihk7G9+Y?= =?us-ascii?Q?RNd6mYd1eGYjMjU0mkc4kMPF/qQeHqVVwhfKfpdybBCybPe3Q8UIqgUBz7q5?= =?us-ascii?Q?NDsu0W+X70bGM3fsRlQa36S+idUTxSXqpithZwGERdY1nW+J1g1DAANa3jmY?= =?us-ascii?Q?TpnEsQRRf22XJcD6X+wxQQIo9MXY44qZ1aBhxAXYmB+MqbOMpPNfsofbz1l/?= =?us-ascii?Q?+FPWbHJWin7qTOpzWtKDNYEPWn8RpCg+0ghU0MERJw4f0J/+mfDKqugg6pPf?= =?us-ascii?Q?B0HXclKJWuSM0jki9Tn/GkEZ3Carf8AVE4u7XOFapHwQzlziGmLWlet2tP/F?= =?us-ascii?Q?LwJBUhKBeMH/Y+mkBHruYtBhU0KruHJoFVfF/CC+t5IrX+r+iUFOaLO7D7Sn?= =?us-ascii?Q?jPpfSbiF6ko3Af/ovvTlBs8g6nViDH3bw1oXQXi+Acot8nW6Ag+qpehTTlYk?= =?us-ascii?Q?ps2faoaNTrc6/LpkR1GUAY1w9atsu4QVv3V0XkxakDgx+nZXyvf8YQj9T4wO?= =?us-ascii?Q?N20PQ9Urr3Xnzrd3kYrsgWED2wWojGSKq3yNK/SYvAK52cgdsTdpONvZU7f2?= =?us-ascii?Q?PHuP0Z7pVM/+/TJyJM1yIBT5fI8wiQ1uTOj7bXZWFdZxJ94MjrywV2XxnkcA?= =?us-ascii?Q?I5Qbmq9L/KcH2M6/5U8Pnc0Y1/B5+/k9yX4iyC2waU+1sri0hUqhjemJAkBB?= =?us-ascii?Q?buX39fh9PMYP6hrPzfIPOWohTAzWIBNqQzUFBOuxMiqg6O7awg3wMiCWULxv?= =?us-ascii?Q?EQra8mjhg=3D=3D?= X-Microsoft-Antispam-Message-Info: 2/jleAhM7xOAFZ9uJ6/zMQEgB5/H6Z5iDhUqjjCkSw94tUVH3eP1s0JU8aXONsFx+wPjf6Nycfx4eMFoIcJcuoFuaapUsS0lcGSz89xM2ACnCfzcI/+yMG2rDLc9LDSOTbQRkI3njJTTpsE9w/1O4x3/0mwMtrPWBVVvuIzfzJkfZ1FiPvz5XryTaB9b0+JE X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:tT8vpyGfzL9KF6kCteng1iYYhNftO+niitOFlhmf71QvE7yLSqrKOn1BQG6EH7Ie9t10Od1XLRKako+dcDLx77+jeWORVRIFaaGaHO1hHeiKmyMmOCOW9cg46A2z5feo38YA6HILrmHV6qVBZXyEsvabsmazVsQKWh6A9Ft7LIirFjNY01VNTb5ASkoJ5SaVOOsVRqO9sXJDk0R212FoQzyGSo+s04FOStqmKq9RGOVfnZECfL1Gdwgi2Mzbm/KqcXgvnbUoODPT2gkSDBngFgi32j87tm46rO1kfFkKelucoAMmPtSD9kJ2ioKyPG7avHiZxrIN90xf99IaY4fGfcKtXeUzFS/MQgNFbJBAhtapKHTR/w63+0sfmlafMioIsBmsEe7mLs2FGl9ynOlLrCZghxublUlGhrrxYy1eR+b+UtaM47QFHCBRyXSytNEP9gz11O4K4pHrj4I9WfDkhw==; 5:KU7s/PE6SdQBoLM127QmisIsuXEwSBmmHTwmT7uaEAEMIABurAgJive+i0PTsVMHRId4A79olzE2XCMbCip8w14xVkfdlL/Zc/PcRH7fVam8Tm6bCCn5QnCrSBarS5tsSBlkHBIE+YbMzPeDSXUhvk1QFX0T93Hu2dlQQ+luHuI=; 24:9QIdZvTB+I6b1tJXBBx7HIabsPcWqCpL8YtK4xzgRke1Fk9TAMzHgfyX8e99X4AkWJOxmIdyQ8po/XyMNXLnYZ6RJYk1N/QtbV6lukG9NK8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 7:lpPjngVjw2mEDTz/m+zOasJbYBWnwqkfQFsSjswAr3Rm2zVXx5Zr+w6K6VYehu2Sh9mvWj4K2FkwXXrrZlL9ZBHouOGNwAIWZ5aOes3aZU/DnnNxhD3OD29a5f5UFzGP3lV0OAHJoAWX8PheeAJZ0mGjFS86CcNTIe2TTfbUMDM4HtVhIURXXGPvyiyRnLrO7ZagnYWeA4yhTCCkoea8bsPLl36lsfN/PxLyTYxzNFr0WdvcSfXtjfojLNTj2SKq X-MS-Office365-Filtering-Correlation-Id: 2c328b87-c4bd-45c1-16dc-08d5be761c5a X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2018 17:21:22.2328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c328b87-c4bd-45c1-16dc-08d5be761c5a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 17:21:27 -0000 -----Original Message----- > Date: Sun, 20 May 2018 22:18:43 +0530 > From: Jerin Jacob > To: dev@dpdk.org > Cc: Jerin Jacob , Nikhil Rao > > Subject: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type > X-Mailer: git-send-email 2.17.0 > > The initial thought was to create a separate event type > for each adapter, in order to make consistency with > new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER > event type and use RTE_EVENT_TYPE_ETHDEV event type instead > like other event adapters. > > Cc: Nikhil Rao > Signed-off-by: Jerin Jacob Self - NACK. external PCIe NW cards + HW eventdev case will failing this case, as RTE_EVENT_TYPE_ETHDEV identifier was used for converting to mbuf in eventdev_dequeue case. > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- > lib/librte_eventdev/rte_eventdev.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > index 6f7050952..8b9887b3d 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -468,7 +468,7 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter, > ev->op = RTE_EVENT_OP_NEW; > ev->sched_type = sched_type; > ev->queue_id = qid; > - ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > + ev->event_type = RTE_EVENT_TYPE_ETHDEV; > ev->sub_event_type = 0; > ev->priority = priority; > ev->mbuf = m; > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index b6fd6ee7f..cef0a55d8 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -948,8 +948,6 @@ rte_event_dev_close(uint8_t dev_id); > /**< The event generated from cpu for pipelining. > * Application may use *sub_event_type* to further classify the event > */ > -#define RTE_EVENT_TYPE_ETH_RX_ADAPTER 0x4 > -/**< The event generated from event eth Rx adapter */ > #define RTE_EVENT_TYPE_MAX 0x10 > /**< Maximum number of event types */ > > -- > 2.17.0 >