Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid count in xstats

["Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>]

On Sun, May 20, 2018 at 10:13:58AM +0200, David Marchand wrote:
> With the commit af4f09f28294 ("net/mlx5: prefix all functions with mlx5"),
> mlx5_xstats_get() is not compliant any longer with the api.
> It always returns the caller max entries count while it should return how
> many entries it wrote/wanted to write.
> 
> Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5")
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
> index 8e427e7..875dd10 100644
> --- a/drivers/net/mlx5/mlx5_stats.c
> +++ b/drivers/net/mlx5/mlx5_stats.c
> @@ -325,7 +325,7 @@ mlx5_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *stats,
>  			stats[i].value = (counters[i] - xstats_ctrl->base[i]);
>  		}
>  	}
> -	return n;
> +	return xstats_n;
>  }
>  
>  /**
> -- 
> 2.7.4

Thanks,

-- 
Nélio Laranjeiro
6WIND